Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for M1 #100

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update for M1 #100

wants to merge 1 commit into from

Conversation

andrewzirkel
Copy link

These are the changes I had to make to run on M1. Feel free to take or leave any of them.

  1. In build_python_framework use 10.9 build of python to have an all intel build. Pyobjc did not have an M1 build that I could see.
  2. In generatejson.py another argument was added in an earlier commit.
  3. In py3_requirements.txt build all binaries, otherwise I got missing dependencies and a broken python.

These are the changes I had to make to run on M1.
@bfreezy
Copy link
Contributor

bfreezy commented Nov 5, 2021

My 2c on the python pieces:

  • I'm not sure that dropping the build from 11 to 10.9 is the right call. Munki doesn't do this and it supports both Intel and Arm.
  • For pyobjc (and everything else), we should probably just add --no-binary :all: at the end of the py3_requirements.txt file and compile everything. Many wheels are x86_64 only at the moment.

@andrewzirkel
Copy link
Author

I agree and did test that but get an error message when running build_python_framework errors at Running setup.py install for pyobjc-framework-AutomaticAssessmentConfiguration with:
file not found #import <AutomaticAssessmentConfiguration/AutomaticAssessmentConfiguration.h>

I haven't looked into it more than that yet.

@erikng
Copy link
Member

erikng commented Dec 2, 2021

I probably should merge the changes I made on macadmins/python to the build script to make it work universally. But yes, 11.0 is not necessary at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants