Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Binned spline CI #62

Merged
merged 17 commits into from
Jan 8, 2025
Merged

Feat: Binned spline CI #62

merged 17 commits into from
Jan 8, 2025

Conversation

EdAtkin
Copy link
Contributor

@EdAtkin EdAtkin commented Dec 19, 2024

Pull request description:

Adding in Binned splines into the SamplePDFValidations.

Changes or fixes:

  • SamplePDFTutorial now also evaluates splines using the BinnedSplineTutorial object which evaluates binned splines.
  • Added a script to produce some dummy binned splines
  • Added new object BinnedSplineTutorial to read in the binned splines and set them up
  • Split out the event-by-event spline systematics into another yaml file
  • Added MaCh3Modes and a converter from NuWroModes into MaCh3Modes

Examples:

Screenshot_20241219_152730
Screenshot_20241219_152944

@github-actions github-actions bot added Validations Further information is requested Cmake labels Dec 19, 2024
@github-actions github-actions bot added the python label Jan 7, 2025
@github-actions github-actions bot added the CI/CD label Jan 7, 2025
KSkwarczynski
KSkwarczynski approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@KSkwarczynski KSkwarczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers

@EdAtkin EdAtkin merged commit 9d42f1a into main Jan 8, 2025
8 of 9 checks passed
@EdAtkin EdAtkin deleted the feature_Binned_spline_CI branch January 8, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSkwarczynski KSkwarczynski KSkwarczynski approved these changes

Assignees
No one assigned
Labels
CI/CD Cmake python Validations Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdAtkin @KSkwarczynski