Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no omitempty for dashboard graphs and value widgets #156

Merged

Conversation

tosuke
Copy link
Contributor

@tosuke tosuke commented May 16, 2024

Some fields in Graph and Metric, such as Metric.Legend is not optional and can be zero value.

Copy link
Contributor

@azukiazusa1 azukiazusa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@azukiazusa1 azukiazusa1 merged commit 15657a5 into mackerelio:master May 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants