Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New JSON and Copy/Paste features break plugin for Unity 2020 #46

Closed
hlgott1593 opened this issue Jan 10, 2024 · 1 comment · Fixed by #47
Closed

New JSON and Copy/Paste features break plugin for Unity 2020 #46

hlgott1593 opened this issue Jan 10, 2024 · 1 comment · Fixed by #47
Assignees
Labels
bug Something isn't working

Comments

@hlgott1593
Copy link

hlgott1593 commented Jan 10, 2024

What happened?

Hi,
This is not really a bug but the README says backwards compatibility to Unity 2019 which does not seem correct anymore.

The issue is both features attempt to get the value of SerializedProperty.managedReferenceValue which is write only for Unity 2020 (any maybe prior did not look into when they changed this).
https://docs.unity3d.com/2020.3/Documentation/ScriptReference/SerializedProperty-managedReferenceValue.html

Considering this is a 3 year old version of unity it is understandable if you do not plan to fix this but if that is the case please update the README with which version of the plugin are supported on each Unity major version.

Thanks (love the plugin btw :))

Package Version

1.2.0

Unity Version

2020.3.48f1

@hlgott1593 hlgott1593 added the bug Something isn't working label Jan 10, 2024
@mackysoft mackysoft linked a pull request Jan 10, 2024 that will close this issue
@mackysoft
Copy link
Owner

Hi @hlgott1593

Fixed to not use getter of SerializedProperty.managedReferenceValue in versions less than Unity 2021.3.
This makes it possible for the latest packages to be available in versions lower than Unity 2021.3.

Latest version here. Please contact me if you have any problems.
https://github.com/mackysoft/Unity-SerializeReferenceExtensions/releases/tag/1.2.1

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants