[orchagent]: Update some functions to use const reference parameters (s…

…onic-net#236)
madhanmellanox · Jun 6, 2017 · d246efe · d246efe
1 parent b893b4f
commit d246efe
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 17 deletions.
diff --git a/orchagent/intfsorch.cpp b/orchagent/intfsorch.cpp
@@ -23,15 +23,15 @@ IntfsOrch::IntfsOrch(DBConnector *db, string tableName) :
     SWSS_LOG_ENTER();
 }
 
-sai_object_id_t IntfsOrch::getRouterIntfsId(string alias)
+sai_object_id_t IntfsOrch::getRouterIntfsId(const string &alias)
 {
     Port port;
     gPortsOrch->getPort(alias, port);
     assert(port.m_rif_id);
     return port.m_rif_id;
 }
 
-void IntfsOrch::increaseRouterIntfsRefCount(const string alias)
+void IntfsOrch::increaseRouterIntfsRefCount(const string &alias)
 {
     SWSS_LOG_ENTER();
 
@@ -40,7 +40,7 @@ void IntfsOrch::increaseRouterIntfsRefCount(const string alias)
                   alias.c_str(), m_syncdIntfses[alias].ref_count);
 }
 
-void IntfsOrch::decreaseRouterIntfsRefCount(const string alias)
+void IntfsOrch::decreaseRouterIntfsRefCount(const string &alias)
 {
     SWSS_LOG_ENTER();
 

diff --git a/orchagent/intfsorch.h b/orchagent/intfsorch.h
@@ -26,15 +26,15 @@ class IntfsOrch : public Orch
 public:
     IntfsOrch(DBConnector *db, string tableName);
 
-    sai_object_id_t getRouterIntfsId(string);
+    sai_object_id_t getRouterIntfsId(const string&);
 
-    void increaseRouterIntfsRefCount(const string);
-    void decreaseRouterIntfsRefCount(const string);
+    void increaseRouterIntfsRefCount(const string&);
+    void decreaseRouterIntfsRefCount(const string&);
 private:
     IntfsTable m_syncdIntfses;
     void doTask(Consumer &consumer);
 
-    int getRouterIntfsRefCount(string);
+    int getRouterIntfsRefCount(const string&);
 
     bool addRouterIntfs(Port &port);
     bool removeRouterIntfs(Port &port);

diff --git a/orchagent/neighorch.cpp b/orchagent/neighorch.cpp
@@ -74,38 +74,38 @@ bool NeighOrch::removeNextHop(IpAddress ipAddress, string alias)
     return true;
 }
 
-sai_object_id_t NeighOrch::getNextHopId(IpAddress ipAddress)
+sai_object_id_t NeighOrch::getNextHopId(const IpAddress &ipAddress)
 {
     assert(hasNextHop(ipAddress));
     return m_syncdNextHops[ipAddress].next_hop_id;
 }
 
-int NeighOrch::getNextHopRefCount(IpAddress ipAddress)
+int NeighOrch::getNextHopRefCount(const IpAddress &ipAddress)
 {
     assert(hasNextHop(ipAddress));
     return m_syncdNextHops[ipAddress].ref_count;
 }
 
-void NeighOrch::increaseNextHopRefCount(IpAddress ipAddress)
+void NeighOrch::increaseNextHopRefCount(const IpAddress &ipAddress)
 {
     assert(hasNextHop(ipAddress));
     m_syncdNextHops[ipAddress].ref_count ++;
 }
 
-void NeighOrch::decreaseNextHopRefCount(IpAddress ipAddress)
+void NeighOrch::decreaseNextHopRefCount(const IpAddress &ipAddress)
 {
     assert(hasNextHop(ipAddress));
     m_syncdNextHops[ipAddress].ref_count --;
 }
 
-bool NeighOrch::getNeighborEntry(const IpAddress& ipAddress, NeighborEntry& neighborEntry, MacAddress& macAddress)
+bool NeighOrch::getNeighborEntry(const IpAddress &ipAddress, NeighborEntry &neighborEntry, MacAddress &macAddress)
 {
     if (!hasNextHop(ipAddress))
     {
         return false;
     }
 
-    for (const auto& entry : m_syncdNeighbors)
+    for (const auto &entry : m_syncdNeighbors)
     {
         if (entry.first.ip_address == ipAddress)
         {

diff --git a/orchagent/neighorch.h b/orchagent/neighorch.h
@@ -54,11 +54,11 @@ class NeighOrch : public Orch, public Subject
 
     bool hasNextHop(IpAddress);
 
-    sai_object_id_t getNextHopId(IpAddress);
-    int getNextHopRefCount(IpAddress);
+    sai_object_id_t getNextHopId(const IpAddress&);
+    int getNextHopRefCount(const IpAddress&);
 
-    void increaseNextHopRefCount(IpAddress);
-    void decreaseNextHopRefCount(IpAddress);
+    void increaseNextHopRefCount(const IpAddress&);
+    void decreaseNextHopRefCount(const IpAddress&);
 
     bool getNeighborEntry(const IpAddress&, NeighborEntry&, MacAddress&);