Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static classes #185

Merged
merged 5 commits into from
Jul 27, 2022
Merged

Add static classes #185

merged 5 commits into from
Jul 27, 2022

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Jul 5, 2022

Follow-up of #104.

Add static classes under feature flags "unstable-static-class" and "unstable-static-class-inlined".

TODO:

  • Documentation
  • Investigate how weak linkage works
    • Not something we can do in Rust yet. If the symbol is not available, the code either fails to compile, or the dynamic linker fails to load it (so luckily it doesn't lead to unsoundness!)
  • Make this work on macOS x86
  • Make this work on GNUStep Postponed
  • Figure out if we should add an UnregisteredClass struct or similar, see Sending messages is inefficient because of selector lookup SSheldon/rust-objc#49 (comment).
    • Going to postpone this as well,

@madsmtm madsmtm added enhancement New feature or request A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates labels Jul 5, 2022
@madsmtm madsmtm force-pushed the static-class branch 3 times, most recently from 0c9566b to be73526 Compare July 5, 2022 18:38
@madsmtm madsmtm mentioned this pull request Jul 7, 2022
8 tasks
@madsmtm madsmtm force-pushed the static-class branch 5 times, most recently from f4a6bf3 to 99cd14d Compare July 27, 2022 01:58
@madsmtm madsmtm marked this pull request as ready for review July 27, 2022 02:00
@madsmtm madsmtm force-pushed the static-class branch 4 times, most recently from 20e43fb to 7674231 Compare July 27, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant