From ac6fd1dbfefb01a62f68c0fae733875002cbb593 Mon Sep 17 00:00:00 2001 From: Louis Matthijssen Date: Tue, 16 May 2023 15:34:38 +0200 Subject: [PATCH] Fix warning caused by usage of deprecated `Application.get_env` It seems that this should already be fixed, but I think the `function_exported?` check doesn't work for macros. The minimum version is already Elixir 1.10, so it should be safe to remove the whole check. --- lib/crontab/cron_expression/ecto_type.ex | 12 +----------- lib/crontab/scheduler.ex | 8 +------- test/crontab/cron_expression/ecto_type_test.exs | 10 +--------- 3 files changed, 3 insertions(+), 27 deletions(-) diff --git a/lib/crontab/cron_expression/ecto_type.ex b/lib/crontab/cron_expression/ecto_type.ex index 5c8481c..a27d865 100644 --- a/lib/crontab/cron_expression/ecto_type.ex +++ b/lib/crontab/cron_expression/ecto_type.ex @@ -1,14 +1,4 @@ -# TODO: Replace with simple Code.ensure_compiled as soon as Elixir minimum -# version is raised to 1.10. - -Code -|> function_exported?(:ensure_compiled, 1) -|> if do - match?({:module, Ecto.Type}, Code.ensure_compiled(Ecto.Type)) -else - :erlang.apply(Code, :ensure_compiled?, [Ecto.Type]) -end -|> if do +if match?({:module, Ecto.Type}, Code.ensure_compiled(Ecto.Type)) do defmodule Crontab.CronExpression.Ecto.Type do @moduledoc """ Provides a type for Ecto usage. diff --git a/lib/crontab/scheduler.ex b/lib/crontab/scheduler.ex index 5f0135c..fe8650d 100644 --- a/lib/crontab/scheduler.ex +++ b/lib/crontab/scheduler.ex @@ -13,13 +13,7 @@ defmodule Crontab.Scheduler do @type direction :: :increment | :decrement @type result :: maybe(NaiveDateTime.t(), any) - # TODO: Remove if when requiring Elixir 1.10 + only - if function_exported?(Application, :compile_env, 3) do - @max_runs Application.compile_env(:crontab, :max_runs, 10_000) - else - # credo:disable-for-next-line Credo.Check.Warning.ApplicationConfigInModuleAttribute - @max_runs Application.get_env(:crontab, :max_runs, 10_000) - end + @max_runs Application.compile_env(:crontab, :max_runs, 10_000) @doc """ This function provides the functionality to retrieve the next run date from a diff --git a/test/crontab/cron_expression/ecto_type_test.exs b/test/crontab/cron_expression/ecto_type_test.exs index 5573eea..fd3ba82 100644 --- a/test/crontab/cron_expression/ecto_type_test.exs +++ b/test/crontab/cron_expression/ecto_type_test.exs @@ -1,12 +1,4 @@ -# TODO: Replace with simple Code.ensure_compiled as soon as Elixir min. version is raised to 1.10 -Code -|> function_exported?(:ensure_compiled, 1) -|> if do - match?({:module, Ecto.Type}, Code.ensure_compiled(Ecto.Type)) -else - :erlang.apply(Code, :ensure_compiled?, [Ecto.Type]) -end -|> if do +if match?({:module, Ecto.Type}, Code.ensure_compiled(Ecto.Type)) do defmodule Crontab.CronExpression.Ecto.TypeTest do @moduledoc false