Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17] Read API :: Integration tests :: Customer* #55

Closed
mslabko opened this issue Jun 9, 2020 · 4 comments
Closed

[17] Read API :: Integration tests :: Customer* #55

mslabko opened this issue Jun 9, 2020 · 4 comments
Assignees
Milestone

Comments

@mslabko
Copy link
Member

mslabko commented Jun 9, 2020

PR

Fixed in magento/magento2#28746

In the scope of delivery #17 need to fix integration tests Magento.Customer*:

Needed branches:

Dev notes:

  • some classes in catalog-storefront repo are autogenerated (marked as "Generated by the Magento PHP proto generator. DO NOT EDIT!") If you still need to edit them to fix test, please mention it in the comment

Example of error:
Stacktrace
Magento\Customer\Block\Adminhtml\Edit\Tab\View\WishlistTest::testWishListGrid
Failed asserting that actual size 0 matches expected size 1.

Magento.Customer.Block.Adminhtml.Edit.Tab.View.WishlistTest.testWishListGrid
Magento.Customer.Block.Adminhtml.Edit.Tab.View.WishlistTest.testWishListGrid
Magento.Customer.Controller.Section.LoadTest.testWishListCounterUseQty
Magento.Customer.Controller.Section.LoadTest.testWishListCounterNotUseQty
Magento.Customer.Controller.Section.LoadTest.testWishListCounterUseQty
Magento.Customer.Controller.Section.LoadTest.testWishListCounterNotUseQty

@m2-assistant
Copy link

m2-assistant bot commented Jun 9, 2020

Hi @mslabko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@skovalenk
Copy link
Contributor

Started working on the ticket

@mslabko
Copy link
Member Author

mslabko commented Jun 11, 2020

Almost all tests were fixed by your PR https://github.com/magento/magento2/pull/28669/files (tested on internal CICD)
Thank you, @skovalenk !

@skovalenk
Copy link
Contributor

PR: magento/magento2#28669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants