Product variants #413

bricht · 2020-11-05T15:12:16Z

Description (*)

Related Pull Requests

magento/commerce-data-export#8
https://github.com/magento-commerce/graphql/pull/4
https://github.com/magento-commerce/magento2-infrastructure/pull/1368
https://git.corp.adobe.com/ecp/api-protos/pull/22
duhon/magento-docker#30

Fixed Issues (if relevant)

Fixes [357.3] Import data to SF Application #331
Fixes [357.4] GetProductVariants service #332
Fixes [357.6] DeleteProductVariants service #335

Questions or comments

Code Review Checklist (*)

See detailed checklist

Story AC is completed
proposed changes correspond to Magento Technical Vision
new or changed code is covered with web-api/integration tests (if applicable)
- expected results in test verified with data from fixture
no backward incompatible changes
Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
- prerequisite: story branch created with all needed generated classes according to proposes schema-changes
- DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
- Check composer.json dependencies
Legacy code is deleted
- Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
- And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
- Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
- Any “mapper” on Message Broker (between Export API and SF API)
  - if mapper still needed, verify fields used in mapping, remove not relevant fields

-Added string type or message entity id to accomodate product variants

-Added product variant write and delete functionality to Catalog Storefront

-Modified GetProductVariants and DeleteProductVariants to the VariantService

-static fixes

-Added test -Improved elasticsearch deleteByQuery -Added some exceptions for empty variant response

-Test fix

-Removed old ConfigurableVariantsExtractor

-Changed entity_id type to string in order to pass product variant message correctly

-Fixed and added tests -Other minor fixes and improvements like syntax, docBlock, constants, etc.

Merge

bricht · 2020-11-05T15:29:54Z

@magento run all tests
without extensions magento/saas-export, magento/data-solutions-services-id, magento/magento-services-connector

-Test fix

bricht · 2020-11-06T11:23:24Z

@magento run all tests
without extensions magento/saas-export, magento/data-solutions-services-id, magento/magento-services-connector

-Extended searchEntries and other small fixes

bricht · 2020-11-09T11:44:54Z

@magento run all tests
without extensions magento/saas-export, magento/data-solutions-services-id, magento/magento-services-connector

bricht · 2020-11-09T13:47:43Z

@magento run Integration Tests
without extensions magento/saas-export, magento/data-solutions-services-id, magento/magento-services-connector

RuslanKostiv1 · 2020-11-09T23:17:54Z

app/code/Magento/CatalogStorefront/Model/Storage/State.php

@@ -41,6 +41,8 @@ public function getAliasName(): string
    /**
     * Get current data source name of storage taking into account version of the data source.
     *
+     * TODO: Adapt to work without store code


please create a separate ticket for this and mention id here

RuslanKostiv1 · 2020-11-10T00:53:18Z

app/code/Magento/CatalogStorefront/Test/Api/ProductVariants/ConfigurableVariantsTest.php

+            $this->productRepository->get('simple_10'),
+            $this->productRepository->get('simple_20')


add product variants that represent 2 configurable options:
size: s, m, l
color: red, green, blue
so you'll have 9 simple products (variants):

s-red s-green s-blue m-red m-green m-blue l-red l-green l-blue

RuslanKostiv1 · 2020-11-10T03:21:15Z

app/code/Magento/CatalogStorefront/Model/VariantService.php

+     * @throws RuntimeException
+     * @throws \Throwable
+     */
+    public function GetProductVariants(ProductVariantRequestInterface $request): ProductVariantResponseInterface


I have created configurable product with 2 options:
Color: red, green, blue
Size: s, m, l

result of this method is incorrect

Each variation should have 2 option values, but as we see on the screenshot only half of them have 2 options, the rest of them have 1 option value for some reason.

For id configurable/32/36 there's only one option value 32:color/Y29uZmlndXJhYmxlLzkzLzE0 however in storage we have 2 records

Was a bug with max search size. Changed it to 5000 and added a ticket for pagination.

RuslanKostiv1 · 2020-11-10T03:23:00Z

...i-functional/testsuite/Magento/CatalogMessageBroker/Model/MessageBus/ProductVariantsTest.php

+        $simple1 = $this->getProduct(self::SIMPLE1_SKU);
+        $simple1Id = $simple1->getId();
+        $simple2 = $this->getProduct(self::SIMPLE2_SKU);
+        $simple2Id = $simple2->getId();


add more variants to configurable product

RuslanKostiv1 · 2020-11-10T03:26:30Z

@magento run all tests

-Added more variants to tests -Fixed search bug

bricht · 2020-11-10T15:29:19Z

@magento run all tests

RuslanKostiv1 · 2020-11-10T21:53:41Z

@magento run all tests

RuslanKostiv1 · 2020-11-12T19:11:19Z

@magento run all tests

bricht · 2020-11-12T19:33:13Z

@magento run WebApi Tests

bricht · 2020-11-12T19:33:49Z

@magento run WebAPI Tests

RuslanKostiv1 · 2020-11-12T19:38:11Z

@magento run all tests

RuslanKostiv1 · 2020-11-12T21:10:13Z

@magento run all tests

RuslanKostiv1 · 2020-11-12T22:09:19Z

@magento run Static tests

RuslanKostiv1 · 2020-11-12T22:18:39Z

@magento run Static Tests

-Added debug statement to a test

bricht · 2020-11-13T09:29:57Z

@magento run WebAPI Tests

This reverts commit 3ab8815.

bricht · 2020-11-13T10:07:00Z

@magento run WebAPI Tests

-Added temp code for testing

bricht · 2020-11-13T10:44:55Z

@magento run WebAPI Tests

bricht · 2020-11-13T11:45:45Z

@magento run Integration Tests

bricht · 2020-11-13T11:46:02Z

@magento run Unit Tests

This reverts commit 0c0fa11.

-Added debug code

bricht · 2020-11-13T12:42:19Z

@magento run all tests

This reverts commit 7775563.

bricht · 2020-11-13T13:02:15Z

@magento run all tests

bricht · 2020-11-13T14:47:11Z

@magento run all tests

RuslanKostiv1 · 2020-11-13T15:51:52Z

@magento run all tests

RuslanKostiv1 · 2020-11-13T16:30:16Z

@magento run Static Tests

RuslanKostiv1 · 2020-11-13T17:05:17Z

@magento run Static Tests

RuslanKostiv1 · 2020-11-13T18:07:56Z

@magento import pr to magento-commerce/catalog-storefront-ce

magento-engcom-team · 2020-11-13T18:09:13Z

@RuslanKostiv1 the pull request successfully imported.

jekabs and others added 13 commits October 21, 2020 16:06

Product variants

400334b

-Added string type or message entity id to accomodate product variants

Product variants

e5dde08

-Added product variant write and delete functionality to Catalog Storefront

Product variants

239f3e4

-Modified GetProductVariants and DeleteProductVariants to the VariantService

Product variants

209937d

-static fixes

Merge branch 'develop' into 27_product-variants

950d865

Product variants

6d57388

-Added test -Improved elasticsearch deleteByQuery -Added some exceptions for empty variant response

Product variants

eed02bc

-Test fix

Product variants

4300f91

-Removed old ConfigurableVariantsExtractor

Product variants

aad8769

Product variants

617352d

-Changed entity_id type to string in order to pass product variant message correctly

Product variants

6c5bf07

-Fixed and added tests -Other minor fixes and improvements like syntax, docBlock, constants, etc.

Merge pull request magento#1 from magento/develop

1608c98

Merge

Merge branch 'develop' into 27_product-variants

292ab85

This was referenced Nov 5, 2020

Configurable variants saving to cache OLD magento/commerce-data-export#5

Closed

Product variants OLD PR #400

Merged

Product variants

e4a31d5

-Test fix

Product variants

6d27f37

-Extended searchEntries and other small fixes

RuslanKostiv1 requested changes Nov 10, 2020

View reviewed changes

Product variants

a400541

-Added more variants to tests -Fixed search bug

RuslanKostiv1 added 2 commits November 10, 2020 14:42

27: Product variants

546c323

27: Product variants

cf845cd

RuslanKostiv1 mentioned this pull request Nov 10, 2020

27 product variants magento/commerce-data-export#8

Merged

7 tasks

27: Product variants

8b7b8b3

Product variants

3ab8815

-Added debug statement to a test

Revert "Product variants"

077343c

This reverts commit 3ab8815.

Product variants

0c0fa11

-Added temp code for testing

jekabs added 2 commits November 13, 2020 13:54

Revert "Product variants"

b7c204f

This reverts commit 0c0fa11.

Product Variants

7775563

-Added debug code

Revert "Product Variants"

c5dba4b

This reverts commit 7775563.

mmansoor-magento merged commit 30e0b62 into magento:develop Nov 13, 2020

m2-community-project bot added the Progress: done label Nov 13, 2020

RuslanKostiv1 linked an issue Nov 13, 2020 that may be closed by this pull request

[Story] Support for Configurable Product variants in Storefront App #357

Closed

		$this->productRepository->get('simple_10'),
		$this->productRepository->get('simple_20')

Product variants #413

Product variants #413

Conversation

bricht commented Nov 5, 2020 • edited by RuslanKostiv1 Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Questions or comments

Code Review Checklist (*)

bricht commented Nov 5, 2020

bricht commented Nov 6, 2020

bricht commented Nov 9, 2020

bricht commented Nov 9, 2020

RuslanKostiv1 Nov 9, 2020

Choose a reason for hiding this comment

bricht Nov 10, 2020

Choose a reason for hiding this comment

RuslanKostiv1 Nov 10, 2020

Choose a reason for hiding this comment

bricht Nov 10, 2020

Choose a reason for hiding this comment

RuslanKostiv1 Nov 10, 2020

Choose a reason for hiding this comment

bricht Nov 10, 2020 • edited Loading

Choose a reason for hiding this comment

RuslanKostiv1 Nov 10, 2020

Choose a reason for hiding this comment

bricht Nov 10, 2020

Choose a reason for hiding this comment

RuslanKostiv1 commented Nov 10, 2020

bricht commented Nov 10, 2020

RuslanKostiv1 commented Nov 10, 2020

RuslanKostiv1 commented Nov 12, 2020

bricht commented Nov 12, 2020

bricht commented Nov 12, 2020

RuslanKostiv1 commented Nov 12, 2020

RuslanKostiv1 commented Nov 12, 2020

RuslanKostiv1 commented Nov 12, 2020

RuslanKostiv1 commented Nov 12, 2020

bricht commented Nov 13, 2020

bricht commented Nov 13, 2020

bricht commented Nov 13, 2020

bricht commented Nov 13, 2020

bricht commented Nov 13, 2020

bricht commented Nov 13, 2020

bricht commented Nov 13, 2020

bricht commented Nov 13, 2020

RuslanKostiv1 commented Nov 13, 2020

RuslanKostiv1 commented Nov 13, 2020

RuslanKostiv1 commented Nov 13, 2020

RuslanKostiv1 commented Nov 13, 2020

magento-engcom-team commented Nov 13, 2020

bricht commented Nov 5, 2020 •

edited by RuslanKostiv1

Loading

bricht Nov 10, 2020 •

edited

Loading