Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

magento/devdocs#5245: Markdown linting: Hard tabs (MD010) #5362

Closed
wants to merge 1 commit into from
Closed

magento/devdocs#5245: Markdown linting: Hard tabs (MD010) #5362

wants to merge 1 commit into from

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Sep 11, 2019 •
edited by dobooth
Loading

Purpose of this pull request

This pull request (PR) fixes #5245

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@atwixfirster atwixfirster changed the title magento/devdocs#5245: Markdown linting: Hard tabs (MD010) #5245 magento/devdocs#5245: Markdown linting: Hard tabs (MD010) Sep 11, 2019
hguthrie
hguthrie suggested changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@hguthrie hguthrie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some hard tabs are the only thing holding code blocks in place. Needs more work or needs the code block fixes.

Also, skews the ordered list numbering.

hguthrie
hguthrie reviewed Sep 17, 2019
View reviewed changes
_includes/cloud/cli-get-started.md

magento-cloud login
3. List your projects. With the project ID, you can complete additional commands.
magento-cloud login
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A step that includes code blocks, images, or step sub-paragraphs should begin at the same position as the first letter of the step sentence. Otherwise, this ordered list loses the order and formatting. You will have to review each file to ensure that replacing the hard tab does not adversely affect the formatting of the topic elements.

@hguthrie
Copy link
Contributor

Will you be addressing this PR or will you be focused on the other related PRs, such as #5471 ?

@atwixfirster
Copy link
Contributor Author

atwixfirster commented Sep 25, 2019 •
edited
Loading

Will you be addressing this PR or will you be focused on the other related PRs, such as #5471 ?

Hi, @hguthrie!

This PR is a huge and will be a hard to support it. So, we decided to break it into pieces.

#5471 is a piece that affected files in the guides/cloud folder only.

@hguthrie
Copy link
Contributor

Yes, I understood that, but I ask because I will be closing this PR. Thanks!

@hguthrie hguthrie closed this Sep 25, 2019
@ghost
Copy link

ghost commented Sep 25, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hguthrie hguthrie hguthrie requested changes

Assignees
No one assigned
Labels
Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdown linting: Hard tabs (MD010)
4 participants
@atwixfirster @devops-devdocs @hguthrie @magento-engcom-team