Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Limit list of filterable product fields #26

Closed
paliarush opened this issue May 16, 2018 · 0 comments
Closed

Limit list of filterable product fields #26

paliarush opened this issue May 16, 2018 · 0 comments

Comments

@paliarush
Copy link
Contributor

paliarush commented May 16, 2018

Currently the list of filterable fields includes fields that we decided should not be returned by the storefront API, so they need to unavailable to filter by:

General

  • old_id
  • visibility (this is being used in Deepty's tests)
  • weight_type

Catalog, but not simple or configurable products

  • shipment_type
  • sku_type
  • tax_class_id
  • category_ids
  • samples_title
  • links_title
  • links_exist

Price-related

  • cost
  • minimal price
  • msrp
  • msrp_display_actual_price_type
  • price_type

Changes should be covered with web API functional tests. See \Magento\GraphQl\Catalog\ProductViewTest::testQueryAllFieldsSimpleProduct as an example.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants