Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Add customer account validation in Quote operations #486

Closed
naydav opened this issue Mar 15, 2019 · 2 comments
Closed

Add customer account validation in Quote operations #486

naydav opened this issue Mar 15, 2019 · 2 comments
Labels
Checkout Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers
Milestone
Release: 2.3.3

Comments

@naydav
Copy link
Contributor

naydav commented Mar 15, 2019

Now "locked" or "not confirmed" customer could perform any operation with own cart.

Need to add the check with \Magento\CustomerGraphQl\Model\Customer\GetCustomer::execute (see examples of using this class in code)
in
https://github.com/magento/graphql-ce/blob/2.3-develop/app/code/Magento/QuoteGraphQl/Model/Cart/GetCartForUser.php#L84
to avoid this behavior.

Functionality should be covered with API-functional tests.
@naydav naydav self-assigned this Mar 15, 2019
@naydav naydav added Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers labels May 3, 2019
@naydav naydav added this to the Release: 2.3.3 milestone May 3, 2019
@naydav naydav removed their assignment May 3, 2019
@naydav naydav added the Checkout label May 7, 2019
@naydav naydav changed the title Check customer account in Quote operations Add customer account check in Quote operations May 7, 2019
@naydav naydav changed the title Add customer account check in Quote operations Add customer account validation in Quote operations May 7, 2019
@vovsky vovsky self-assigned this May 15, 2019
vovsky added a commit to vovsky/graphql-ce that referenced this issue May 16, 2019
@vovsky
magento#486 added customer account validation in Quote operations
b1112e0
@vovsky vovsky mentioned this issue May 16, 2019
Merged
4 tasks
lenaorobei added a commit to vovsky/graphql-ce that referenced this issue Jun 10, 2019
@lenaorobei
magento#486: Add customer account validation in Quote operations
a01954c
naydav added a commit to vovsky/graphql-ce that referenced this issue Jun 12, 2019
@naydav
magento#486: Add customer account validation in Quote operations
b653378
naydav added a commit to vovsky/graphql-ce that referenced this issue Jun 14, 2019
@naydav
magento#486: Add customer account validation in Quote operations
1bf1312
naydav added a commit to vovsky/graphql-ce that referenced this issue Jun 14, 2019
@naydav
magento#486: Add customer account validation in Quote operations
40a751c
naydav added a commit to vovsky/graphql-ce that referenced this issue Jun 14, 2019
@naydav
magento#486: Add customer account validation in Quote operations
fcba596
naydav added a commit to vovsky/graphql-ce that referenced this issue Jun 14, 2019
@naydav
magento#486: Add customer account validation in Quote operations
79f2669
naydav added a commit to vovsky/graphql-ce that referenced this issue Jun 14, 2019
@naydav
magento#486: Add customer account validation in Quote operations
19a5128
naydav pushed a commit to vovsky/graphql-ce that referenced this issue Jun 20, 2019
@vovsky @naydav
magento#486 added customer account validation in Quote operations
f91224e
naydav pushed a commit to vovsky/graphql-ce that referenced this issue Jun 20, 2019
@lenaorobei @naydav
magento#486: Add customer account validation in Quote operations
65c6327
naydav added a commit to vovsky/graphql-ce that referenced this issue Jun 20, 2019
@naydav
magento#486: Add customer account validation in Quote operations
0a68474
naydav added a commit to vovsky/graphql-ce that referenced this issue Jun 20, 2019
@naydav
magento#486: Add customer account validation in Quote operations
a8ea439
naydav added a commit to vovsky/graphql-ce that referenced this issue Jun 20, 2019
@naydav
magento#486: Add customer account validation in Quote operations
d983e25
naydav added a commit to pmclain/graphql-ce that referenced this issue Jun 20, 2019
@naydav
magento#486: Add customer account validation in Quote operations
283b8dd
naydav added a commit to vovsky/graphql-ce that referenced this issue Jun 20, 2019
@naydav
magento#486: Add customer account validation in Quote operations
7fc5494
naydav added a commit that referenced this issue Jun 20, 2019
@naydav
#486: Add customer account validation in Quote operations
30829e4
naydav added a commit to vovsky/graphql-ce that referenced this issue Jun 20, 2019
@naydav
magento#486: Add customer account validation in Quote operations
0890aa8
magento-engcom-team added a commit that referenced this issue Jun 21, 2019
@magento-engcom-team
ENGCOM-5295: #486 added customer account validation in Quote operations
85ed3e7 
#714

 - Merge Pull Request #714 from vovsky/graphql-ce:486-add-customer-account-validation-in-quote-operations
 - Merged commits:
   1. f91224e
   2. 65c6327
   3. 0a68474
   4. a8ea439
   5. d983e25
   6. 7fc5494
   7. 0890aa8
@naydav
Copy link
Contributor Author

naydav commented Jun 21, 2019

#714

@lenaorobei
Copy link
Contributor

Fixed in #714

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Checkout Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers
Projects
None yet
Milestone
Release: 2.3.3
Development

No branches or pull requests
3 participants
@naydav @vovsky @lenaorobei