Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Remove try-catch construction #1002

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Remove try-catch construction #1002

merged 2 commits into from
Oct 22, 2019

Conversation

TomashKhamlai
Copy link
Contributor

Description (*)

As long as

type Mutation {
    addDownloadableProductsToCart(input: AddDownloadableProductsToCartInput): AddDownloadableProductsToCartOutput @resolver(class: "Magento\\QuoteGraphQl\\Model\\Resolver\\AddSimpleProductsToCart")
}

is not changed, this exception caching is a duplicate of one that is in \Magento\QuoteGraphQl\Model\Resolver\AddSimpleProductsToCart::execute();

Fixed Issues (if relevant)

  1. [Test Coverage] Cover exception in Magento\DownloadableGraphQl\Model\Cart\BuyRequest\DownloadableLinksDataProvider #823: [Test Coverage] Cover exception in Magento\DownloadableGraphQl\Model\Cart\BuyRequest\DownloadableLinksDataProvider

Manual testing scenarios (*)

  1. n/a

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@TomashKhamlai
Remove try-catch construction
7dc9e64 
As long as
```graphql
type Mutation {
    addDownloadableProductsToCart(input: AddDownloadableProductsToCartInput): AddDownloadableProductsToCartOutput @resolver(class: "Magento\\QuoteGraphQl\\Model\\Resolver\\AddSimpleProductsToCart")
}
```
is not changed, this exception caching is a duplicate of one that is in \Magento\QuoteGraphQl\Model\Resolver\AddSimpleProductsToCart::execute();

Signed-off-by: Tomash Khamlai <tomash.khamlai@gmail.com>
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6064 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@TomashKhamlai
Change Exception message for testAddNonExistentConfigurableProductVar…
f45a672 
…iationToCart

Signed-off-by: Tomash Khamlai <tomash.khamlai@gmail.com>
@magento-engcom-team magento-engcom-team mentioned this pull request Oct 22, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Oct 22, 2019
@lenaorobei
ENGCOM-6064: Remove try-catch construction #1002
de81a7f
@magento-engcom-team magento-engcom-team merged commit f45a672 into magento:2.3-develop Oct 22, 2019
@ghost
Copy link

ghost commented Oct 22, 2019

Hi @TomashKhamlai, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@lenaorobei lenaorobei

Labels
approved Auto-Tests: Covered Cleanup Component: DownloadableGraphQl Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomashKhamlai @magento-engcom-team @lenaorobei