Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

675 test generate customer token #677

Merged
merged 6 commits into from
Jun 12, 2019
Merged

675 test generate customer token #677

merged 6 commits into from
Jun 12, 2019

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented May 6, 2019 •
edited by naydav
Loading

Description (*)

API-functional test coverage for

generateCustomerToken(email: String!, password: String!): CustomerToken @resolver(class: "\\Magento\\CustomerGraphQl\\Model\\Resolver\\GenerateCustomerToken") @doc(description:"Retrieve the customer token")

Fixed Issues (if relevant)

#675: [Test coverage] Generate customer token

@atwixfirster atwixfirster mentioned this pull request May 6, 2019
Closed
@vpodorozh vpodorozh self-requested a review May 10, 2019 21:14
vpodorozh
vpodorozh approved these changes May 11, 2019
View reviewed changes
Copy link
Contributor

@vpodorozh vpodorozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atwixfirster ... no backward incompatibility :)

@vpodorozh vpodorozh self-assigned this Jun 4, 2019
@lenaorobei
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5238 has been created to process this Pull Request

@naydav naydav merged commit ecbf99c into 2.3-develop Jun 12, 2019
@ghost
Copy link

ghost commented Jun 12, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

naydav pushed a commit that referenced this pull request Jun 12, 2019
@lenaorobei
ENGCOM-5238: 675 test generate customer token #677
9629fac
naydav pushed a commit that referenced this pull request Jun 12, 2019
@lenaorobei
ENGCOM-5238: 675 test generate customer token #677
b024826
@lenaorobei lenaorobei deleted the 675-test-generate-customer-token branch September 10, 2019 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vpodorozh vpodorozh vpodorozh approved these changes

@lenaorobei lenaorobei lenaorobei approved these changes

Assignees

@vpodorozh vpodorozh

@lenaorobei lenaorobei

Labels
Award: test coverage Partner: Atwix partners-contribution Progress: accept Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atwixfirster @lenaorobei @magento-engcom-team @vpodorozh @naydav