Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Deprecate setPaymentMethodAndPlaceOrderMutation #916

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

pmclain
Copy link
Contributor

@pmclain pmclain commented Sep 7, 2019

Description (*)

The #723 introduces setPaymentAndPlaceOrder mutation to set the payment method for the cart and place an order via the same mutation.
After internal discussion, we decided to remove setPaymentAndPlaceOrder as GraphQL guarantees that multiple mutations will be executed one by one via one HTTP request https://graphql.org/learn/queries/.

Fixed Issues (if relevant)

  1. [Checkout] Remove setPaymentAndPlaceOrder mutation #875

Manual testing scenarios (*)

  1. Create empty cart
  2. Add product to cart
  3. Set shipping address and method (if cart is not virtual)
  4. Set billing address
mutation {
  setPaymentMethodOnCart(
    input: {
      cart_id: "{$maskedQuoteId}"
      payment_method: {
        code: "{$methodCode}"
      }
    }
  ) {
    cart {
      selected_payment_method {
        code
      }
    }
  }
  placeOrder(
    input: {
      cart_id: "{$maskedQuoteId}"
    }
  ) {
    order {
      order_id
    }
  }
}

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5814 has been created to process this Pull Request

@ghost
Copy link

ghost commented Sep 10, 2019

Hi @pmclain, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants