Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Customer group_id deprecation #933

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Customer group_id deprecation #933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01e5ab5
Added a deprecated anotation to the graphql schema and changed the mo…
akamuraasai Sep 14, 2019
dbbcdb1
magento/graphql-ce#910: [Customer] Deprecate group_id in Customer
lenaorobei Sep 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/code/Magento/CustomerGraphQl/Model/Customer/ExtractCustomerData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ public function execute(CustomerInterface $customer): array
}
}
$customerData = array_merge($customerData, $customAttributes);

//Field is deprecated and should not be exposed on storefront.
$customerData['group_id'] = null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, nice to know the correct file to change in cases like this.
Thank you, @lenaorobei.

$customerData['model'] = $customer;
return $customerData;
}
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/CustomerGraphQl/etc/schema.graphqls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ type RevokeCustomerTokenOutput {

type Customer @doc(description: "Customer defines the customer name and address and other details") {
created_at: String @doc(description: "Timestamp indicating when the account was created")
group_id: Int @doc(description: "The group assigned to the user. Default values are 0 (Not logged in), 1 (General), 2 (Wholesale), and 3 (Retailer)")
group_id: Int @deprecated(reason: "Customer group should not be exposed in the storefront scenarios")
prefix: String @doc(description: "An honorific, such as Dr., Mr., or Mrs.")
firstname: String @doc(description: "The customer's first name")
middlename: String @doc(description: "The customer's middle name")
Expand Down