MSI: issue #290

- Integration test fixes - part;

app/code/Magento/Inventory/Test/Integration/Indexer/GetSourceItemId.php

@@ -31,7 +31,7 @@ public function __construct(ResourceConnection $resourceConnection)
  * @param string $sourceCode
  * @return int
  */
- public function execute(string $sku, string $sourceCode): string
+ public function execute(string $sku, string $sourceCode): int
  {
  $connection = $this->resourceConnection->getConnection();
  $select = $connection->select()

app/code/Magento/Inventory/Test/Integration/Indexer/SourceIndexerTest.php

@@ -56,7 +56,7 @@ protected function tearDown()
  */
  public function testReindexRow()
  {
- $this->indexer->reindexRow(10);
+ $this->indexer->reindexRow('eu-1');
 
  self::assertEquals(8.5, $this->getProductQuantityInStock->execute('SKU-1', 10));
  self::assertEquals(8.5, $this->getProductQuantityInStock->execute('SKU-1', 30));
@@ -71,7 +71,7 @@ public function testReindexRow()
  */
  public function testReindexList()
  {
- $this->indexer->reindexList([10, 50]);
+ $this->indexer->reindexList(['eu-1', 'us-1']);
 
  self::assertEquals(8.5, $this->getProductQuantityInStock->execute('SKU-1', 10));
  self::assertEquals(8.5, $this->getProductQuantityInStock->execute('SKU-1', 30));

app/code/Magento/Inventory/Test/Integration/Indexer/SourceItemIndexerTest.php

@@ -63,7 +63,7 @@ protected function tearDown()
  */
  public function testReindexRow()
  {
- $this->indexer->reindexRow($this->getSourceItemId->execute('SKU-1', 10));
+ $this->indexer->reindexRow($this->getSourceItemId->execute('SKU-1', 'eu-1'));
 
  self::assertEquals(8.5, $this->getProductQuantityInStock->execute('SKU-1', 10));
  self::assertEquals(8.5, $this->getProductQuantityInStock->execute('SKU-1', 30));
@@ -79,8 +79,8 @@ public function testReindexRow()
  public function testReindexList()
  {
  $this->indexer->reindexList([
- $this->getSourceItemId->execute('SKU-1', 10),
- $this->getSourceItemId->execute('SKU-2', 50),
+ $this->getSourceItemId->execute('SKU-1', 'eu-1'),
+ $this->getSourceItemId->execute('SKU-2', 'us-1'),
  ]);
 
  self::assertEquals(8.5, $this->getProductQuantityInStock->execute('SKU-1', 10));

app/code/Magento/InventoryApi/Test/_files/stock_source_link.php

@@ -11,19 +11,19 @@
 /** @var AssignSourcesToStockInterface $assignSourcesToStock */
 $assignSourcesToStock = Bootstrap::getObjectManager()->get(AssignSourcesToStockInterface::class);
 /**
- * EU-source-1(id:10) - EU-stock(id:10)
- * EU-source-2(id:20) - EU-stock(id:10)
- * EU-source-3(id:30) - EU-stock(id:10)
- * EU-source-disabled(id:40) - EU-stock(id:10)
+ * EU-source-1(code:eu-1) - EU-stock(id:10)
+ * EU-source-2(code:eu-2) - EU-stock(id:10)
+ * EU-source-3(code:eu-3) - EU-stock(id:10)
+ * EU-source-disabled(code:eu-dis) - EU-stock(id:10)
  *
- * US-source-1(id:50) - US-stock(id:20)
+ * US-source-1(code:us-1) - US-stock(id:20)
  *
- * EU-source-1(id:10) - Global-stock(id:30)
- * EU-source-2(id:20) - Global-stock(id:30)
- * EU-source-2(id:30) - Global-stock(id:30)
- * EU-source-disabled(id:40) - Global-stock(id:30)
- * US-source-1(id:50) - Global-stock(id:30)
+ * EU-source-1(code:eu-1) - Global-stock(id:30)
+ * EU-source-2(code:eu-2) - Global-stock(id:30)
+ * EU-source-2(code:eu-2) - Global-stock(id:30)
+ * EU-source-disabled(code:eu-dis) - Global-stock(id:30)
+ * US-source-1(code:us-1) - Global-stock(id:30)
  */
-$assignSourcesToStock->execute([10, 20, 30, 40], 10);
-$assignSourcesToStock->execute([50], 20);
-$assignSourcesToStock->execute([10, 20, 30, 40, 50], 30);
+$assignSourcesToStock->execute(['eu-1', 'eu-2', 'eu-3', 'eu-dis'], 10);
+$assignSourcesToStock->execute(['us-1'], 20);
+$assignSourcesToStock->execute(['eu-1', 'eu-2', 'eu-3', 'eu-dis', 'us-1'], 30);

app/code/Magento/InventoryApi/Test/_files/stock_source_link_rollback.php

@@ -11,15 +11,15 @@
 /** @var UnassignSourceFromStockInterface $unassignSourceFromStock */
 $unassignSourceFromStock = Bootstrap::getObjectManager()->get(UnassignSourceFromStockInterface::class);
 // EU stock
-$unassignSourceFromStock->execute(10, 10);
-$unassignSourceFromStock->execute(20, 10);
-$unassignSourceFromStock->execute(30, 10);
-$unassignSourceFromStock->execute(40, 10);
+$unassignSourceFromStock->execute('eu-1', 10);
+$unassignSourceFromStock->execute('eu-2', 10);
+$unassignSourceFromStock->execute('eu-3', 10);
+$unassignSourceFromStock->execute('eu-dis', 10);
 // US stock
-$unassignSourceFromStock->execute(50, 20);
+$unassignSourceFromStock->execute('us-1', 20);
 // Global Stock
-$unassignSourceFromStock->execute(10, 30);
-$unassignSourceFromStock->execute(20, 30);
-$unassignSourceFromStock->execute(30, 30);
-$unassignSourceFromStock->execute(40, 30);
-$unassignSourceFromStock->execute(50, 30);
+$unassignSourceFromStock->execute('eu-1', 30);
+$unassignSourceFromStock->execute('eu-2', 30);
+$unassignSourceFromStock->execute('eu-3', 30);
+$unassignSourceFromStock->execute('eu-dis', 30);
+$unassignSourceFromStock->execute('us-1', 30);

app/code/Magento/InventoryCatalog/Test/_files/source_items_on_default_source.php

@@ -28,19 +28,19 @@
  */
 $sourcesItemsData = [
  [
- SourceItemInterface::SOURCE_ID => $defaultSourceProvider->getId(),
+ SourceItemInterface::SOURCE_CODE => $defaultSourceProvider->getCode(),
  SourceItemInterface::SKU => 'SKU-1',
  SourceItemInterface::QUANTITY => 5.5,
  SourceItemInterface::STATUS => SourceItemInterface::STATUS_IN_STOCK,
  ],
  [
- SourceItemInterface::SOURCE_ID => $defaultSourceProvider->getId(),
+ SourceItemInterface::SOURCE_CODE => $defaultSourceProvider->getCode(),
  SourceItemInterface::SKU => 'SKU-2',
  SourceItemInterface::QUANTITY => 5,
  SourceItemInterface::STATUS => SourceItemInterface::STATUS_IN_STOCK,
  ],
  [
- SourceItemInterface::SOURCE_ID => $defaultSourceProvider->getId(),
+ SourceItemInterface::SOURCE_CODE => $defaultSourceProvider->getCode(),
  SourceItemInterface::SKU => 'SKU-3',
  SourceItemInterface::QUANTITY => 6,
  SourceItemInterface::STATUS => SourceItemInterface::STATUS_OUT_OF_STOCK,