Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Сarrier Сodes validation to service layer #131

Closed
naydav opened this issue Oct 12, 2017 · 0 comments
Closed

Move Сarrier Сodes validation to service layer #131

naydav opened this issue Oct 12, 2017 · 0 comments

Comments

@naydav
Copy link

naydav commented Oct 12, 2017

In
https://github.com/magento-engcom/msi/blob/develop/app/code/Magento/Inventory/Controller/Adminhtml/Source/SourceCarrierDataProcessor.php#L67-L70
we have some validation.

But it validation will be run only for saving via the controller. But we need to perform this check in all cases (for example save via REST call)
So need to move this logic to service layer
https://github.com/magento-engcom/msi/blob/develop/app/code/Magento/Inventory/Model/SourceCarrierLinkManagement.php

Also, need to cover this functionality with WebApi tests

During this work, we need to change logic of Integration tests
We need to register new 'carrier codes'(which used in integration tests) in Shipping system

@larsroettig larsroettig self-assigned this Oct 15, 2017
larsroettig pushed a commit that referenced this issue Oct 24, 2017
- Move Сarrier Сodes validation to service layer
- Add New intigration Test
larsroettig pushed a commit that referenced this issue Oct 25, 2017
- Add Export Command
larsroettig pushed a commit that referenced this issue Oct 27, 2017
- Refactoring for validate function
- Add expectedErrorData to api test
larsroettig pushed a commit that referenced this issue Oct 27, 2017
- Fix API Test
larsroettig pushed a commit that referenced this issue Oct 27, 2017
- Fix API Test
- Add Type Hint
naydav pushed a commit that referenced this issue Oct 27, 2017
…tion

Move Сarrier Сodes validation to service layer #131
magento-cicd2 pushed a commit that referenced this issue Jun 11, 2021
…ory-3277

[Imported] Marked Inventory interfaces and blocks as API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants