New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid code fragments duplication in default_stock_configurable_products.php and product_configurable.php fixtures #1413

Closed

nmalevanec opened this issue Jun 22, 2018 · 1 comment

Assignees

Contributor

nmalevanec commented Jun 22, 2018 •

edited

Loading

Preconditions

Magento with MSI.

Steps to reproduce

Observe https://github.com/magento-engcom/msi/blob/14f70cd6393c62b0a821cd7d77bff5673871eb01/app/code/Magento/InventoryConfigurableProduct/Test/_files/default_stock_configurable_products.php#L58-L88 and https://github.com/magento-engcom/msi/blob/14f70cd6393c62b0a821cd7d77bff5673871eb01/app/code/Magento/InventoryConfigurableProduct/Test/_files/product_configurable.php#L79-L135 code fragments.

Expected result

There should be no code fragments duplication and therefore Magento\Test\Php\LiveCodeTest::testCopyPaste should pass successfully.

Actual result

Two fragments are almost identical, so Magento\Test\Php\LiveCodeTest::testCopyPaste fails.

nmalevanec added the current sprint label

VitaliyBoyko self-assigned this

This was referenced Jun 24, 2018

1411-1421: Static fixes #1419

Closed

MSI-1411-1421: prevent copy/paste test for fixtures #1450

Merged

naydav commented Jul 4, 2018

#1450
magento/magento2#16508

naydav closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment