Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong DocBlocks #52

Closed
aleron75 opened this issue Aug 8, 2017 · 2 comments
Closed

Wrong DocBlocks #52

aleron75 opened this issue Aug 8, 2017 · 2 comments
Assignees
@vadimjustus

Comments

@aleron75
Copy link
Contributor

aleron75 commented Aug 8, 2017

Digging in the code of the Inventory module, I've found a repetition of the following DocBlock above __construct() methods:

/**
 * SourceCarrierLinkManagement constructor
 *
 * @param ResourceConnection $connection
 */

I add this issue as a reminder to fix the SourceCarrierLinkManagement reference with the correct class name in which the constructor is declared.
@naydav
Copy link

naydav commented Sep 1, 2017 •
edited
Loading

Classes with mistake are
\Magento\Inventory\Model\ResourceModel\SourceItem\SaveMultiple
\Magento\Inventory\Model\ResourceModel\StockSourceLink\SaveMultiple

@maghamed @aleron75
Need to think maybe we do need to write comments like SourceCarrierLinkManagement constructor
because these comments do not have usefull information

@vadimjustus vadimjustus self-assigned this Sep 20, 2017
@vadimjustus vadimjustus mentioned this issue Sep 20, 2017
Merged
4 tasks
@vadimjustus vadimjustus removed their assignment Sep 20, 2017
naydav pushed a commit that referenced this issue Sep 27, 2017
@vadimjustus
MSI: fixes magento-engcom/magento:#52
3e0bccf
naydav pushed a commit that referenced this issue Sep 27, 2017
Merge pull request #103 from vadimjustus/issue-52-wrong-doc-blocks
31377e5 
MSI: fixes magento-engcom/msi:#52
@naydav
Copy link

naydav commented Sep 27, 2017

Merged in #103

@naydav naydav closed this as completed Sep 27, 2017
@smoskaluk smoskaluk mentioned this issue Mar 23, 2018
Closed
mmansoor-magento pushed a commit that referenced this issue Jan 20, 2021
@vzabaznov
Merge pull request #52 from magento-performance/MCP-89
650ea9b 
MCP-89: Move product batch size variable to environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vadimjustus vadimjustus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@naydav @aleron75 @maghamed @vadimjustus