Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1411-1421: Static fixes #1419

Closed
wants to merge 5 commits into from
Closed

1411-1421: Static fixes #1419

wants to merge 5 commits into from

Conversation

VitaliyBoyko
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko commented Jun 22, 2018 •
edited
Loading

Description

Removed/Marked ignore copy paste code in fixtures.

Fixed Issues (if relevant)

  1. Avoid code duplication in source_items_rollback.php and source_items_on_default_source_rollback.php fixtures. #1411: Avoid code duplication in source_items_rollback.php and source_items_on_default_source_rollback.php fixtures.
  2. Replace obsolete "$this" with "$block" in shipment inventory template. #1409: Replace obsolete "$this" with "$block" in shipment inventory template.
  3. Avoid code fragments duplication in default_stock_configurable_products.php. #1412: Avoid code fragments duplication in default_stock_configurable_products.php.
  4. Avoid code fragments duplication in default_stock_configurable_products.php and product_configurable.php fixtures #1413: Avoid code fragments duplication in default_stock_configurable_products.php and product_configurable.php fixtures current sprint
  5. Avoid code duplication in set_product_bundle_out_of_stock.php and set_product_configurable_out_of_stock.php fixtures. #1415: Avoid code duplication in set_product_bundle_out_of_stock.php and set_product_configurable_out_of_stock.php fixtures. current sprint
  6. Avoid code fragments duplication in product_configurable.php and product_configurable_multiple.php fixtures #1416: Avoid code fragments duplication in product_configurable.php and product_configurable_multiple.php fixtures
  7. Avoid code fragments duplication in create_quote_on_default_website.php and create_quote_on_eu_website.php fixtures #1417: Avoid code fragments duplication in create_quote_on_default_website.php and create_quote_on_eu_website.php fixtures current sprint
  8. Avoid code fragments duplication in create_quote_on_default_website_rollback.php and create_quote_on_eu_website_rollback.php fixtures #1418: Avoid code fragments duplication in create_quote_on_default_website_rollback.php and create_quote_on_eu_website_rollback.php fixtures
  9. Avoid code fragments duplication in products_rollback.php and products_bundle_rollback.php fixtures #1420: Avoid code fragments duplication in products_rollback.php and products_bundle_rollback.php fixtures
  10. Avoid code fragments duplication in products_rollback.php and products_virtual_rollback.php fixtures #1421: Avoid code fragments duplication in products_rollback.php and products_virtual_rollback.php fixtures

@VitaliyBoyko VitaliyBoyko self-assigned this Jun 22, 2018
@VitaliyBoyko VitaliyBoyko mentioned this pull request Jun 24, 2018
Merged
@VitaliyBoyko VitaliyBoyko changed the title 1411: require once used instead of copy paste in source items rollbac… 1411: Static fixes Jun 24, 2018
@VitaliyBoyko VitaliyBoyko changed the title 1411: Static fixes 1411-1421: Static fixes Jun 24, 2018
@VitaliyBoyko
MSI-1409-1421: Fixed copypaste in fixtures
c9de901
@VitaliyBoyko
Merge branches '1411-Avoid-code-duplication-in-source_items_rollback-…
601c595 
…php-and-source_items_on_default_source_rollback-php-fixtures' and 'Avoid-code-fragments-duplication-in-default_stock_configurable_products.php' of https://github.com/magento-engcom/msi into 1411-Avoid-code-duplication-in-source_items_rollback-php-and-source_items_on_default_source_rollback-php-fixtures
@VitaliyBoyko
MSI-1411-1421: Fixed fixtures path
bc754bb
@VitaliyBoyko VitaliyBoyko reopened this Jun 30, 2018
@VitaliyBoyko VitaliyBoyko deleted the 1411-Avoid-code-duplication-in-source_items_rollback-php-and-source_items_on_default_source_rollback-php-fixtures branch June 30, 2018 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VitaliyBoyko VitaliyBoyko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VitaliyBoyko