Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX MSI magento-engcom/magento#70: #71

Merged
merged 1 commit into from
Sep 2, 2017

Conversation

larsroettig
Copy link
Member

@larsroettig larsroettig commented Sep 2, 2017

Description

Return type void was introduced only in PHP 7.1. In Magento 2.2 PHP 7.0 is supported as well, so all usages of return type void must be removed for compatibility.

Fixed Issues (if relevant)

  1. magento-engcom/magento2#70: Can not install develop branch

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

- remove not allowed return type void
@ishakhsuvarov ishakhsuvarov merged commit f4b1ee5 into develop Sep 2, 2017
@vrann vrann added msi and removed msi labels Sep 29, 2017
@maghamed maghamed deleted the msi-stockitem-indexer-fix branch December 11, 2018 18:12
sidolov pushed a commit that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants