From b9f57be687d7410438d018d2dd1be983b08298cf Mon Sep 17 00:00:00 2001 From: larsroettig Date: Sat, 2 Sep 2017 15:07:53 +0200 Subject: [PATCH] FIX MSI magento-engcom/magento#70: - remove not allowed return type void --- .../Magento/Inventory/Indexer/IndexHandlerInterface.php | 4 ++-- .../Magento/Inventory/Indexer/IndexStructureInterface.php | 4 ++-- .../Inventory/Indexer/IndexTableSwitcherInterface.php | 5 +---- .../Magento/Inventory/Indexer/StockItem/IndexHandler.php | 4 ++-- .../Magento/Inventory/Indexer/StockItem/IndexStructure.php | 4 ++-- .../Inventory/Indexer/StockItem/IndexTableSwitcher.php | 6 ++---- 6 files changed, 11 insertions(+), 16 deletions(-) diff --git a/app/code/Magento/Inventory/Indexer/IndexHandlerInterface.php b/app/code/Magento/Inventory/Indexer/IndexHandlerInterface.php index 2faed60feaee..b5edf2afb7af 100644 --- a/app/code/Magento/Inventory/Indexer/IndexHandlerInterface.php +++ b/app/code/Magento/Inventory/Indexer/IndexHandlerInterface.php @@ -19,7 +19,7 @@ interface IndexHandlerInterface * @param \Traversable $documents * @return void */ - public function saveIndex(IndexName $indexName, \Traversable $documents): void; + public function saveIndex(IndexName $indexName, \Traversable $documents); /** * Remove data from index @@ -28,5 +28,5 @@ public function saveIndex(IndexName $indexName, \Traversable $documents): void; * @param \Traversable $documents * @return void */ - public function deleteIndex(IndexName $indexName, \Traversable $documents): void; + public function deleteIndex(IndexName $indexName, \Traversable $documents); } diff --git a/app/code/Magento/Inventory/Indexer/IndexStructureInterface.php b/app/code/Magento/Inventory/Indexer/IndexStructureInterface.php index 2f435408717b..c385240bee25 100644 --- a/app/code/Magento/Inventory/Indexer/IndexStructureInterface.php +++ b/app/code/Magento/Inventory/Indexer/IndexStructureInterface.php @@ -21,12 +21,12 @@ interface IndexStructureInterface * @param string $connectionName * @return void */ - public function create(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION): void; + public function create(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION); /** * @param IndexName $indexName * @param string $connectionName * @return void */ - public function delete(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION): void; + public function delete(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION); } diff --git a/app/code/Magento/Inventory/Indexer/IndexTableSwitcherInterface.php b/app/code/Magento/Inventory/Indexer/IndexTableSwitcherInterface.php index 2d756ba54154..60eb92a7b13b 100644 --- a/app/code/Magento/Inventory/Indexer/IndexTableSwitcherInterface.php +++ b/app/code/Magento/Inventory/Indexer/IndexTableSwitcherInterface.php @@ -19,8 +19,5 @@ interface IndexTableSwitcherInterface * @param string $connectionName * @return void */ - public function switch( - IndexName $indexName, - string $connectionName = ResourceConnection::DEFAULT_CONNECTION - ): void; + public function switch(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION); } diff --git a/app/code/Magento/Inventory/Indexer/StockItem/IndexHandler.php b/app/code/Magento/Inventory/Indexer/StockItem/IndexHandler.php index f19b030345e3..967770c5ed0c 100644 --- a/app/code/Magento/Inventory/Indexer/StockItem/IndexHandler.php +++ b/app/code/Magento/Inventory/Indexer/StockItem/IndexHandler.php @@ -57,7 +57,7 @@ public function __construct( /** * @inheritdoc */ - public function saveIndex(IndexName $indexName, \Traversable $documents): void + public function saveIndex(IndexName $indexName, \Traversable $documents) { $tableName = $this->indexNameResolver->resolveName($indexName); @@ -73,7 +73,7 @@ public function saveIndex(IndexName $indexName, \Traversable $documents): void /** * @inheritdoc */ - public function deleteIndex(IndexName $indexName, \Traversable $documents): void + public function deleteIndex(IndexName $indexName, \Traversable $documents) { $tableName = $this->indexNameResolver->resolveName($indexName); diff --git a/app/code/Magento/Inventory/Indexer/StockItem/IndexStructure.php b/app/code/Magento/Inventory/Indexer/StockItem/IndexStructure.php index ecdba41d2554..5e0a93770d4a 100644 --- a/app/code/Magento/Inventory/Indexer/StockItem/IndexStructure.php +++ b/app/code/Magento/Inventory/Indexer/StockItem/IndexStructure.php @@ -42,7 +42,7 @@ public function __construct( /** * @inheritdoc */ - public function create(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION): void + public function create(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION) { $connection = $this->resourceConnection->getConnection($connectionName); $tableName = $this->indexNameResolver->resolveName($indexName); @@ -93,7 +93,7 @@ public function create(IndexName $indexName, string $connectionName = ResourceCo /** * @inheritdoc */ - public function delete(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION): void + public function delete(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION) { $connection = $this->resourceConnection->getConnection($connectionName); $tableName = $this->indexNameResolver->resolveName($indexName); diff --git a/app/code/Magento/Inventory/Indexer/StockItem/IndexTableSwitcher.php b/app/code/Magento/Inventory/Indexer/StockItem/IndexTableSwitcher.php index 9ad7a9300530..205f57dd226a 100644 --- a/app/code/Magento/Inventory/Indexer/StockItem/IndexTableSwitcher.php +++ b/app/code/Magento/Inventory/Indexer/StockItem/IndexTableSwitcher.php @@ -49,10 +49,8 @@ public function __construct( /** * @inheritdoc */ - public function switch( - IndexName $indexName, - string $connectionName = ResourceConnection::DEFAULT_CONNECTION - ): void { + public function switch(IndexName $indexName, string $connectionName = ResourceConnection::DEFAULT_CONNECTION) + { $connection = $this->resourceConnection->getConnection($connectionName); $tableName = $this->indexNameResolver->resolveName($indexName);