714: Fatal error: Uncaught TypeError: during the saving of configurable product #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gurable product MSI: 714: Fatal error: Uncaught TypeError: during the saving of configurable product MSI: 714: Fatal error: Uncaught TypeError: during the saving of configurable product
# Conflicts: # app/code/Magento/ConfigurableProduct/view/adminhtml/web/js/components/dynamic-rows-configurable.js # app/code/Magento/ConfigurableProduct/view/adminhtml/web/js/variations/steps/summary.js
| /** | ||
| * Make options sections. | ||
| */ | ||
| this.makeOptionSections = function () { |
There was a problem hiding this comment.
As I see, this function we use only one time. Please rewrite her without using self variable. You can bind context and return the new object.
this.makeOptionSelections = function(){...}.bind(this);
return {
images: this.makeImages(null),
price: this.price,
quantityPerSource = this.quantityPerSource
}
And use her without new, as a simple function instead of a constructor.
| /** @inheritdoc */ | ||
| initObservable: function () { | ||
| this._super(); | ||
| this.quantityFieldName = 'quantityPerSource'; |
There was a problem hiding this comment.
Please move configuration to defaults block. Also, you use initObserveble method don't by purpose. In initObserveble you should declare observable variables and arrays, in other cases, you should use initialize or initConfig methods.
| getProductData: function (row) { | ||
| var product = this._super(row); | ||
|
|
||
| product['quantity_per_source'] = row.quantityPerSource; |
There was a problem hiding this comment.
Move name of quantity field to defaults block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues (if relevant)