Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout catalog_category_view - fallback mechanism Fixed #835

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

kanhaiya5590
Copy link

@kanhaiya5590 kanhaiya5590 commented Nov 29, 2022

Description (*)

Task

A layout file was added in page_layout so the fallback mechanism not working as expected.

usually, this not identify in normal cases but if we will working on layout updates then this causes concern so fixed and moved the layout file to a valid location.

Fixed Issues (if relevant)

  1. layout 2 columns left avoid to override layout on catalog_category_view #829: layout 2 columns left avoid to override layout on catalog_category_view
  2. Layout shouldn't be set in a page_layout xml file. #537: Layout shouldn't be set in a page_layout xml file.

Need to move this file to the layout folder instead of page_layout
Moving this file from page_layout to layout folder so fallback mechanism work as expected.
Create catalog_category_view.xml
@kanhaiya5590 kanhaiya5590 changed the title Layout - fallback mechanism Fixed Layout catalog_category_view - fallback mechanism Fixed Nov 29, 2022
@kanhaiya5590
Copy link
Author

CC : @sidolov

@kanhaiya5590
Copy link
Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

1 participant