Initial Module #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjwiebell
commented
Jan 28, 2019
| <preference for="Magento\Framework\App\FrontControllerInterface" type="Magento\UpwardConnector\Controller\Upward" /> | ||
| <type name="Magento\Upward\Controller"> | ||
| <arguments> | ||
| <argument name="upwardConfig" xsi:type="string">pwa/upward-config.yml</argument> |
There was a problem hiding this comment.
Improvement option: I didn't see an easy way to source an argument from ENV, but we can write a simple class that does this, so this value isn't hard-coded.
bbatsche
approved these changes
Jan 28, 2019
mmansoor-magento
pushed a commit
that referenced
this pull request
Nov 10, 2020
* Add module dependency * Add known tab issue to readme * Update README.md Co-authored-by: James Calcaben <jcalcaben@users.noreply.github.com> Co-authored-by: James Calcaben <jcalcaben@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.