From 4bcb14e8bdbaaefa59d61c6ffb4d9035961f6d13 Mon Sep 17 00:00:00 2001
From: Pavel Bystritsky <engcom-vendorworker-foxtrot@adobe.com>
Date: Thu, 23 Apr 2020 16:32:14 +0300
Subject: [PATCH 1/8] magento2-login-as-customer/issues/90: Static tests fix.

---
 .../LoginAsCustomer/Block/Adminhtml/Login.php |  2 ++
 .../Plugin/Button/ToolbarPlugin.php           | 23 +++++++++++--------
 .../Magento/LoginAsCustomer/composer.json     | 14 +++++++++--
 .../LoginAsCustomer/etc/frontend/di.xml       |  2 +-
 .../layout/loginascustomer_login_grid.xml     |  2 +-
 .../loginascustomer_login_grid_block.xml      | 12 +++++-----
 .../frontend/web/js/view/loginAsCustomer.js   |  2 +-
 7 files changed, 37 insertions(+), 20 deletions(-)

diff --git a/app/code/Magento/LoginAsCustomer/Block/Adminhtml/Login.php b/app/code/Magento/LoginAsCustomer/Block/Adminhtml/Login.php
index b7aa3487672b2..fd454f96abf95 100755
--- a/app/code/Magento/LoginAsCustomer/Block/Adminhtml/Login.php
+++ b/app/code/Magento/LoginAsCustomer/Block/Adminhtml/Login.php
@@ -9,6 +9,8 @@
 
 /**
  * Login as customer log
+ *
+ * @api
  */
 class Login extends \Magento\Backend\Block\Widget\Grid\Container
 {
diff --git a/app/code/Magento/LoginAsCustomer/Plugin/Button/ToolbarPlugin.php b/app/code/Magento/LoginAsCustomer/Plugin/Button/ToolbarPlugin.php
index 20b0332ae76d2..64a0ad8a872a0 100644
--- a/app/code/Magento/LoginAsCustomer/Plugin/Button/ToolbarPlugin.php
+++ b/app/code/Magento/LoginAsCustomer/Plugin/Button/ToolbarPlugin.php
@@ -7,14 +7,12 @@
 
 namespace Magento\LoginAsCustomer\Plugin\Button;
 
-use \Magento\LoginAsCustomerAdvanced\Controller\Adminhtml\Order\Login as LoginController;
-use \Magento\Backend\Block\Widget\Button\Toolbar\Interceptor;
-use \Magento\Framework\View\Element\AbstractBlock;
-use \Magento\Backend\Block\Widget\Button\ButtonList;
+use Magento\Backend\Block\Widget\Button\ButtonList;
+use Magento\Backend\Block\Widget\Button\Toolbar;
+use Magento\Framework\View\Element\AbstractBlock;
 
 /**
- * Class ToolbarPlugin
- * @package Magento\LoginAsCustomerAdvanced\Plugin\Button
+ * Plugin for \Magento\Backend\Block\Widget\Button\Toolbar.
  */
 class ToolbarPlugin
 {
@@ -42,12 +40,15 @@ public function __construct(
     }
 
     /**
-     * @param \Magento\Backend\Block\Widget\Button\Toolbar\Interceptor $subject
+     * Add Login As Customer button.
+     *
+     * @param \Magento\Backend\Block\Widget\Button\Toolbar $subject
      * @param \Magento\Framework\View\Element\AbstractBlock $context
      * @param \Magento\Backend\Block\Widget\Button\ButtonList $buttonList
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function beforePushButtons(
-        Interceptor $subject,
+        Toolbar $subject,
         AbstractBlock $context,
         ButtonList $buttonList
     ):void {
@@ -71,7 +72,11 @@ public function beforePushButtons(
                     ]);
                     $buttonList->add(
                         'guest_to_customer',
-                        ['label' => __('Login As Customer'), 'onclick' => 'window.open(\'' . $buttonUrl . '\')', 'class' => 'reset'],
+                        [
+                            'label' => __('Login As Customer'),
+                            'onclick' => 'window.open(\'' . $buttonUrl . '\')',
+                            'class' => 'reset'
+                        ],
                         -1
                     );
                 }
diff --git a/app/code/Magento/LoginAsCustomer/composer.json b/app/code/Magento/LoginAsCustomer/composer.json
index 5b0ade832bbcd..c5aa42e1a1f4b 100755
--- a/app/code/Magento/LoginAsCustomer/composer.json
+++ b/app/code/Magento/LoginAsCustomer/composer.json
@@ -4,11 +4,21 @@
     "require": {
         "magento/framework": "*",
         "magento/module-backend": "*",
-        "magento/module-sales": "*",
+        "magento/module-checkout": "*",
         "magento/module-customer": "*",
-        "magento/module-checkout": "*"
+        "magento/module-sales": "*",
+        "magento/module-store": "*",
+        "magento/module-ui": "*",
+        "magento/module-user": "*"
+    },
+    "suggest": {
+        "magento/module-page-cache": "*"
     },
     "type": "magento2-module",
+    "license": [
+        "OSL-3.0",
+        "AFL-3.0"
+    ],
     "version": "2.2.1",
     "autoload": {
         "files": [ "registration.php" ],
diff --git a/app/code/Magento/LoginAsCustomer/etc/frontend/di.xml b/app/code/Magento/LoginAsCustomer/etc/frontend/di.xml
index 5f0f784e051e3..1cf46eadddc2c 100755
--- a/app/code/Magento/LoginAsCustomer/etc/frontend/di.xml
+++ b/app/code/Magento/LoginAsCustomer/etc/frontend/di.xml
@@ -13,7 +13,7 @@
     <type name="Magento\Customer\CustomerData\SectionPoolInterface">
         <arguments>
             <argument name="sectionSourceMap" xsi:type="array">
-                <item name="logged_as_customer" xsi:type="string">Magento\LoginAsCustomer\CustomerData\LoginAsCustomer</item>
+                <item name="loggedAsCustomer" xsi:type="string">Magento\LoginAsCustomer\CustomerData\LoginAsCustomer</item>
             </argument>
         </arguments>
     </type>
diff --git a/app/code/Magento/LoginAsCustomer/view/adminhtml/layout/loginascustomer_login_grid.xml b/app/code/Magento/LoginAsCustomer/view/adminhtml/layout/loginascustomer_login_grid.xml
index 6f400c0e5c601..e298729b5422b 100755
--- a/app/code/Magento/LoginAsCustomer/view/adminhtml/layout/loginascustomer_login_grid.xml
+++ b/app/code/Magento/LoginAsCustomer/view/adminhtml/layout/loginascustomer_login_grid.xml
@@ -5,7 +5,7 @@
  * See COPYING.txt for license details.
  */
 -->
-<layout xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etclayout_generic.xsd">
+<layout xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/layout_generic.xsd">
     <update handle="formkey"/>
     <update handle="loginascustomer_login_grid_block"/>
     <container name="root">
diff --git a/app/code/Magento/LoginAsCustomer/view/adminhtml/layout/loginascustomer_login_grid_block.xml b/app/code/Magento/LoginAsCustomer/view/adminhtml/layout/loginascustomer_login_grid_block.xml
index 8f38fab2e2e7a..b75a5b0a68621 100755
--- a/app/code/Magento/LoginAsCustomer/view/adminhtml/layout/loginascustomer_login_grid_block.xml
+++ b/app/code/Magento/LoginAsCustomer/view/adminhtml/layout/loginascustomer_login_grid_block.xml
@@ -18,7 +18,7 @@
                 </arguments>
 
                 <block class="Magento\Backend\Block\Widget\Grid\ColumnSet" name="loginascustomer.grid.columnSet" as="grid.columnSet">
-                    <block class="Magento\Backend\Block\Widget\Grid\Column" as="login_id">
+                    <block class="Magento\Backend\Block\Widget\Grid\Column" name="loginascustomer.grid.columnSet.loginId" as="login_id">
                         <arguments>
                             <argument name="header" xsi:type="string" translate="true">ID</argument>
                             <argument name="index" xsi:type="string">login_id</argument>
@@ -26,7 +26,7 @@
                             <argument name="column_css_class" xsi:type="string">col-id</argument>
                         </arguments>
                     </block>
-                    <block class="Magento\Backend\Block\Widget\Grid\Column" as="customer_id">
+                    <block class="Magento\Backend\Block\Widget\Grid\Column" name="loginascustomer.grid.columnSet.customerId" as="customer_id">
                         <arguments>
                             <argument name="header" xsi:type="string" translate="true">Customer ID</argument>
                             <argument name="index" xsi:type="string">customer_id</argument>
@@ -34,7 +34,7 @@
                             <argument name="column_css_class" xsi:type="string">col-title</argument>
                         </arguments>
                     </block>
-                    <block class="Magento\Backend\Block\Widget\Grid\Column" as="email">
+                    <block class="Magento\Backend\Block\Widget\Grid\Column" name="loginascustomer.grid.columnSet.email" as="email">
                         <arguments>
                             <argument name="header" xsi:type="string" translate="true">Customer Email</argument>
                             <argument name="index" xsi:type="string">email</argument>
@@ -42,7 +42,7 @@
                             <argument name="column_css_class" xsi:type="string">col-title</argument>
                         </arguments>
                     </block>
-                    <block class="Magento\Backend\Block\Widget\Grid\Column" as="admin_id">
+                    <block class="Magento\Backend\Block\Widget\Grid\Column" name="loginascustomer.grid.columnSet.adminId" as="admin_id">
                         <arguments>
                             <argument name="header" xsi:type="string" translate="true">Admin ID</argument>
                             <argument name="index" xsi:type="string">admin_id</argument>
@@ -50,7 +50,7 @@
                             <argument name="column_css_class" xsi:type="string">col-title</argument>
                         </arguments>
                     </block>
-                    <block class="Magento\Backend\Block\Widget\Grid\Column" as="username">
+                    <block class="Magento\Backend\Block\Widget\Grid\Column" name="loginascustomer.grid.columnSet.username" as="username">
                         <arguments>
                             <argument name="header" xsi:type="string" translate="true">Admin Name</argument>
                             <argument name="index" xsi:type="string">username</argument>
@@ -58,7 +58,7 @@
                             <argument name="column_css_class" xsi:type="string">col-title</argument>
                         </arguments>
                     </block>
-                    <block class="Magento\Backend\Block\Widget\Grid\Column" as="created_at">
+                    <block class="Magento\Backend\Block\Widget\Grid\Column" name="loginascustomer.grid.columnSet.createdAt" as="created_at">
                         <arguments>
                             <argument name="header" xsi:type="string" translate="true">Logged In</argument>
                             <argument name="index" xsi:type="string">created_at</argument>
diff --git a/app/code/Magento/LoginAsCustomer/view/frontend/web/js/view/loginAsCustomer.js b/app/code/Magento/LoginAsCustomer/view/frontend/web/js/view/loginAsCustomer.js
index 215148a7e7dec..11ff23350483f 100644
--- a/app/code/Magento/LoginAsCustomer/view/frontend/web/js/view/loginAsCustomer.js
+++ b/app/code/Magento/LoginAsCustomer/view/frontend/web/js/view/loginAsCustomer.js
@@ -22,7 +22,7 @@ define([
             this._super();
 
             this.customer = customerData.get('customer');
-            this.loginAsCustomer = customerData.get('logged_as_customer');
+            this.loginAsCustomer = customerData.get('loggedAsCustomer');
             this.isVisible(this.loginAsCustomer().admin_user_id);
 
             this.notificationText = $.mage.__('You are connected as <strong>%1</strong> on %2')

From 2004134135e609e28df120dfd27630c8f076a406 Mon Sep 17 00:00:00 2001
From: Pavel Bystritsky <engcom-vendorworker-foxtrot@adobe.com>
Date: Thu, 23 Apr 2020 16:40:54 +0300
Subject: [PATCH 2/8] magento2-login-as-customer/issues/90: Integration tests
 fix.

---
 .../adminhtml/ui_component/customer_form.xml  | 13 ++---
 .../ui_component/manual_store_form.xml        | 49 ++++++++++---------
 2 files changed, 34 insertions(+), 28 deletions(-)

diff --git a/app/code/Magento/LoginAsCustomer/view/adminhtml/ui_component/customer_form.xml b/app/code/Magento/LoginAsCustomer/view/adminhtml/ui_component/customer_form.xml
index 82988c801ef7d..43c746f186da0 100755
--- a/app/code/Magento/LoginAsCustomer/view/adminhtml/ui_component/customer_form.xml
+++ b/app/code/Magento/LoginAsCustomer/view/adminhtml/ui_component/customer_form.xml
@@ -5,10 +5,11 @@
  * See COPYING.txt for license details.
  */
 -->
-<form xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Ui:etc/ui_configuration.xsd">
-    <argument name="data" xsi:type="array">
-        <item name="buttons" xsi:type="array">
-            <item name="login_as_customer" xsi:type="string">Magento\LoginAsCustomer\Block\Adminhtml\Customer\Edit\Login</item>
-        </item>
-    </argument>
+<form xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+      xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Ui:etc/ui_configuration.xsd">
+    <settings>
+        <buttons>
+            <button name="login_as_customer" class="Magento\LoginAsCustomer\Block\Adminhtml\Customer\Edit\Login"/>
+        </buttons>
+    </settings>
 </form>
diff --git a/app/code/Magento/LoginAsCustomer/view/adminhtml/ui_component/manual_store_form.xml b/app/code/Magento/LoginAsCustomer/view/adminhtml/ui_component/manual_store_form.xml
index b324143a7294a..71221f3acb8ed 100644
--- a/app/code/Magento/LoginAsCustomer/view/adminhtml/ui_component/manual_store_form.xml
+++ b/app/code/Magento/LoginAsCustomer/view/adminhtml/ui_component/manual_store_form.xml
@@ -35,40 +35,45 @@
         </dataProvider>
     </dataSource>
 
-    <fieldset name="websites" class="Magento\Store\Ui\Component\Form\Fieldset\Websites">
-        <argument name="data" xsi:type="array">
-            <item name="config" xsi:type="array">
-                <item name="collapsible" xsi:type="boolean">false</item>
-                <item name="label" xsi:type="string" translate="true">Stores</item>
-                <item name="sortOrder" xsi:type="number">50</item>
-            </item>
-        </argument>
-        <field name="entity_id">
+    <fieldset name="websites" class="Magento\Store\Ui\Component\Form\Fieldset\Websites" sortOrder="50">
+        <settings>
+            <label translate="true">Stores</label>
+            <collapsible>false</collapsible>
+        </settings>
+        <field name="entity_id" formElement="input">
             <argument name="data" xsi:type="array">
                 <item name="config" xsi:type="array">
-                    <item name="visible" xsi:type="boolean">false</item>
-                    <item name="dataType" xsi:type="string">text</item>
-                    <item name="formElement" xsi:type="string">input</item>
                     <item name="source" xsi:type="string">page</item>
-                    <item name="dataScope" xsi:type="string">entity_id</item>
                 </item>
             </argument>
+            <settings>
+                <visible>false</visible>
+                <dataType>text</dataType>
+                <dataScope>entity_id</dataScope>
+            </settings>
         </field>
-        <field name="storeviews">
+        <field name="storeviews" formElement="select">
             <argument name="data" xsi:type="array">
-                <item name="options" xsi:type="object">Magento\Cms\Ui\Component\Listing\Column\Cms\Options</item>
                 <item name="config" xsi:type="array">
-                    <item name="dataType" xsi:type="string">int</item>
-                    <item name="label" xsi:type="string" translate="true">Store View</item>
-                    <item name="formElement" xsi:type="string">select</item>
                     <item name="source" xsi:type="string">page</item>
-                    <item name="dataScope" xsi:type="string">store_id</item>
                     <item name="default" xsi:type="string">0</item>
-                    <item name="validation" xsi:type="array">
-                        <item name="required-entry" xsi:type="boolean">true</item>
-                    </item>
                 </item>
             </argument>
+            <settings>
+                <label translate="true">Store View</label>
+                <dataType>int</dataType>
+                <dataScope>store_id</dataScope>
+                <validation>
+                    <rule name="required-entry" xsi:type="boolean">true</rule>
+                </validation>
+            </settings>
+            <formElements>
+                <select>
+                    <settings>
+                        <options class="Magento\Cms\Ui\Component\Listing\Column\Cms\Options"/>
+                    </settings>
+                </select>
+            </formElements>
         </field>
      </fieldset>
 </form>

From d69c0f9aa77bb45f536dd0f7e73717d72c5c1235 Mon Sep 17 00:00:00 2001
From: Pavel Bystritsky <engcom-vendorworker-foxtrot@adobe.com>
Date: Thu, 23 Apr 2020 19:01:26 +0300
Subject: [PATCH 3/8] magento2-login-as-customer/issues/90: Static tests fix.

---
 .../LoginAsCustomer/CustomerData/LoginAsCustomer.php       | 7 +++++--
 app/code/Magento/LoginAsCustomer/composer.json             | 2 +-
 .../view/frontend/web/js/view/loginAsCustomer.js           | 4 ++--
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/app/code/Magento/LoginAsCustomer/CustomerData/LoginAsCustomer.php b/app/code/Magento/LoginAsCustomer/CustomerData/LoginAsCustomer.php
index 56af5c948bf69..f7153dc6c2b75 100644
--- a/app/code/Magento/LoginAsCustomer/CustomerData/LoginAsCustomer.php
+++ b/app/code/Magento/LoginAsCustomer/CustomerData/LoginAsCustomer.php
@@ -13,6 +13,8 @@
 
 /**
  * Customer data for the logged_as_customer section
+ *
+ * @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
  */
 class LoginAsCustomer implements SectionSourceInterface
 {
@@ -41,6 +43,7 @@ public function __construct(
 
     /**
      * Retrieve private customer data for the logged_as_customer section
+     *
      * @return array
      */
     public function getSectionData():array
@@ -50,8 +53,8 @@ public function getSectionData():array
         }
 
         return [
-            'admin_user_id' => $this->customerSession->getLoggedAsCustomerAdmindId(),
-            'website_name' => $this->storeManager->getWebsite()->getName()
+            'adminUserId' => $this->customerSession->getLoggedAsCustomerAdmindId(),
+            'websiteName' => $this->storeManager->getWebsite()->getName()
         ];
     }
 }
diff --git a/app/code/Magento/LoginAsCustomer/composer.json b/app/code/Magento/LoginAsCustomer/composer.json
index c5aa42e1a1f4b..71813cebf4581 100755
--- a/app/code/Magento/LoginAsCustomer/composer.json
+++ b/app/code/Magento/LoginAsCustomer/composer.json
@@ -2,6 +2,7 @@
     "name": "magento/module-login-as-customer",
     "description": "Allow for admin to enter a customer account",
     "require": {
+        "php": "~7.1.3||~7.2.0||~7.3.0",
         "magento/framework": "*",
         "magento/module-backend": "*",
         "magento/module-checkout": "*",
@@ -19,7 +20,6 @@
         "OSL-3.0",
         "AFL-3.0"
     ],
-    "version": "2.2.1",
     "autoload": {
         "files": [ "registration.php" ],
         "psr-4": {
diff --git a/app/code/Magento/LoginAsCustomer/view/frontend/web/js/view/loginAsCustomer.js b/app/code/Magento/LoginAsCustomer/view/frontend/web/js/view/loginAsCustomer.js
index 11ff23350483f..7f6cad6ce3f2d 100644
--- a/app/code/Magento/LoginAsCustomer/view/frontend/web/js/view/loginAsCustomer.js
+++ b/app/code/Magento/LoginAsCustomer/view/frontend/web/js/view/loginAsCustomer.js
@@ -23,11 +23,11 @@ define([
 
             this.customer = customerData.get('customer');
             this.loginAsCustomer = customerData.get('loggedAsCustomer');
-            this.isVisible(this.loginAsCustomer().admin_user_id);
+            this.isVisible(this.loginAsCustomer().adminUserId);
 
             this.notificationText = $.mage.__('You are connected as <strong>%1</strong> on %2')
                 .replace('%1', this.customer().fullname)
-                .replace('%2', this.loginAsCustomer().website_name);
+                .replace('%2', this.loginAsCustomer().websiteName);
         },
 
         /** @inheritdoc */

From 15c9e221ac5c036dabb0734d50384b13e9e6b86c Mon Sep 17 00:00:00 2001
From: Valerii Naida <vnayda@adobe.com>
Date: Thu, 23 Apr 2020 18:18:00 -0500
Subject: [PATCH 4/8] magento2-login-as-customer/issues/90: Tests stabilizatio

UI part refactoring
---
 .../Controller/Adminhtml/Login/Index.php      |  15 +-
 .../Controller/Adminhtml/Login/Login.php      |   4 +-
 .../Controller/Adminhtml/Login/Manual.php     |   2 +
 .../Controller/Login/Index.php                |  83 +++++++---
 .../Controller/Login/Proceed.php              |  19 ++-
 .../Magento/LoginAsCustomer/Model/Config.php  |   8 +-
 .../Model/PageCache/ConfigPlugin.php          |   2 +-
 .../WbsiterestrictionFrontendObserver.php     |  30 ----
 .../Control/LoginAsCustomerButton.php}        |  17 +-
 .../Control/LoginAsCustomerButton.php}        |   8 +-
 .../DataProvider}/Form/StoreDataProvider.php  |   6 +-
 .../LoginAsCustomer/etc/adminhtml/system.xml  |   2 +-
 .../Magento/LoginAsCustomer/etc/config.xml    |   4 +-
 .../LoginAsCustomer/etc/frontend/events.xml   |  12 --
 .../adminhtml/ui_component/customer_form.xml  |   3 +-
 .../ui_component/manual_store_form.xml        |   5 +-
 ...ngProductImportWithConfigTurnedOffTest.xml | 155 ------------------
 17 files changed, 118 insertions(+), 257 deletions(-)
 delete mode 100644 app/code/Magento/LoginAsCustomer/Observer/WbsiterestrictionFrontendObserver.php
 rename app/code/Magento/LoginAsCustomer/{Block/Adminhtml/Customer/Edit/Login.php => Ui/Customer/Component/Control/LoginAsCustomerButton.php} (69%)
 mode change 100755 => 100644
 rename app/code/Magento/LoginAsCustomer/{Block/Adminhtml/Store/SaveButton.php => Ui/Store/Component/Control/LoginAsCustomerButton.php} (76%)
 mode change 100755 => 100644
 rename app/code/Magento/LoginAsCustomer/Ui/{DataProvider/Store => Store/DataProvider}/Form/StoreDataProvider.php (90%)
 delete mode 100644 app/code/Magento/LoginAsCustomer/etc/frontend/events.xml
 delete mode 100644 app/code/Magento/UrlRewrite/Test/Mftf/Test/AdminCheckUrlRewritesCorrectlyGeneratedForMultipleStoreviewsDuringProductImportTest/AdminUrlRewriteGeneratedForMultipleStoreviewsDuringProductImportWithConfigTurnedOffTest.xml

diff --git a/app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Index.php b/app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Index.php
index 008e5fa3cfd87..55d89dedf09f1 100755
--- a/app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Index.php
+++ b/app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Index.php
@@ -7,11 +7,14 @@
 
 namespace Magento\LoginAsCustomer\Controller\Adminhtml\Login;
 
+use Magento\Backend\App\Action\Context;
+use Magento\Backend\Model\View\Result\Page;
 use Magento\Framework\Controller\ResultFactory;
 use Magento\Framework\Controller\ResultInterface;
 use Magento\Framework\App\Action\HttpGetActionInterface;
 use Magento\Framework\App\Action\HttpPostActionInterface;
 use Magento\Backend\App\Action;
+use Magento\LoginAsCustomer\Model\Login;
 
 /**
  * Login As Customer log grid action
@@ -27,18 +30,17 @@ class Index extends Action implements HttpGetActionInterface, HttpPostActionInte
     const ADMIN_RESOURCE = 'Magento_LoginAsCustomer::login_log';
 
     /**
-     * @var \Magento\LoginAsCustomer\Model\Login
+     * @var Login
      */
     private $loginModel;
 
     /**
-     * Index constructor.
-     * @param \Magento\Backend\App\Action\Context $context
-     * @param \Magento\LoginAsCustomer\Model\Login $loginModel
+     * @param Context $context
+     * @param Login $loginModel
      */
     public function __construct(
-        \Magento\Backend\App\Action\Context $context,
-        \Magento\LoginAsCustomer\Model\Login $loginModel
+        Context $context,
+        Login $loginModel
     ) {
         parent::__construct($context);
         $this->loginModel = $loginModel;
@@ -59,6 +61,7 @@ public function execute():ResultInterface
 
         $this->loginModel->deleteNotUsed();
 
+        /** @var Page $resultPage */
         $resultPage = $this->resultFactory->create(ResultFactory::TYPE_PAGE);
         $resultPage->setActiveMenu('Magento_LoginAsCustomer::login_log')
             ->addBreadcrumb(__('Customer'), __('Login As Customer Log'));
diff --git a/app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Login.php b/app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Login.php
index 9f653c17907d6..72f6f39b344bd 100755
--- a/app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Login.php
+++ b/app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Login.php
@@ -82,7 +82,7 @@ public function __construct(
      *
      * @return ResultInterface
      */
-    public function execute():ResultInterface
+    public function execute(): ResultInterface
     {
         $request = $this->getRequest();
         $customerId = (int) $request->getParam('customer_id');
@@ -94,7 +94,7 @@ public function execute():ResultInterface
         $resultRedirect = $this->resultRedirectFactory->create();
 
         if (!$this->config->isEnabled()) {
-            $this->messageManager->addErrorMessage(__('Login As Customer is disabled, to enable the extension please navigate to Stores > Configuration > Customers > Login As Customer.'));
+            $this->messageManager->addErrorMessage(__('Login As Customer is disabled.'));
             return $resultRedirect->setPath('customer/index/index');
         }
 
diff --git a/app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Manual.php b/app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Manual.php
index 82ca675411f39..93ef202071495 100755
--- a/app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Manual.php
+++ b/app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Manual.php
@@ -7,6 +7,7 @@
 
 namespace Magento\LoginAsCustomer\Controller\Adminhtml\Login;
 
+use Magento\Backend\Model\View\Result\Page;
 use Magento\Framework\Controller\ResultFactory;
 use Magento\Framework\Controller\ResultInterface;
 use Magento\Framework\App\Action\HttpGetActionInterface;
@@ -31,6 +32,7 @@ class Manual extends Action implements HttpGetActionInterface
      */
     public function execute():ResultInterface
     {
+        /** @var Page $resultPage */
         $resultPage = $this->resultFactory->create(ResultFactory::TYPE_PAGE);
         $resultPage->setActiveMenu('Magento_LoginAsCustomer::login_button')
             ->addBreadcrumb(__('Customer'), __('Login As Customer Log'), __('Store View To Login In'));
diff --git a/app/code/Magento/LoginAsCustomer/Controller/Login/Index.php b/app/code/Magento/LoginAsCustomer/Controller/Login/Index.php
index 2bfa06b47f4c6..dc3affa70e3a2 100755
--- a/app/code/Magento/LoginAsCustomer/Controller/Login/Index.php
+++ b/app/code/Magento/LoginAsCustomer/Controller/Login/Index.php
@@ -7,74 +7,109 @@
 
 namespace Magento\LoginAsCustomer\Controller\Login;
 
+use Magento\Framework\App\RequestInterface;
+use Magento\Framework\Controller\Result\Redirect;
 use Magento\Framework\Controller\ResultFactory;
 use Magento\Framework\Controller\ResultInterface;
 use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\App\Action\HttpGetActionInterface;
-use Magento\Framework\App\Action\Action;
+use Magento\Framework\Message\ManagerInterface;
+use Magento\LoginAsCustomer\Model\Login;
+use Psr\Log\LoggerInterface;
 
 /**
  * Login As Customer storefront login action
  */
-class Index extends Action implements HttpGetActionInterface
+class Index implements HttpGetActionInterface
 {
     /**
-     * @var \Magento\LoginAsCustomer\Model\Login
+     * @var ResultFactory
+     */
+    private $resultFactory;
+
+    /**
+     * @var RequestInterface
+     */
+    private $request;
+
+    /**
+     * @var Login
      */
     private $loginModel;
 
+    /**
+     * @var ManagerInterface
+     */
+    private $messageManager;
+
+    /**
+     * @var LoggerInterface
+     */
+    private $logger;
 
     /**
-     * Index constructor.
-     * @param \Magento\Framework\App\Action\Context $context
-     * @param \Magento\LoginAsCustomer\Model\Login $loginModel
+     * @param ResultFactory $resultFactory
+     * @param RequestInterface $request
+     * @param Login $loginModel
+     * @param ManagerInterface $messageManager
+     * @param LoggerInterface $logger
      */
     public function __construct(
-        \Magento\Framework\App\Action\Context $context,
-        \Magento\LoginAsCustomer\Model\Login $loginModel
+        ResultFactory $resultFactory,
+        RequestInterface $request,
+        Login $loginModel,
+        ManagerInterface $messageManager,
+        LoggerInterface $logger
     ) {
-        parent::__construct($context);
+        $this->resultFactory = $resultFactory;
+        $this->request = $request;
         $this->loginModel = $loginModel;
+        $this->messageManager = $messageManager;
+        $this->logger = $logger;
     }
+
     /**
      * Login As Customer storefront login
      *
      * @return ResultInterface
      */
-    public function execute():ResultInterface
+    public function execute(): ResultInterface
     {
+        /** @var Redirect $resultRedirect */
         $resultRedirect = $this->resultFactory->create(ResultFactory::TYPE_REDIRECT);
-        try {
-            $login = $this->_initLogin();
 
-            /* Log in */
+        try {
+            $login = $this->initLogin();
             $login->authenticateCustomer();
+
             $this->messageManager->addSuccessMessage(
                 __('You are logged in as customer: %1', $login->getCustomer()->getName())
             );
+            $resultRedirect->setPath('*/*/proceed');
+
         } catch (LocalizedException $e) {
             $this->messageManager->addErrorMessage($e->getMessage());
-
             $resultRedirect->setPath('/');
-            return $resultRedirect;
-
         } catch (\Exception $e) {
-            $this->messageManager->addErrorMessage($e->getMessage());
-        }
+            $this->logger->error($e->getMessage());
 
-        $resultRedirect->setPath('*/*/proceed');
+            $this->messageManager->addErrorMessage(__('Cannot login to account.'));
+            $resultRedirect->setPath('/');
+        }
         return $resultRedirect;
     }
 
     /**
      * Init login info
-     * @return \Magento\LoginAsCustomer\Model\Login
+     *
+     * @return Login
+     * @throws LocalizedException
      */
-    private function _initLogin(): \Magento\LoginAsCustomer\Model\Login
+    private function initLogin(): Login
     {
-        $secret = $this->getRequest()->getParam('secret');
+        $secret = $this->request->getParam('secret');
         if (!$secret) {
-            throw LocalizedException(__('Cannot login to account. No secret key provided.'));
+            throw new LocalizedException(__('Cannot login to account. No secret key provided.'));
         }
 
         $login = $this->loginModel->loadNotUsed($secret);
@@ -82,7 +117,7 @@ private function _initLogin(): \Magento\LoginAsCustomer\Model\Login
         if ($login->getId()) {
             return $login;
         } else {
-            throw LocalizedException(__('Cannot login to account. Secret key is not valid'));
+            throw new LocalizedException(__('Cannot login to account. Secret key is not valid'));
         }
     }
 }
diff --git a/app/code/Magento/LoginAsCustomer/Controller/Login/Proceed.php b/app/code/Magento/LoginAsCustomer/Controller/Login/Proceed.php
index ad5a5b13fc3d9..17e74900997fe 100755
--- a/app/code/Magento/LoginAsCustomer/Controller/Login/Proceed.php
+++ b/app/code/Magento/LoginAsCustomer/Controller/Login/Proceed.php
@@ -4,25 +4,38 @@
  * See COPYING.txt for license details.
  */
 declare(strict_types=1);
+
 namespace Magento\LoginAsCustomer\Controller\Login;
 
 use Magento\Framework\Controller\ResultFactory;
 use Magento\Framework\Controller\ResultInterface;
 use Magento\Framework\App\Action\HttpGetActionInterface;
-use Magento\Framework\App\Action\Action;
 
 /**
  * Login as customer proxy page
  * Allows running JavaScript to load customer data to the browser local storage
  */
-class Proceed extends Action implements HttpGetActionInterface
+class Proceed implements HttpGetActionInterface
 {
+    /**
+     * @var ResultFactory
+     */
+    private $resultFactory;
+
+    /**
+     * @param ResultFactory $resultFactory
+     */
+    public function __construct(ResultFactory $resultFactory)
+    {
+        $this->resultFactory = $resultFactory;
+    }
+
     /**
      * Proxy page
      *
      * @return ResultInterface
      */
-    public function execute():ResultInterface
+    public function execute(): ResultInterface
     {
         return $this->resultFactory->create(ResultFactory::TYPE_PAGE);
     }
diff --git a/app/code/Magento/LoginAsCustomer/Model/Config.php b/app/code/Magento/LoginAsCustomer/Model/Config.php
index e1b7bcfbcaa5a..851839e6d1e1b 100644
--- a/app/code/Magento/LoginAsCustomer/Model/Config.php
+++ b/app/code/Magento/LoginAsCustomer/Model/Config.php
@@ -19,15 +19,15 @@ class Config
     /**
      * Extension config path
      */
-    private const XML_PATH_EXTENSION_ENABLED     = 'mfloginascustomer/general/enabled';
-    private const XML_PATH_KEY                   = 'mfloginascustomer/general/key';
-    private const STORE_VIEW_TO_LOGIN_IN         = 'mfloginascustomer/general/store_view_login';
+    private const XML_PATH_EXTENSION_ENABLED = 'loginascustomer/general/enabled';
+    private const STORE_VIEW_TO_LOGIN_IN = 'loginascustomer/general/store_view_login';
 
     /**
      * @var ScopeConfigInterface
      */
 
     private $scopeConfig;
+
     /**
      * @var \Magento\Framework\App\ProductMetadataInterface
      */
@@ -64,7 +64,7 @@ public function getConfig($path, $storeId = null)
     /**
      * @return bool
      */
-    public function isEnabled():bool
+    public function isEnabled(): bool
     {
         return (bool)$this->getConfig(
             self::XML_PATH_EXTENSION_ENABLED
diff --git a/app/code/Magento/LoginAsCustomer/Model/PageCache/ConfigPlugin.php b/app/code/Magento/LoginAsCustomer/Model/PageCache/ConfigPlugin.php
index 913357eff6409..f0d45cc306f38 100644
--- a/app/code/Magento/LoginAsCustomer/Model/PageCache/ConfigPlugin.php
+++ b/app/code/Magento/LoginAsCustomer/Model/PageCache/ConfigPlugin.php
@@ -49,7 +49,7 @@ public function afterIsEnabled(\Magento\PageCache\Model\Config $subject, $result
     {
         if ($result) {
             $disable = $this->_scopeConfig->getValue(
-                'mfloginascustomer/general/disable_page_cache',
+                'loginascustomer/general/disable_page_cache',
                 \Magento\Store\Model\ScopeInterface::SCOPE_STORE
             );
             $adminId = $this->_customerSession->getLoggedAsCustomerAdmindId();
diff --git a/app/code/Magento/LoginAsCustomer/Observer/WbsiterestrictionFrontendObserver.php b/app/code/Magento/LoginAsCustomer/Observer/WbsiterestrictionFrontendObserver.php
deleted file mode 100644
index 298282f69d7f4..0000000000000
--- a/app/code/Magento/LoginAsCustomer/Observer/WbsiterestrictionFrontendObserver.php
+++ /dev/null
@@ -1,30 +0,0 @@
-<?php
-/**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
- */
-declare(strict_types=1);
-
-namespace Magento\LoginAsCustomer\Observer;
-
-use Magento\Framework\Event\ObserverInterface;
-
-/**
- * LoginAsCustomer observer
- */
-class WbsiterestrictionFrontendObserver implements ObserverInterface
-{
-    /**
-     * Disable website stub or private sales restriction for loginascustomer
-     * @param \Magento\Framework\Event\Observer $observer
-     * @return void
-     */
-    public function execute(\Magento\Framework\Event\Observer $observer): void
-    {
-        $controller = $observer->getController();
-        if ($controller->getRequest()->getModuleName() == 'loginascustomer') {
-            $result = $observer->getResult();
-            $result->setData('should_proceed', false);
-        }
-    }
-}
diff --git a/app/code/Magento/LoginAsCustomer/Block/Adminhtml/Customer/Edit/Login.php b/app/code/Magento/LoginAsCustomer/Ui/Customer/Component/Control/LoginAsCustomerButton.php
old mode 100755
new mode 100644
similarity index 69%
rename from app/code/Magento/LoginAsCustomer/Block/Adminhtml/Customer/Edit/Login.php
rename to app/code/Magento/LoginAsCustomer/Ui/Customer/Component/Control/LoginAsCustomerButton.php
index fe22450cda1ad..84d4fb6f31688
--- a/app/code/Magento/LoginAsCustomer/Block/Adminhtml/Customer/Edit/Login.php
+++ b/app/code/Magento/LoginAsCustomer/Ui/Customer/Component/Control/LoginAsCustomerButton.php
@@ -5,7 +5,7 @@
  */
 declare(strict_types=1);
 
-namespace Magento\LoginAsCustomer\Block\Adminhtml\Customer\Edit;
+namespace Magento\LoginAsCustomer\Ui\Customer\Component\Control;
 
 use Magento\Customer\Block\Adminhtml\Edit\GenericButton;
 use Magento\Framework\View\Element\UiComponent\Control\ButtonProviderInterface;
@@ -13,26 +13,23 @@
 /**
  * Login as customer button
  */
-class Login extends GenericButton implements ButtonProviderInterface
+class LoginAsCustomerButton extends GenericButton implements ButtonProviderInterface
 {
     /**
      * @var \Magento\Framework\AuthorizationInterface
      */
-    private $_authorization;
+    private $authorization;
 
     /**
-     * Constructor
-     *
      * @param \Magento\Backend\Block\Widget\Context $context
      * @param \Magento\Framework\Registry $registry
-     * @param AccountManagementInterface $customerAccountManagement
      */
     public function __construct(
         \Magento\Backend\Block\Widget\Context $context,
         \Magento\Framework\Registry $registry
     ) {
         parent::__construct($context, $registry);
-        $this->_authorization = $context->getAuthorization();
+        $this->authorization = $context->getAuthorization();
     }
 
     /**
@@ -42,12 +39,12 @@ public function getButtonData(): array
     {
         $customerId = $this->getCustomerId();
         $data = [];
-        $canModify = $customerId && $this->_authorization->isAllowed('Magento_LoginAsCustomer::login_button');
+        $canModify = $customerId && $this->authorization->isAllowed('Magento_LoginAsCustomer::login_button');
         if ($canModify) {
             $data = [
                 'label' => __('Login As Customer'),
                 'class' => 'login login-button',
-                'on_click' => 'window.open( \'' . $this->getInvalidateTokenUrl() .
+                'on_click' => 'window.open( \'' . $this->getLoginUrl() .
                     '\')',
                 'sort_order' => 70,
             ];
@@ -58,7 +55,7 @@ public function getButtonData(): array
     /**
      * @return string
      */
-    public function getInvalidateTokenUrl(): string
+    public function getLoginUrl(): string
     {
         return $this->getUrl('loginascustomer/login/login', ['customer_id' => $this->getCustomerId()]);
     }
diff --git a/app/code/Magento/LoginAsCustomer/Block/Adminhtml/Store/SaveButton.php b/app/code/Magento/LoginAsCustomer/Ui/Store/Component/Control/LoginAsCustomerButton.php
old mode 100755
new mode 100644
similarity index 76%
rename from app/code/Magento/LoginAsCustomer/Block/Adminhtml/Store/SaveButton.php
rename to app/code/Magento/LoginAsCustomer/Ui/Store/Component/Control/LoginAsCustomerButton.php
index 1403c3bfb9de7..b10c74ba2d71b
--- a/app/code/Magento/LoginAsCustomer/Block/Adminhtml/Store/SaveButton.php
+++ b/app/code/Magento/LoginAsCustomer/Ui/Store/Component/Control/LoginAsCustomerButton.php
@@ -5,16 +5,18 @@
  */
 declare(strict_types=1);
 
-namespace Magento\LoginAsCustomer\Block\Adminhtml\Store;
+namespace Magento\LoginAsCustomer\Ui\Store\Component\Control;
 
 use Magento\Framework\View\Element\UiComponent\Control\ButtonProviderInterface;
 
 /**
- * Class SaveButton
+ * Class LoginAsCustomerButton
  */
-class SaveButton implements ButtonProviderInterface
+class LoginAsCustomerButton implements ButtonProviderInterface
 {
     /**
+     * Get button data
+     *
      * @return array
      */
     public function getButtonData(): array
diff --git a/app/code/Magento/LoginAsCustomer/Ui/DataProvider/Store/Form/StoreDataProvider.php b/app/code/Magento/LoginAsCustomer/Ui/Store/DataProvider/Form/StoreDataProvider.php
similarity index 90%
rename from app/code/Magento/LoginAsCustomer/Ui/DataProvider/Store/Form/StoreDataProvider.php
rename to app/code/Magento/LoginAsCustomer/Ui/Store/DataProvider/Form/StoreDataProvider.php
index a9316fb5e1504..0980beca1b604 100644
--- a/app/code/Magento/LoginAsCustomer/Ui/DataProvider/Store/Form/StoreDataProvider.php
+++ b/app/code/Magento/LoginAsCustomer/Ui/Store/DataProvider/Form/StoreDataProvider.php
@@ -4,11 +4,15 @@
  * See COPYING.txt for license details.
  */
 declare(strict_types=1);
-namespace Magento\LoginAsCustomer\Ui\DataProvider\Store\Form;
+
+namespace Magento\LoginAsCustomer\Ui\Store\DataProvider\Form;
 
 use Magento\Customer\Model\ResourceModel\Customer\CollectionFactory;
 use Magento\Ui\DataProvider\AbstractDataProvider;
 
+/**
+ * Class StoreDataProvider
+ */
 class StoreDataProvider extends AbstractDataProvider
 {
     /**
diff --git a/app/code/Magento/LoginAsCustomer/etc/adminhtml/system.xml b/app/code/Magento/LoginAsCustomer/etc/adminhtml/system.xml
index f807ec6d366ac..537f44e65b1ad 100755
--- a/app/code/Magento/LoginAsCustomer/etc/adminhtml/system.xml
+++ b/app/code/Magento/LoginAsCustomer/etc/adminhtml/system.xml
@@ -7,7 +7,7 @@
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Config:etc/system_file.xsd">
     <system>
-        <section id="mfloginascustomer" translate="label" type="text" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1">
+        <section id="loginascustomer" translate="label" type="text" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1">
             <class>separator-top</class>
             <label>Login As Customer</label>
             <tab>customer</tab>
diff --git a/app/code/Magento/LoginAsCustomer/etc/config.xml b/app/code/Magento/LoginAsCustomer/etc/config.xml
index 0539870f1aa86..efc0b29748d5b 100755
--- a/app/code/Magento/LoginAsCustomer/etc/config.xml
+++ b/app/code/Magento/LoginAsCustomer/etc/config.xml
@@ -7,10 +7,10 @@
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Store:etc/config.xsd">
     <default>
-        <mfloginascustomer>
+        <loginascustomer>
             <general>
                 <enabled>1</enabled>
             </general>
-        </mfloginascustomer>
+        </loginascustomer>
     </default>
 </config>
diff --git a/app/code/Magento/LoginAsCustomer/etc/frontend/events.xml b/app/code/Magento/LoginAsCustomer/etc/frontend/events.xml
deleted file mode 100644
index 895bba76700b2..0000000000000
--- a/app/code/Magento/LoginAsCustomer/etc/frontend/events.xml
+++ /dev/null
@@ -1,12 +0,0 @@
-<?xml version="1.0"?>
-<!--
-/**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
- */
--->
-<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
-    <event name="websiterestriction_frontend">
-        <observer name="login_as_customer_website_restriction_frontend" instance="Magento\LoginAsCustomer\Observer\WbsiterestrictionFrontendObserver" />
-    </event>
-</config>
diff --git a/app/code/Magento/LoginAsCustomer/view/adminhtml/ui_component/customer_form.xml b/app/code/Magento/LoginAsCustomer/view/adminhtml/ui_component/customer_form.xml
index 43c746f186da0..55cbb7e55cfa8 100755
--- a/app/code/Magento/LoginAsCustomer/view/adminhtml/ui_component/customer_form.xml
+++ b/app/code/Magento/LoginAsCustomer/view/adminhtml/ui_component/customer_form.xml
@@ -9,7 +9,8 @@
       xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Ui:etc/ui_configuration.xsd">
     <settings>
         <buttons>
-            <button name="login_as_customer" class="Magento\LoginAsCustomer\Block\Adminhtml\Customer\Edit\Login"/>
+            <button name="login_as_customer"
+                    class="\Magento\LoginAsCustomer\Ui\Customer\Component\Control\LoginAsCustomerButton"/>
         </buttons>
     </settings>
 </form>
diff --git a/app/code/Magento/LoginAsCustomer/view/adminhtml/ui_component/manual_store_form.xml b/app/code/Magento/LoginAsCustomer/view/adminhtml/ui_component/manual_store_form.xml
index 71221f3acb8ed..79f1a965f3ece 100644
--- a/app/code/Magento/LoginAsCustomer/view/adminhtml/ui_component/manual_store_form.xml
+++ b/app/code/Magento/LoginAsCustomer/view/adminhtml/ui_component/manual_store_form.xml
@@ -15,7 +15,8 @@
     </argument>
     <settings>
         <buttons>
-            <button name="save" class="Magento\LoginAsCustomer\Block\Adminhtml\Store\SaveButton"/>
+            <button name="login_as_customer"
+                    class="Magento\LoginAsCustomer\Ui\Store\Component\Control\LoginAsCustomerButton"/>
         </buttons>
         <dataScope>data</dataScope>
         <deps>
@@ -26,7 +27,7 @@
         <settings>
             <submitUrl path="loginascustomer/login/login"/>
         </settings>
-        <dataProvider class="Magento\LoginAsCustomer\Ui\DataProvider\Store\Form\StoreDataProvider"
+        <dataProvider class="Magento\LoginAsCustomer\Ui\Store\DataProvider\Form\StoreDataProvider"
                       name="manual_store_form_data_source">
             <settings>
                 <requestFieldName>entity_id</requestFieldName>
diff --git a/app/code/Magento/UrlRewrite/Test/Mftf/Test/AdminCheckUrlRewritesCorrectlyGeneratedForMultipleStoreviewsDuringProductImportTest/AdminUrlRewriteGeneratedForMultipleStoreviewsDuringProductImportWithConfigTurnedOffTest.xml b/app/code/Magento/UrlRewrite/Test/Mftf/Test/AdminCheckUrlRewritesCorrectlyGeneratedForMultipleStoreviewsDuringProductImportTest/AdminUrlRewriteGeneratedForMultipleStoreviewsDuringProductImportWithConfigTurnedOffTest.xml
deleted file mode 100644
index f9003ce8c0897..0000000000000
--- a/app/code/Magento/UrlRewrite/Test/Mftf/Test/AdminCheckUrlRewritesCorrectlyGeneratedForMultipleStoreviewsDuringProductImportTest/AdminUrlRewriteGeneratedForMultipleStoreviewsDuringProductImportWithConfigTurnedOffTest.xml
+++ /dev/null
@@ -1,155 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
- /**
-  * Copyright © Magento, Inc. All rights reserved.
-  * See COPYING.txt for license details.
-  */
--->
-<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-	xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
-    <test name="AdminUrlRewriteGeneratedForMultipleStoreviewsDuringProductImportWithConfigTurnedOffTest">
-        <annotations>
-            <features value="Url Rewrite"/>
-            <stories value="Url Rewrites for Multiple Storeviews"/>
-            <title value="Url Rewrites Correctly Generated for Multiple Storeviews During Product Import With Configuration Turned Off"/>
-            <description value="Check Url Rewrites Correctly Generated for Multiple Storeviews During Product Import."/>
-            <severity value="CRITICAL"/>
-            <testCaseId value="MC-6802"/>
-            <group value="urlRewrite"/>
-        </annotations>
-        <before>
-            <!-- Set the configuration for Generate "category/product" URL Rewrites to Yes (default)-->
-            <comment userInput="Enable SEO configuration setting to generate category/product URL Rewrites" stepKey="commentEnableUrlRewriteConfig"/>
-            <magentoCLI command="config:set catalog/seo/generate_category_product_rewrites 1" stepKey="enableGenerateUrlRewrite"/>
-            <!--Flush cache-->
-            <magentoCLI command="cache:flush" stepKey="cleanCache1"/>
-            <createData entity="ApiCategory" stepKey="createCategory">
-                <field key="name">category-admin</field>
-            </createData>
-            <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
-            <!-- Create Store View EN -->
-            <actionGroup ref="AdminCreateStoreViewActionGroup" stepKey="createStoreViewEn">
-                <argument name="customStore" value="customStoreENNotUnique"/>
-            </actionGroup>
-            <!-- Create Store View NL -->
-            <actionGroup ref="AdminCreateStoreViewActionGroup" stepKey="createStoreViewNl">
-                <argument name="customStore" value="customStoreNLNotUnique"/>
-            </actionGroup>
-            <!-- Set the configuration for Generate "category/product" URL Rewrites to No-->
-            <comment userInput="Disable SEO configuration setting to generate category/product URL Rewrites" stepKey="commentDisableUrlRewriteConfig"/>
-            <magentoCLI command="config:set catalog/seo/generate_category_product_rewrites 0" stepKey="disableGenerateUrlRewrite"/>
-            <!--Flush cache-->
-            <magentoCLI command="cache:flush" stepKey="cleanCache"/>
-        </before>
-        <after>
-            <deleteData createDataKey="createCategory" stepKey="deleteCategory"/>
-            <actionGroup ref="AdminDeleteStoreViewActionGroup" stepKey="deleteStoreViewEn">
-                <argument name="customStore" value="customStoreENNotUnique"/>
-            </actionGroup>
-            <actionGroup ref="AdminDeleteStoreViewActionGroup" stepKey="deleteStoreViewNl">
-                <argument name="customStore" value="customStoreNLNotUnique"/>
-            </actionGroup>
-            <actionGroup ref="ClearFiltersAdminDataGridActionGroup" stepKey="clearStoreGridFilters"/>
-            <actionGroup ref="DeleteProductByNameActionGroup" stepKey="deleteImportedProduct">
-                <argument name="sku" value="productformagetwo68980"/>
-                <argument name="name" value="productformagetwo68980"/>
-            </actionGroup>
-            <actionGroup ref="ClearFiltersAdminDataGridActionGroup" stepKey="clearFiltersIfSet"/>
-            <actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
-            <magentoCLI command="config:set catalog/seo/generate_category_product_rewrites 1" stepKey="resetConfigurationSetting"/>
-            <!--Flush cache-->
-            <magentoCLI command="cache:flush" stepKey="cleanCache2"/>
-        </after>
-        <actionGroup ref="SwitchCategoryStoreViewActionGroup" stepKey="switchToStoreViewEn">
-            <argument name="Store" value="customStoreENNotUnique.name"/>
-            <argument name="CatName" value="$$createCategory.name$$"/>
-        </actionGroup>
-        <uncheckOption selector="{{AdminCategoryBasicFieldSection.categoryNameUseDefault}}" stepKey="uncheckUseDefaultValueENStoreView"/>
-        <fillField selector="{{AdminCategoryBasicFieldSection.CategoryNameInput}}" userInput="category-english" stepKey="changeNameField"/>
-        <click selector="{{AdminCategorySEOSection.SectionHeader}}" stepKey="clickOnSectionHeader"/>
-        <actionGroup ref="ChangeSeoUrlKeyForSubCategoryActionGroup" stepKey="changeSeoUrlKeyENStoreView">
-            <argument name="value" value="category-english"/>
-        </actionGroup>
-        <actionGroup ref="SwitchCategoryStoreViewActionGroup" stepKey="switchToStoreViewNl">
-            <argument name="Store" value="customStoreNLNotUnique.name"/>
-            <argument name="CatName" value="$$createCategory.name$$"/>
-        </actionGroup>
-        <uncheckOption selector="{{AdminCategoryBasicFieldSection.categoryNameUseDefault}}" stepKey="uncheckUseDefaultValue1"/>
-        <fillField selector="{{AdminCategoryBasicFieldSection.CategoryNameInput}}" userInput="category-dutch" stepKey="changeNameFieldNLStoreView"/>
-        <click selector="{{AdminCategorySEOSection.SectionHeader}}" stepKey="clickOnSectionHeader2"/>
-        <actionGroup ref="ChangeSeoUrlKeyForSubCategoryActionGroup" stepKey="changeSeoUrlKeyNLStoreView">
-            <argument name="value" value="category-dutch"/>
-        </actionGroup>
-        <amOnPage url="{{AdminImportIndexPage.url}}" stepKey="navigateToSystemImport"/>
-        <selectOption selector="{{AdminImportMainSection.entityType}}" userInput="Products" stepKey="selectProductsOption"/>
-        <waitForElementVisible selector="{{AdminImportMainSection.importBehavior}}" stepKey="waitForImportBehaviorElementVisible"/>
-        <selectOption selector="{{AdminImportMainSection.importBehavior}}" userInput="Add/Update" stepKey="selectAddUpdateOption"/>
-        <attachFile selector="{{AdminImportMainSection.selectFileToImport}}" userInput="import_updated.csv" stepKey="attachFileForImport"/>
-        <click selector="{{AdminImportHeaderSection.checkDataButton}}" stepKey="clickCheckDataButton"/>
-        <see selector="{{AdminImportValidationMessagesSection.notice}}" userInput="Checked rows: 3, checked entities: 1, invalid rows: 0, total errors: 0" stepKey="assertNotice"/>
-        <see selector="{{AdminImportValidationMessagesSection.success}}" userInput="File is valid! To start import process press &quot;Import&quot; button" stepKey="assertSuccessMessage"/>
-        <click selector="{{AdminImportMainSection.importButton}}" stepKey="clickImportButton"/>
-        <see selector="{{AdminImportValidationMessagesSection.success}}" userInput="Import successfully done" stepKey="assertSuccessMessage1"/>
-        <see selector="{{AdminImportValidationMessagesSection.notice}}" userInput="Created: 1, Updated: 0, Deleted: 0" stepKey="assertNotice1"/>
-        <actionGroup ref="SearchForProductOnBackendByNameActionGroup" stepKey="searchForProductOnBackend">
-            <argument name="productName" value="productformagetwo68980"/>
-        </actionGroup>
-        <click selector="{{AdminProductGridSection.productRowBySku('productformagetwo68980')}}" stepKey="clickOnProductRow"/>
-        <grabFromCurrentUrl regex="~/id/(\d+)/~" stepKey="grabProductIdFromUrl"/>
-        <amOnPage url="{{AdminUrlRewriteIndexPage.url}}" stepKey="goToUrlRewritesIndexPage"/>
-
-        <click selector="{{AdminDataGridHeaderSection.filters}}" stepKey="openUrlRewriteGridFilters"/>
-        <fillField selector="{{AdminDataGridHeaderSection.filterFieldInput('request_path')}}" userInput="category-english.html" stepKey="inputCategoryUrlForENStoreView"/>
-        <click selector="{{AdminDataGridHeaderSection.applyFilters}}" stepKey="clickOrderApplyFilters"/>
-        <waitForPageLoad stepKey="waitForPageToLoad"/>
-        <seeElement selector="{{AdminUrlRewriteIndexSection.gridCellByColumnValue('Request Path', 'category-english.html')}}" stepKey="seeUrlInRequestPathColumn"/>
-        <seeElement selector="{{AdminUrlRewriteIndexSection.gridCellByColumnValue('Target Path', catalog/category/view/id/$$createCategory.id$$)}}" stepKey="seeUrlInTargetPathColumn"/>
-
-        <click selector="{{AdminDataGridHeaderSection.filters}}" stepKey="openUrlRewriteGridFilters1"/>
-        <fillField selector="{{AdminDataGridHeaderSection.filterFieldInput('request_path')}}" userInput="category-dutch.html" stepKey="inputCategoryUrlForNLStoreView"/>
-        <click selector="{{AdminDataGridHeaderSection.applyFilters}}" stepKey="clickOrderApplyFilters1"/>
-        <waitForPageLoad stepKey="waitForPageToLoad1"/>
-        <seeElement selector="{{AdminUrlRewriteIndexSection.gridCellByColumnValue('Request Path', 'category-dutch.html')}}" stepKey="seeUrlInRequestPathColumn1"/>
-        <seeElement selector="{{AdminUrlRewriteIndexSection.gridCellByColumnValue('Target Path', catalog/category/view/id/$$createCategory.id$$)}}" stepKey="seeUrlInTargetPathColumn1"/>
-
-        <click selector="{{AdminDataGridHeaderSection.filters}}" stepKey="openUrlRewriteGridFilters2"/>
-        <fillField selector="{{AdminDataGridHeaderSection.filterFieldInput('request_path')}}" userInput="productformagetwo68980-english.html" stepKey="inputProductUrlForENStoreView"/>
-        <click selector="{{AdminDataGridHeaderSection.applyFilters}}" stepKey="clickOrderApplyFilters2"/>
-        <waitForPageLoad stepKey="waitForPageToLoad2"/>
-        <seeElement selector="{{AdminUrlRewriteIndexSection.gridCellByColumnValue('Request Path', 'productformagetwo68980-english.html')}}" stepKey="seeUrlInRequestPathColumn2"/>
-        <seeElement selector="{{AdminUrlRewriteIndexSection.gridCellByColumnValue('Target Path', 'catalog/product/view/id/$grabProductIdFromUrl')}}" stepKey="seeUrlInTargetPathColumn2"/>
-        <dontSeeElement selector="{{AdminUrlRewriteIndexSection.gridCellByColumnValue('Request Path', 'category-english/productformagetwo68980-english.html')}}" stepKey="seeUrlInRequestPathColumn4"/>
-        <dontSeeElement selector="{{AdminUrlRewriteIndexSection.gridCellByColumnValue('Target Path', catalog/product/view/id/$grabProductIdFromUrl/category/$$createCategory.id$$)}}" stepKey="seeUrlInTargetPathColumn4"/>
-
-        <click selector="{{AdminDataGridHeaderSection.filters}}" stepKey="openUrlRewriteGridFilters3"/>
-        <fillField selector="{{AdminDataGridHeaderSection.filterFieldInput('request_path')}}" userInput="productformagetwo68980-dutch.html" stepKey="inputProductUrlForENStoreView1"/>
-        <click selector="{{AdminDataGridHeaderSection.applyFilters}}" stepKey="clickOrderApplyFilters3"/>
-        <waitForPageLoad stepKey="waitForPageToLoad3"/>
-        <seeElement selector="{{AdminUrlRewriteIndexSection.gridCellByColumnValue('Request Path', 'productformagetwo68980-dutch.html')}}" stepKey="seeUrlInRequestPathColumn3"/>
-        <seeElement selector="{{AdminUrlRewriteIndexSection.gridCellByColumnValue('Target Path', 'catalog/product/view/id/$grabProductIdFromUrl')}}" stepKey="seeUrlInTargetPathColumn3"/>
-        <dontSeeElement selector="{{AdminUrlRewriteIndexSection.gridCellByColumnValue('Request Path', 'category-dutch/productformagetwo68980-dutch.html')}}" stepKey="seeUrlInRequestPathColumn5"/>
-        <dontSeeElement selector="{{AdminUrlRewriteIndexSection.gridCellByColumnValue('Target Path', catalog/product/view/id/$grabProductIdFromUrl/category/$$createCategory.id$$)}}" stepKey="seeUrlInTargetPathColumn5"/>
-
-        <!-- Switch StoreView -->
-        <amOnPage url="{{StorefrontHomePage.url}}" stepKey="amOnProduct4Page"/>
-        <actionGroup ref="StorefrontSwitchStoreViewActionGroup" stepKey="switchToCustomStoreView">
-            <argument name="storeView" value="customStoreENNotUnique"/>
-        </actionGroup>
-
-        <amOnPage url="/productformagetwo68980-english.html" stepKey="navigateToProductPage"/>
-        <see selector="{{StorefrontProductInfoMainSection.productName}}" userInput="productformagetwo68980-english" stepKey="seeProductName"/>
-        <amOnPage url="/category-english/productformagetwo68980-english.html" stepKey="navigateToProductPage2"/>
-        <see selector="{{StorefrontProductInfoMainSection.productName}}" userInput="productformagetwo68980-english" stepKey="seeProductName2"/>
-
-        <!-- Switch StoreView -->
-        <amOnPage url="{{StorefrontHomePage.url}}" stepKey="amOnProduct4Page2"/>
-        <actionGroup ref="StorefrontSwitchStoreViewActionGroup" stepKey="switchToCustomStoreView2">
-            <argument name="storeView" value="customStoreNLNotUnique"/>
-        </actionGroup>
-
-        <amOnPage url="/productformagetwo68980-dutch.html" stepKey="navigateToProductPage3"/>
-        <see selector="{{StorefrontProductInfoMainSection.productName}}" userInput="productformagetwo68980-dutch" stepKey="seeProductName3"/>
-        <amOnPage url="/category-dutch/productformagetwo68980-dutch.html" stepKey="navigateToProductPage4"/>
-        <see selector="{{StorefrontProductInfoMainSection.productName}}" userInput="productformagetwo68980-dutch" stepKey="seeProductName4"/>
-    </test>
-</tests>

From 080a6246aad00d9e288a051fdec18777047b5cf7 Mon Sep 17 00:00:00 2001
From: Pavel Bystritsky <engcom-vendorworker-foxtrot@adobe.com>
Date: Fri, 24 Apr 2020 11:51:37 +0300
Subject: [PATCH 5/8] magento2-login-as-customer/issues/90: Static tests fix.

---
 .../Controller/Adminhtml/Login/Login.php      |  2 +-
 .../Magento/LoginAsCustomer/Model/Config.php  | 40 ++++++++-----------
 .../Model/PageCache/ConfigPlugin.php          |  4 ++
 .../Control/LoginAsCustomerButton.php         |  7 +++-
 .../Control/LoginAsCustomerButton.php         |  3 +-
 .../DataProvider/Form/StoreDataProvider.php   |  3 +-
 .../LoginAsCustomer/etc/adminhtml/system.xml  |  2 +-
 7 files changed, 29 insertions(+), 32 deletions(-)

diff --git a/app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Login.php b/app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Login.php
index 72f6f39b344bd..8c3f0969cfbe6 100755
--- a/app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Login.php
+++ b/app/code/Magento/LoginAsCustomer/Controller/Adminhtml/Login/Login.php
@@ -100,7 +100,7 @@ public function execute(): ResultInterface
 
         $customerStoreId = $request->getParam('store_id');
 
-        if (!isset($customerStoreId) && $this->config->getStoreViewLogin()) {
+        if (!isset($customerStoreId) && $this->config->isManualChoiceEnabled()) {
             $this->messageManager->addNoticeMessage(__('Please select a Store View to login in.'));
             return $resultRedirect->setPath('loginascustomer/login/manual', ['entity_id' => $customerId ]);
         }
diff --git a/app/code/Magento/LoginAsCustomer/Model/Config.php b/app/code/Magento/LoginAsCustomer/Model/Config.php
index 851839e6d1e1b..7b34cc8dcfd7c 100644
--- a/app/code/Magento/LoginAsCustomer/Model/Config.php
+++ b/app/code/Magento/LoginAsCustomer/Model/Config.php
@@ -8,11 +8,11 @@
 namespace Magento\LoginAsCustomer\Model;
 
 use Magento\Framework\App\Config\ScopeConfigInterface;
-use Magento\Store\Model\ScopeInterface;
 use Magento\Framework\App\ProductMetadataInterface;
+use Magento\Store\Model\ScopeInterface;
 
 /**
- * Class Config
+ * LoginAsCustomer module config model.
  */
 class Config
 {
@@ -20,7 +20,7 @@ class Config
      * Extension config path
      */
     private const XML_PATH_EXTENSION_ENABLED = 'loginascustomer/general/enabled';
-    private const STORE_VIEW_TO_LOGIN_IN = 'loginascustomer/general/store_view_login';
+    private const ENABLE_STORE_VIEW_MANUAL_CHOICE = 'loginascustomer/general/enable_store_view_manual_choice';
 
     /**
      * @var ScopeConfigInterface
@@ -34,7 +34,6 @@ class Config
     private $metadata;
 
     /**
-     * Config constructor.
      * @param ScopeConfigInterface $scopeConfig
      * @param ProductMetadataInterface $metadata
      */
@@ -47,37 +46,30 @@ public function __construct(
     }
 
     /**
-     * Retrieve store config value
-     * @param string $path
-     * @param null $storeId
-     * @return mixed
-     */
-    public function getConfig($path, $storeId = null)
-    {
-        return $this->scopeConfig->getValue(
-            $path,
-            ScopeInterface::SCOPE_STORE,
-            $storeId
-        );
-    }
-
-    /**
+     * Check if Login As Customer extension is enabled.
+     *
      * @return bool
      */
     public function isEnabled(): bool
     {
-        return (bool)$this->getConfig(
-            self::XML_PATH_EXTENSION_ENABLED
+        return (bool)$this->scopeConfig->getValue(
+            self::XML_PATH_EXTENSION_ENABLED,
+            ScopeInterface::SCOPE_STORE,
+            null
         );
     }
 
     /**
+     * Check if store view manual choice is enabled.
+     *
      * @return bool
      */
-    public function getStoreViewLogin(): bool
+    public function isManualChoiceEnabled(): bool
     {
-        return (bool)$this->getConfig(
-            self::STORE_VIEW_TO_LOGIN_IN
+        return (bool)$this->scopeConfig->getValue(
+            self::ENABLE_STORE_VIEW_MANUAL_CHOICE,
+            ScopeInterface::SCOPE_STORE,
+            null
         );
     }
 }
diff --git a/app/code/Magento/LoginAsCustomer/Model/PageCache/ConfigPlugin.php b/app/code/Magento/LoginAsCustomer/Model/PageCache/ConfigPlugin.php
index f0d45cc306f38..63aea9d8f05e3 100644
--- a/app/code/Magento/LoginAsCustomer/Model/PageCache/ConfigPlugin.php
+++ b/app/code/Magento/LoginAsCustomer/Model/PageCache/ConfigPlugin.php
@@ -9,6 +9,8 @@
 
 /**
  * Page cache config plugin
+ *
+ * @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
  */
 class ConfigPlugin
 {
@@ -44,10 +46,12 @@ public function __construct(
      * @param \Magento\PageCache\Model\Config $subject
      * @param bool $result
      * @return bool
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function afterIsEnabled(\Magento\PageCache\Model\Config $subject, $result): bool
     {
         if ($result) {
+
             $disable = $this->_scopeConfig->getValue(
                 'loginascustomer/general/disable_page_cache',
                 \Magento\Store\Model\ScopeInterface::SCOPE_STORE
diff --git a/app/code/Magento/LoginAsCustomer/Ui/Customer/Component/Control/LoginAsCustomerButton.php b/app/code/Magento/LoginAsCustomer/Ui/Customer/Component/Control/LoginAsCustomerButton.php
index 84d4fb6f31688..a37d8613e0019 100644
--- a/app/code/Magento/LoginAsCustomer/Ui/Customer/Component/Control/LoginAsCustomerButton.php
+++ b/app/code/Magento/LoginAsCustomer/Ui/Customer/Component/Control/LoginAsCustomerButton.php
@@ -11,7 +11,7 @@
 use Magento\Framework\View\Element\UiComponent\Control\ButtonProviderInterface;
 
 /**
- * Login as customer button
+ * Login As Customer button UI component.
  */
 class LoginAsCustomerButton extends GenericButton implements ButtonProviderInterface
 {
@@ -33,7 +33,7 @@ public function __construct(
     }
 
     /**
-     * @return array
+     * @inheritdoc
      */
     public function getButtonData(): array
     {
@@ -49,10 +49,13 @@ public function getButtonData(): array
                 'sort_order' => 70,
             ];
         }
+
         return $data;
     }
 
     /**
+     * Get Login As Customer login url.
+     *
      * @return string
      */
     public function getLoginUrl(): string
diff --git a/app/code/Magento/LoginAsCustomer/Ui/Store/Component/Control/LoginAsCustomerButton.php b/app/code/Magento/LoginAsCustomer/Ui/Store/Component/Control/LoginAsCustomerButton.php
index b10c74ba2d71b..4d7aebc9c0d66 100644
--- a/app/code/Magento/LoginAsCustomer/Ui/Store/Component/Control/LoginAsCustomerButton.php
+++ b/app/code/Magento/LoginAsCustomer/Ui/Store/Component/Control/LoginAsCustomerButton.php
@@ -10,7 +10,7 @@
 use Magento\Framework\View\Element\UiComponent\Control\ButtonProviderInterface;
 
 /**
- * Class LoginAsCustomerButton
+ * Login As Customer button UI component.
  */
 class LoginAsCustomerButton implements ButtonProviderInterface
 {
@@ -32,4 +32,3 @@ public function getButtonData(): array
         ];
     }
 }
-
diff --git a/app/code/Magento/LoginAsCustomer/Ui/Store/DataProvider/Form/StoreDataProvider.php b/app/code/Magento/LoginAsCustomer/Ui/Store/DataProvider/Form/StoreDataProvider.php
index 0980beca1b604..f06458ed72e98 100644
--- a/app/code/Magento/LoginAsCustomer/Ui/Store/DataProvider/Form/StoreDataProvider.php
+++ b/app/code/Magento/LoginAsCustomer/Ui/Store/DataProvider/Form/StoreDataProvider.php
@@ -11,7 +11,7 @@
 use Magento\Ui\DataProvider\AbstractDataProvider;
 
 /**
- * Class StoreDataProvider
+ * Login As Customer store view form data provider.
  */
 class StoreDataProvider extends AbstractDataProvider
 {
@@ -34,5 +34,4 @@ public function __construct(
         $this->collection = $collectionFactory->create();
         parent::__construct($name, $primaryFieldName, $requestFieldName, $meta, $data);
     }
-
 }
diff --git a/app/code/Magento/LoginAsCustomer/etc/adminhtml/system.xml b/app/code/Magento/LoginAsCustomer/etc/adminhtml/system.xml
index 537f44e65b1ad..bfb90dc3413e7 100755
--- a/app/code/Magento/LoginAsCustomer/etc/adminhtml/system.xml
+++ b/app/code/Magento/LoginAsCustomer/etc/adminhtml/system.xml
@@ -23,7 +23,7 @@
                     <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
                     <comment><![CDATA[If set to "Yes", when login as customer Page Cache will be disabled.]]></comment>
                 </field>
-                <field id="store_view_login" translate="label comment" type="select" sortOrder="40" showInDefault="1" showInWebsite="1" showInStore="1">
+                <field id="enable_store_view_manual_choice" translate="label comment" type="select" sortOrder="40" showInDefault="1" showInWebsite="1" showInStore="1">
                     <label>Store View To Login In</label>
                     <source_model>Magento\LoginAsCustomer\Model\Config\Source\StoreViewLogin</source_model>
                     <comment><![CDATA[

From e4452f63c7ef8a79b998af4599c5ff8b2818387d Mon Sep 17 00:00:00 2001
From: Pavel Bystritsky <engcom-vendorworker-foxtrot@adobe.com>
Date: Fri, 24 Apr 2020 14:43:05 +0300
Subject: [PATCH 6/8] magento2-login-as-customer/issues/90: Integration tests
 fix.

---
 .../Magento/Sales/Model/AdminOrder/CreateTest.php     | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/dev/tests/integration/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php b/dev/tests/integration/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php
index b1a8d8e685226..bdcb56e913852 100644
--- a/dev/tests/integration/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php
+++ b/dev/tests/integration/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php
@@ -5,6 +5,7 @@
  */
 namespace Magento\Sales\Model\AdminOrder;
 
+use Magento\Backend\Model\Auth;
 use Magento\Backend\Model\Session\Quote as SessionQuote;
 use Magento\Customer\Api\AddressRepositoryInterface;
 use Magento\Customer\Api\CustomerRepositoryInterface;
@@ -42,11 +43,21 @@ class CreateTest extends \PHPUnit\Framework\TestCase
      */
     private $objectManager;
 
+    /**
+     * @var Auth
+     */
+    private $auth;
+
     protected function setUp()
     {
         $this->objectManager = Bootstrap::getObjectManager();
         $this->messageManager = $this->objectManager->get(ManagerInterface::class);
         $this->model =$this->objectManager->create(Create::class, ['messageManager' => $this->messageManager]);
+        $this->auth = $this->objectManager->create(Auth::class);
+        $this->auth->login(
+            \Magento\TestFramework\Bootstrap::ADMIN_NAME,
+            \Magento\TestFramework\Bootstrap::ADMIN_PASSWORD
+        );
     }
 
     /**

From 9cf2a1c6f6fbde7d8b8f6e8d7891aa44b68c382e Mon Sep 17 00:00:00 2001
From: Valerii Naida <vnayda@adobe.com>
Date: Fri, 24 Apr 2020 10:45:14 -0500
Subject: [PATCH 7/8] magento2-login-as-customer/issues/90: Tests stabilization

---
 .../Magento/LoginAsCustomer/etc/webrestrictions.xml   | 11 -----------
 1 file changed, 11 deletions(-)
 delete mode 100644 app/code/Magento/LoginAsCustomer/etc/webrestrictions.xml

diff --git a/app/code/Magento/LoginAsCustomer/etc/webrestrictions.xml b/app/code/Magento/LoginAsCustomer/etc/webrestrictions.xml
deleted file mode 100644
index 5d909de63d123..0000000000000
--- a/app/code/Magento/LoginAsCustomer/etc/webrestrictions.xml
+++ /dev/null
@@ -1,11 +0,0 @@
-<?xml version="1.0"?>
-<!--
-/**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
- */
--->
-<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_WebsiteRestriction:etc/webrestrictions.xsd">
-    <action path="loginascustomer_login_index" type="generic" />
-    <action path="loginascustomer_login_proceed" type="generic" />
-</config>

From 4a30707ffe6879cb79eb7d33bb970b1fd97fd531 Mon Sep 17 00:00:00 2001
From: Pavel Bystritsky <engcom-vendorworker-foxtrot@adobe.com>
Date: Mon, 27 Apr 2020 17:47:19 +0300
Subject: [PATCH 8/8] magento2-login-as-customer/issues/90: Logging update.

---
 .../AdminAddCommentOnOrderPlacementPlugin.php | 22 ++++++++++---------
 .../Sales/Model/AdminOrder/CreateTest.php     | 11 ----------
 2 files changed, 12 insertions(+), 21 deletions(-)

diff --git a/app/code/Magento/LoginAsCustomer/Plugin/AdminAddCommentOnOrderPlacementPlugin.php b/app/code/Magento/LoginAsCustomer/Plugin/AdminAddCommentOnOrderPlacementPlugin.php
index e87e5553ef4c8..da6cbd4ef706b 100644
--- a/app/code/Magento/LoginAsCustomer/Plugin/AdminAddCommentOnOrderPlacementPlugin.php
+++ b/app/code/Magento/LoginAsCustomer/Plugin/AdminAddCommentOnOrderPlacementPlugin.php
@@ -39,16 +39,18 @@ public function __construct(
     public function afterPlace(Order $subject, Order $result): Order
     {
         $adminUser = $this->userSession->getUser();
-        $subject->addCommentToStatusHistory(
-            'Order Placed by Store Administrator',
-            false,
-            true
-        )->setIsCustomerNotified(false);
-        $subject->addCommentToStatusHistory(
-            "Order Placed by {$adminUser->getFirstName()} {$adminUser->getLastName()} using Admin Panel",
-            false,
-            false
-        )->setIsCustomerNotified(false);
+        if ($adminUser) {
+            $subject->addCommentToStatusHistory(
+                'Order Placed by Store Administrator',
+                false,
+                true
+            )->setIsCustomerNotified(false);
+            $subject->addCommentToStatusHistory(
+                "Order Placed by {$adminUser->getFirstName()} {$adminUser->getLastName()} using Admin Panel",
+                false,
+                false
+            )->setIsCustomerNotified(false);
+        }
 
         return $result;
     }
diff --git a/dev/tests/integration/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php b/dev/tests/integration/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php
index bdcb56e913852..b1a8d8e685226 100644
--- a/dev/tests/integration/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php
+++ b/dev/tests/integration/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php
@@ -5,7 +5,6 @@
  */
 namespace Magento\Sales\Model\AdminOrder;
 
-use Magento\Backend\Model\Auth;
 use Magento\Backend\Model\Session\Quote as SessionQuote;
 use Magento\Customer\Api\AddressRepositoryInterface;
 use Magento\Customer\Api\CustomerRepositoryInterface;
@@ -43,21 +42,11 @@ class CreateTest extends \PHPUnit\Framework\TestCase
      */
     private $objectManager;
 
-    /**
-     * @var Auth
-     */
-    private $auth;
-
     protected function setUp()
     {
         $this->objectManager = Bootstrap::getObjectManager();
         $this->messageManager = $this->objectManager->get(ManagerInterface::class);
         $this->model =$this->objectManager->create(Create::class, ['messageManager' => $this->messageManager]);
-        $this->auth = $this->objectManager->create(Auth::class);
-        $this->auth->login(
-            \Magento\TestFramework\Bootstrap::ADMIN_NAME,
-            \Magento\TestFramework\Bootstrap::ADMIN_PASSWORD
-        );
     }
 
     /**