-
Notifications
You must be signed in to change notification settings - Fork 9.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
magento/graphql-ce#683: Add discount information to Cart
- extracted discount cases to separate test class; - added case for no discount applied; - return `null` for discount node if amount is 0.
- Loading branch information
1 parent
a1e126c
commit 2d8bc6d
Showing
5 changed files
with
228 additions
and
89 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123 changes: 123 additions & 0 deletions
123
dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/CartDiscountTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| <?php | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| declare(strict_types=1); | ||
|
|
||
| namespace Magento\GraphQl\Quote\Customer; | ||
|
|
||
| use Magento\GraphQl\Quote\GetMaskedQuoteIdByReservedOrderId; | ||
| use Magento\Integration\Api\CustomerTokenServiceInterface; | ||
| use Magento\TestFramework\Helper\Bootstrap; | ||
| use Magento\TestFramework\TestCase\GraphQlAbstract; | ||
|
|
||
| /** | ||
| * Test is getting cart discount for registered customer. | ||
| */ | ||
| class CartDiscountTest extends GraphQlAbstract | ||
| { | ||
| /** | ||
| * @var CustomerTokenServiceInterface | ||
| */ | ||
| private $customerTokenService; | ||
|
|
||
| /** | ||
| * @var GetMaskedQuoteIdByReservedOrderId | ||
| */ | ||
| private $getMaskedQuoteIdByReservedOrderId; | ||
|
|
||
| protected function setUp() | ||
| { | ||
| $objectManager = Bootstrap::getObjectManager(); | ||
| $this->getMaskedQuoteIdByReservedOrderId = $objectManager->get(GetMaskedQuoteIdByReservedOrderId::class); | ||
| $this->customerTokenService = $objectManager->get(CustomerTokenServiceInterface::class); | ||
| } | ||
|
|
||
| /** | ||
| * @magentoApiDataFixture Magento/Customer/_files/customer.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/cart_rule_discount_no_coupon.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/customer/create_empty_cart.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php | ||
| */ | ||
| public function testGetDiscountInformation() | ||
| { | ||
| $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote'); | ||
| $query = $this->getQuery($maskedQuoteId); | ||
| $response = $this->graphQlQuery($query, [], '', $this->getHeaderMap()); | ||
| $discountResponse = $response['cart']['prices']['discount']; | ||
| self::assertEquals(-10, $discountResponse['amount']['value']); | ||
| self::assertEquals(['50% Off for all orders'], $discountResponse['label']); | ||
| } | ||
|
|
||
| /** | ||
| * @magentoApiDataFixture Magento/Customer/_files/customer.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/cart_rule_discount_no_coupon.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php | ||
| * @magentoApiDataFixture Magento/Checkout/_files/discount_10percent_generalusers.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/customer/create_empty_cart.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/apply_coupon.php | ||
| */ | ||
| public function testGetDiscountInformationWithTwoRulesApplied() | ||
| { | ||
| $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote'); | ||
| $query = $this->getQuery($maskedQuoteId); | ||
| $response = $this->graphQlQuery($query, [], '', $this->getHeaderMap()); | ||
| $discountResponse = $response['cart']['prices']['discount']; | ||
| self::assertEquals(-11, $discountResponse['amount']['value']); | ||
| self::assertEquals(['50% Off for all orders', 'Test Coupon for General'], $discountResponse['label']); | ||
| } | ||
|
|
||
| /** | ||
| * @magentoApiDataFixture Magento/Customer/_files/customer.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/customer/create_empty_cart.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php | ||
| */ | ||
| public function testGetDiscountInformationWithNoRulesApplied() | ||
| { | ||
| $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote'); | ||
| $query = $this->getQuery($maskedQuoteId); | ||
| $response = $this->graphQlQuery($query, [], '', $this->getHeaderMap()); | ||
| self::assertEquals(null, $response['cart']['prices']['discount']); | ||
| } | ||
|
|
||
| /** | ||
| * Generates GraphQl query for retrieving cart discount | ||
| * | ||
| * @param string $maskedQuoteId | ||
| * @return string | ||
| */ | ||
| private function getQuery(string $maskedQuoteId): string | ||
| { | ||
| return <<<QUERY | ||
| { | ||
| cart(cart_id: "$maskedQuoteId") { | ||
| prices { | ||
| discount { | ||
| label | ||
| amount { | ||
| value | ||
| currency | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| QUERY; | ||
| } | ||
|
|
||
| /** | ||
| * @param string $username | ||
| * @param string $password | ||
| * @return array | ||
| */ | ||
| private function getHeaderMap(string $username = 'customer@example.com', string $password = 'password'): array | ||
| { | ||
| $customerToken = $this->customerTokenService->createCustomerAccessToken($username, $password); | ||
| $headerMap = ['Authorization' => 'Bearer ' . $customerToken]; | ||
| return $headerMap; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 101 additions & 0 deletions
101
dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/CartDiscountTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| <?php | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| declare(strict_types=1); | ||
|
|
||
| namespace Magento\GraphQl\Quote\Guest; | ||
|
|
||
| use Magento\GraphQl\Quote\GetMaskedQuoteIdByReservedOrderId; | ||
| use Magento\TestFramework\Helper\Bootstrap; | ||
| use Magento\TestFramework\TestCase\GraphQlAbstract; | ||
|
|
||
| /** | ||
| * Test is getting cart discount for guest customer. | ||
| */ | ||
| class CartDiscountTest extends GraphQlAbstract | ||
| { | ||
| /** | ||
| * @var GetMaskedQuoteIdByReservedOrderId | ||
| */ | ||
| private $getMaskedQuoteIdByReservedOrderId; | ||
|
|
||
| protected function setUp() | ||
| { | ||
| $objectManager = Bootstrap::getObjectManager(); | ||
| $this->getMaskedQuoteIdByReservedOrderId = $objectManager->get(GetMaskedQuoteIdByReservedOrderId::class); | ||
| } | ||
|
|
||
| /** | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/cart_rule_discount_no_coupon.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/guest/create_empty_cart.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php | ||
| */ | ||
| public function testGetDiscountInformation() | ||
| { | ||
| $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote'); | ||
| $query = $this->getQuery($maskedQuoteId); | ||
| $response = $this->graphQlQuery($query); | ||
| $discountResponse = $response['cart']['prices']['discount']; | ||
| self::assertEquals(-10, $discountResponse['amount']['value']); | ||
| self::assertEquals(['50% Off for all orders'], $discountResponse['label']); | ||
| } | ||
|
|
||
| /** | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/cart_rule_discount_no_coupon.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php | ||
| * @magentoApiDataFixture Magento/SalesRule/_files/coupon_code_with_wildcard.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/guest/create_empty_cart.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/apply_coupon.php | ||
| */ | ||
| public function testGetDiscountInformationWithTwoRulesApplied() | ||
| { | ||
| $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote'); | ||
| $query = $this->getQuery($maskedQuoteId); | ||
| $response = $this->graphQlQuery($query); | ||
| $discountResponse = $response['cart']['prices']['discount']; | ||
| self::assertEquals(-15, $discountResponse['amount']['value']); | ||
| self::assertEquals(['50% Off for all orders', '5$ fixed discount on whole cart'], $discountResponse['label']); | ||
| } | ||
|
|
||
| /** | ||
| * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/guest/create_empty_cart.php | ||
| * @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php | ||
| */ | ||
| public function testGetDiscountInformationWithNoRulesApplied() | ||
| { | ||
| $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote'); | ||
| $query = $this->getQuery($maskedQuoteId); | ||
| $response = $this->graphQlQuery($query); | ||
| self::assertEquals(null, $response['cart']['prices']['discount']); | ||
| } | ||
|
|
||
| /** | ||
| * Generates GraphQl query for retrieving cart discount. | ||
| * | ||
| * @param string $maskedQuoteId | ||
| * @return string | ||
| */ | ||
| private function getQuery(string $maskedQuoteId): string | ||
| { | ||
| return <<<QUERY | ||
| { | ||
| cart(cart_id: "$maskedQuoteId") { | ||
| prices { | ||
| discount { | ||
| label | ||
| amount { | ||
| value | ||
| currency | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| QUERY; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters