diff --git a/app/code/Magento/Checkout/view/frontend/web/template/shipping-address/address-renderer/default.html b/app/code/Magento/Checkout/view/frontend/web/template/shipping-address/address-renderer/default.html
index 4c3ce84baac4d..f9400227fae09 100644
--- a/app/code/Magento/Checkout/view/frontend/web/template/shipping-address/address-renderer/default.html
+++ b/app/code/Magento/Checkout/view/frontend/web/template/shipping-address/address-renderer/default.html
@@ -5,7 +5,7 @@
*/
-->
-
+
,
diff --git a/app/code/Magento/Checkout/view/frontend/web/template/shipping-information/address-renderer/default.html b/app/code/Magento/Checkout/view/frontend/web/template/shipping-information/address-renderer/default.html
index c3afce6c4537f..ec41cae0bdc5e 100644
--- a/app/code/Magento/Checkout/view/frontend/web/template/shipping-information/address-renderer/default.html
+++ b/app/code/Magento/Checkout/view/frontend/web/template/shipping-information/address-renderer/default.html
@@ -5,7 +5,7 @@
*/
-->
-
+
,
diff --git a/app/code/Magento/Cms/Model/BlockRepository.php b/app/code/Magento/Cms/Model/BlockRepository.php
index a06c5fac1bc4e..5f8ec399e9bd6 100644
--- a/app/code/Magento/Cms/Model/BlockRepository.php
+++ b/app/code/Magento/Cms/Model/BlockRepository.php
@@ -154,25 +154,10 @@ public function getList(\Magento\Framework\Api\SearchCriteriaInterface $criteria
$this->collectionProcessor->process($criteria, $collection);
- $blocks = [];
- /** @var Block $blockModel */
- foreach ($collection as $blockModel) {
- $blockData = $this->dataBlockFactory->create();
- $this->dataObjectHelper->populateWithArray(
- $blockData,
- $blockModel->getData(),
- \Magento\Cms\Api\Data\BlockInterface::class
- );
- $blocks[] = $this->dataObjectProcessor->buildOutputDataArray(
- $blockData,
- \Magento\Cms\Api\Data\BlockInterface::class
- );
- }
-
/** @var Data\BlockSearchResultsInterface $searchResults */
$searchResults = $this->searchResultsFactory->create();
$searchResults->setSearchCriteria($criteria);
- $searchResults->setItems($blocks);
+ $searchResults->setItems($collection->getItems());
$searchResults->setTotalCount($collection->getSize());
return $searchResults;
}
diff --git a/app/code/Magento/Cms/Model/PageRepository.php b/app/code/Magento/Cms/Model/PageRepository.php
index 033289bf8fb8e..521a975c885dd 100644
--- a/app/code/Magento/Cms/Model/PageRepository.php
+++ b/app/code/Magento/Cms/Model/PageRepository.php
@@ -157,25 +157,10 @@ public function getList(\Magento\Framework\Api\SearchCriteriaInterface $criteria
$this->collectionProcessor->process($criteria, $collection);
- $pages = [];
- /** @var Page $pageModel */
- foreach ($collection as $pageModel) {
- $pageData = $this->dataPageFactory->create();
- $this->dataObjectHelper->populateWithArray(
- $pageData,
- $pageModel->getData(),
- \Magento\Cms\Api\Data\PageInterface::class
- );
- $pages[] = $this->dataObjectProcessor->buildOutputDataArray(
- $pageData,
- \Magento\Cms\Api\Data\PageInterface::class
- );
- }
-
/** @var Data\PageSearchResultsInterface $searchResults */
$searchResults = $this->searchResultsFactory->create();
$searchResults->setSearchCriteria($criteria);
- $searchResults->setItems($pages);
+ $searchResults->setItems($collection->getItems());
$searchResults->setTotalCount($collection->getSize());
return $searchResults;
}
diff --git a/app/code/Magento/Cms/Test/Unit/Model/BlockRepositoryTest.php b/app/code/Magento/Cms/Test/Unit/Model/BlockRepositoryTest.php
index dd43f4a0b2287..6e4440ef97b25 100644
--- a/app/code/Magento/Cms/Test/Unit/Model/BlockRepositoryTest.php
+++ b/app/code/Magento/Cms/Test/Unit/Model/BlockRepositoryTest.php
@@ -263,22 +263,8 @@ public function testGetList()
->willReturnSelf();
$this->blockSearchResult->expects($this->once())
->method('setItems')
- ->with(['someData'])
+ ->with([$this->block])
->willReturnSelf();
-
- $this->block->expects($this->once())
- ->method('getData')
- ->willReturn(['data']);
-
- $this->dataHelper->expects($this->once())
- ->method('populateWithArray')
- ->with($this->blockData, ['data'], \Magento\Cms\Api\Data\BlockInterface::class);
-
- $this->dataObjectProcessor->expects($this->once())
- ->method('buildOutputDataArray')
- ->with($this->blockData, \Magento\Cms\Api\Data\BlockInterface::class)
- ->willReturn('someData');
-
$this->assertEquals($this->blockSearchResult, $this->repository->getList($criteria));
}
}
diff --git a/app/code/Magento/Cms/Test/Unit/Model/PageRepositoryTest.php b/app/code/Magento/Cms/Test/Unit/Model/PageRepositoryTest.php
index 7d064c73b3259..1bd742048c51e 100644
--- a/app/code/Magento/Cms/Test/Unit/Model/PageRepositoryTest.php
+++ b/app/code/Magento/Cms/Test/Unit/Model/PageRepositoryTest.php
@@ -261,22 +261,8 @@ public function testGetList()
->willReturnSelf();
$this->pageSearchResult->expects($this->once())
->method('setItems')
- ->with(['someData'])
+ ->with([$this->page])
->willReturnSelf();
-
- $this->page->expects($this->once())
- ->method('getData')
- ->willReturn(['data']);
-
- $this->dataHelper->expects($this->once())
- ->method('populateWithArray')
- ->with($this->pageData, ['data'], \Magento\Cms\Api\Data\PageInterface::class);
-
- $this->dataObjectProcessor->expects($this->once())
- ->method('buildOutputDataArray')
- ->with($this->pageData, \Magento\Cms\Api\Data\PageInterface::class)
- ->willReturn('someData');
-
$this->assertEquals($this->pageSearchResult, $this->repository->getList($criteria));
}
}
diff --git a/app/code/Magento/Config/Model/Config/Backend/Image/Favicon.php b/app/code/Magento/Config/Model/Config/Backend/Image/Favicon.php
index 960853778d5f6..1412e0cd77c17 100644
--- a/app/code/Magento/Config/Model/Config/Backend/Image/Favicon.php
+++ b/app/code/Magento/Config/Model/Config/Backend/Image/Favicon.php
@@ -45,6 +45,6 @@ protected function _addWhetherScopeInfo()
*/
protected function _getAllowedExtensions()
{
- return ['ico', 'png', 'gif', 'jpg', 'jpeg', 'apng', 'svg'];
+ return ['ico', 'png', 'gif', 'jpg', 'jpeg', 'apng'];
}
}
diff --git a/app/code/Magento/Config/Model/Config/Backend/Image/Logo.php b/app/code/Magento/Config/Model/Config/Backend/Image/Logo.php
index 908ae53af0991..fc57287fb4945 100644
--- a/app/code/Magento/Config/Model/Config/Backend/Image/Logo.php
+++ b/app/code/Magento/Config/Model/Config/Backend/Image/Logo.php
@@ -45,6 +45,6 @@ protected function _addWhetherScopeInfo()
*/
protected function _getAllowedExtensions()
{
- return ['jpg', 'jpeg', 'gif', 'png', 'svg'];
+ return ['jpg', 'jpeg', 'gif', 'png'];
}
}
diff --git a/app/code/Magento/Config/Test/Unit/Model/Config/Backend/Image/LogoTest.php b/app/code/Magento/Config/Test/Unit/Model/Config/Backend/Image/LogoTest.php
index e68cff5d1280d..28f35c233b874 100644
--- a/app/code/Magento/Config/Test/Unit/Model/Config/Backend/Image/LogoTest.php
+++ b/app/code/Magento/Config/Test/Unit/Model/Config/Backend/Image/LogoTest.php
@@ -73,7 +73,7 @@ public function testBeforeSave()
->will($this->returnValue('/tmp/val'));
$this->uploaderMock->expects($this->once())
->method('setAllowedExtensions')
- ->with($this->equalTo(['jpg', 'jpeg', 'gif', 'png', 'svg']));
+ ->with($this->equalTo(['jpg', 'jpeg', 'gif', 'png']));
$this->model->beforeSave();
}
}
diff --git a/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php b/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php
index d1794aff97fb9..8f1324195b382 100644
--- a/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php
+++ b/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php
@@ -68,8 +68,8 @@ abstract class AbstractFrontend implements \Magento\Eav\Model\Entity\Attribute\F
* @param CacheInterface $cache
* @param $storeResolver @deprecated
* @param array $cacheTags
- * @param Serializer $serializer
* @param StoreManagerInterface $storeManager
+ * @param Serializer $serializer
* @codeCoverageIgnore
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
@@ -78,8 +78,8 @@ public function __construct(
CacheInterface $cache = null,
$storeResolver = null,
array $cacheTags = null,
- Serializer $serializer = null,
- StoreManagerInterface $storeManager = null
+ StoreManagerInterface $storeManager = null,
+ Serializer $serializer = null
) {
$this->_attrBooleanFactory = $attrBooleanFactory;
$this->cache = $cache ?: ObjectManager::getInstance()->get(CacheInterface::class);
diff --git a/app/code/Magento/Eav/Setup/EavSetup.php b/app/code/Magento/Eav/Setup/EavSetup.php
index 61146d7e38608..ced56f313dd7d 100644
--- a/app/code/Magento/Eav/Setup/EavSetup.php
+++ b/app/code/Magento/Eav/Setup/EavSetup.php
@@ -942,6 +942,7 @@ public function updateAttribute($entityTypeId, $id, $field, $value = null, $sort
* @param mixed $value
* @param int $sortOrder
* @return $this
+ * @throws LocalizedException
*/
private function _updateAttribute($entityTypeId, $id, $field, $value = null, $sortOrder = null)
{
@@ -972,11 +973,15 @@ private function _updateAttribute($entityTypeId, $id, $field, $value = null, $so
return $this;
}
}
+ $attributeId = $this->getAttributeId($entityTypeId, $id);
+ if (false === $attributeId) {
+ throw new LocalizedException(__('Attribute with ID: "%1" does not exist', $id));
+ }
$this->setup->updateTableRow(
'eav_attribute',
'attribute_id',
- $this->getAttributeId($entityTypeId, $id),
+ $attributeId,
$field,
$value,
'entity_type_id',
@@ -994,6 +999,7 @@ private function _updateAttribute($entityTypeId, $id, $field, $value = null, $so
* @param string|array $field
* @param mixed $value
* @return $this
+ * @throws LocalizedException
*/
private function _updateAttributeAdditionalData($entityTypeId, $id, $field, $value = null)
{
@@ -1022,6 +1028,11 @@ private function _updateAttributeAdditionalData($entityTypeId, $id, $field, $val
return $this;
}
}
+
+ $attributeId = $this->getAttributeId($entityTypeId, $id);
+ if (false === $attributeId) {
+ throw new LocalizedException(__('Attribute with ID: "%1" does not exist', $id));
+ }
$this->setup->updateTableRow(
$this->setup->getTable($additionalTable),
'attribute_id',
diff --git a/app/code/Magento/Email/view/adminhtml/ui_component/design_config_form.xml b/app/code/Magento/Email/view/adminhtml/ui_component/design_config_form.xml
index 403abb6fdcade..b63f79233383a 100644
--- a/app/code/Magento/Email/view/adminhtml/ui_component/design_config_form.xml
+++ b/app/code/Magento/Email/view/adminhtml/ui_component/design_config_form.xml
@@ -22,7 +22,7 @@
- jpg jpeg gif png svg
+ jpg jpeg gif png
2097152
theme/design_config_fileUploader/save
diff --git a/app/code/Magento/GiftMessage/i18n/en_US.csv b/app/code/Magento/GiftMessage/i18n/en_US.csv
index 5c82c8e5aeb81..bac6989bd01ae 100644
--- a/app/code/Magento/GiftMessage/i18n/en_US.csv
+++ b/app/code/Magento/GiftMessage/i18n/en_US.csv
@@ -22,7 +22,7 @@ OK,OK
"Gift Options","Gift Options"
"Gift Message","Gift Message"
"Do you have any gift items in your order?","Do you have any gift items in your order?"
-"Add gift options","Add gift options"
+"Add Gift Options","Add Gift Options"
"Gift Options for the Entire Order","Gift Options for the Entire Order"
"Leave this box blank if you don\'t want to leave a gift message for the entire order.","Leave this box blank if you don\'t want to leave a gift message for the entire order."
"Gift Options for Individual Items","Gift Options for Individual Items"
@@ -30,14 +30,14 @@ OK,OK
"Leave a box blank if you don\'t want to add a gift message for that item.","Leave a box blank if you don\'t want to add a gift message for that item."
"Add Gift Options for the Entire Order","Add Gift Options for the Entire Order"
"You can leave this box blank if you don\'t want to add a gift message for this address.","You can leave this box blank if you don\'t want to add a gift message for this address."
-"Add gift options for Individual Items","Add gift options for Individual Items"
+"Add Gift Options for Individual Items","Add Gift Options for Individual Items"
"You can leave this box blank if you don\'t want to add a gift message for the item.","You can leave this box blank if you don\'t want to add a gift message for the item."
"Gift Message (optional)","Gift Message (optional)"
To:,To:
From:,From:
Message:,Message:
Update,Update
-"Gift options","Gift options"
+"Gift Options","Gift Options"
Edit,Edit
Delete,Delete
"Allow Gift Messages on Order Level","Allow Gift Messages on Order Level"
diff --git a/app/code/Magento/GiftMessage/view/frontend/templates/inline.phtml b/app/code/Magento/GiftMessage/view/frontend/templates/inline.phtml
index 8fbb6918d7119..6155cfc37c4ad 100644
--- a/app/code/Magento/GiftMessage/view/frontend/templates/inline.phtml
+++ b/app/code/Magento/GiftMessage/view/frontend/templates/inline.phtml
@@ -14,7 +14,7 @@
getItemsHasMesssages() || $block->getEntityHasMessage()): ?> checked="checked" class="checkbox" />
-
+
@@ -148,7 +148,7 @@
getItemsHasMesssages() || $block->getEntityHasMessage()): ?> checked="checked" class="checkbox" />
-
+
@@ -197,7 +197,7 @@
-
getItemsHasMesssages()): ?> checked="checked" class="checkbox" />
-
+
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/View/Info.php b/app/code/Magento/Sales/Block/Adminhtml/Order/View/Info.php
index a86d33a9ad762..0ff22646e1935 100644
--- a/app/code/Magento/Sales/Block/Adminhtml/Order/View/Info.php
+++ b/app/code/Magento/Sales/Block/Adminhtml/Order/View/Info.php
@@ -303,4 +303,26 @@ public function getFormattedAddress(Address $address)
{
return $this->addressRenderer->format($address, 'html');
}
+
+ /**
+ * @inheritdoc
+ */
+ public function getChildHtml($alias = '', $useCache = true)
+ {
+ $layout = $this->getLayout();
+
+ if ($alias || !$layout) {
+ return parent::getChildHtml($alias, $useCache);
+ }
+
+ $childNames = $layout->getChildNames($this->getNameInLayout());
+ $outputChildNames = array_diff($childNames, ['extra_customer_info']);
+
+ $out = '';
+ foreach ($outputChildNames as $childName) {
+ $out .= $layout->renderElement($childName, $useCache);
+ }
+
+ return $out;
+ }
}
diff --git a/app/code/Magento/SendFriend/view/frontend/layout/sendfriend_product_send.xml b/app/code/Magento/SendFriend/view/frontend/layout/sendfriend_product_send.xml
index 2d404cb96f97f..8065b7e236132 100644
--- a/app/code/Magento/SendFriend/view/frontend/layout/sendfriend_product_send.xml
+++ b/app/code/Magento/SendFriend/view/frontend/layout/sendfriend_product_send.xml
@@ -13,7 +13,9 @@
-
+
+
+