From 81564c91a5b110fbaa634e45f6b7b27b98198bae Mon Sep 17 00:00:00 2001 From: Dan Mooney Date: Mon, 17 Dec 2018 12:56:48 -0600 Subject: [PATCH 01/20] MC-5373: Product couldn't be pulled to CMS Page when it was assigned to a specific website Set store_id to 0 to allow for store-agnostic product conditions --- app/code/Magento/CatalogWidget/Block/Product/ProductsList.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/CatalogWidget/Block/Product/ProductsList.php b/app/code/Magento/CatalogWidget/Block/Product/ProductsList.php index 2b95de24d0201..fa3b0ca03d42c 100644 --- a/app/code/Magento/CatalogWidget/Block/Product/ProductsList.php +++ b/app/code/Magento/CatalogWidget/Block/Product/ProductsList.php @@ -250,7 +250,7 @@ public function createCollection() $collection->setVisibility($this->catalogProductVisibility->getVisibleInCatalogIds()); $collection = $this->_addProductAttributesAndPrices($collection) - ->addStoreFilter() + ->addStoreFilter($this->getData('store_id')) ->setPageSize($this->getPageSize()) ->setCurPage($this->getRequest()->getParam($this->getData('page_var_name'), 1)); From d72f2b9da2c8d759d2531a5ec100640af442bb6e Mon Sep 17 00:00:00 2001 From: Dan Mooney Date: Tue, 18 Dec 2018 13:39:11 -0600 Subject: [PATCH 02/20] MC-5373: Product couldn't be pulled to CMS Page when it was assigned to a specific website Remove temporal coupling by immediately setting store_id first on collection if it is available --- .../Magento/CatalogWidget/Block/Product/ProductsList.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/code/Magento/CatalogWidget/Block/Product/ProductsList.php b/app/code/Magento/CatalogWidget/Block/Product/ProductsList.php index fa3b0ca03d42c..33cd204ced376 100644 --- a/app/code/Magento/CatalogWidget/Block/Product/ProductsList.php +++ b/app/code/Magento/CatalogWidget/Block/Product/ProductsList.php @@ -247,10 +247,15 @@ public function createCollection() { /** @var $collection \Magento\Catalog\Model\ResourceModel\Product\Collection */ $collection = $this->productCollectionFactory->create(); + + if ($this->getData('store_id') !== null) { + $collection->setStoreId($this->getData('store_id')); + } + $collection->setVisibility($this->catalogProductVisibility->getVisibleInCatalogIds()); $collection = $this->_addProductAttributesAndPrices($collection) - ->addStoreFilter($this->getData('store_id')) + ->addStoreFilter() ->setPageSize($this->getPageSize()) ->setCurPage($this->getRequest()->getParam($this->getData('page_var_name'), 1)); From f17f20eaa640c86cf85aff1b51fa8ca6eb671633 Mon Sep 17 00:00:00 2001 From: Dan Mooney Date: Wed, 19 Dec 2018 12:49:36 -0600 Subject: [PATCH 03/20] MC-5373: Product couldn't be pulled to CMS Page when it was assigned to a specific website Increase timeout for interaction with AdminStoresGridSection.storeFilterTextField --- .../Magento/Store/Test/Mftf/Section/AdminStoresGridSection.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Store/Test/Mftf/Section/AdminStoresGridSection.xml b/app/code/Magento/Store/Test/Mftf/Section/AdminStoresGridSection.xml index 04cbeb5bc596e..27ef308856d60 100644 --- a/app/code/Magento/Store/Test/Mftf/Section/AdminStoresGridSection.xml +++ b/app/code/Magento/Store/Test/Mftf/Section/AdminStoresGridSection.xml @@ -14,7 +14,7 @@
- + From 0547b62904f2a848c5fd5d0ffe5a46b0af5beab5 Mon Sep 17 00:00:00 2001 From: Dan Mooney Date: Wed, 16 Jan 2019 13:33:51 -0600 Subject: [PATCH 04/20] MC-5373: Product couldn't be pulled to CMS Page when it was assigned to a specific website Support all store views for widgets contained within block --- app/code/Magento/Cms/Block/Widget/Block.php | 2 +- app/code/Magento/Widget/Model/Template/Filter.php | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/app/code/Magento/Cms/Block/Widget/Block.php b/app/code/Magento/Cms/Block/Widget/Block.php index aa6aeaff4ecbe..c665f2afc5d38 100644 --- a/app/code/Magento/Cms/Block/Widget/Block.php +++ b/app/code/Magento/Cms/Block/Widget/Block.php @@ -83,7 +83,7 @@ protected function _beforeToHtml() if ($block && $block->isActive()) { try { - $storeId = $this->_storeManager->getStore()->getId(); + $storeId = $this->getData('store_id') ?? $this->_storeManager->getStore()->getId(); $this->setText( $this->_filterProvider->getBlockFilter()->setStoreId($storeId)->filter($block->getContent()) ); diff --git a/app/code/Magento/Widget/Model/Template/Filter.php b/app/code/Magento/Widget/Model/Template/Filter.php index 7c3e8e467e038..c79334f67a9c3 100644 --- a/app/code/Magento/Widget/Model/Template/Filter.php +++ b/app/code/Magento/Widget/Model/Template/Filter.php @@ -91,6 +91,10 @@ public function generateWidget($construction) $name = $params['name']; } + if (isset($this->_storeId) && !isset($params['store_id'])) { + $params['store_id'] = $this->_storeId; + } + // validate required parameter type or id if (!empty($params['type'])) { $type = $params['type']; From 32458b72a1fa57c9f0684dd32aa441d162d064e1 Mon Sep 17 00:00:00 2001 From: Dan Mooney Date: Thu, 24 Jan 2019 15:12:42 -0600 Subject: [PATCH 05/20] MC-5373: Product couldn't be pulled to CMS Page when it was assigned to a specific website Upgrade AdminCreateStoreViewActionGroup --- .../Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml b/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml index 6cbbb7ae22014..a796eca53d38e 100644 --- a/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml +++ b/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml @@ -15,6 +15,7 @@ + @@ -22,9 +23,11 @@ - - - + + + + + From 1142c6acf384c997d09483d73ac64d5106f2498b Mon Sep 17 00:00:00 2001 From: Dan Mooney Date: Tue, 29 Jan 2019 11:53:14 -0600 Subject: [PATCH 06/20] MC-5373: Product couldn't be pulled to CMS Page when it was assigned to a specific website Revert some of AdminCreateStoreViewActionGroup success assertions since some tests expect failure --- .../Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml b/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml index a796eca53d38e..d23318a068b5a 100644 --- a/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml +++ b/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml @@ -25,9 +25,7 @@ - - - + From 51dedc630af3dcdf6c30037aee78e1491bcc25ac Mon Sep 17 00:00:00 2001 From: Dan Mooney Date: Tue, 29 Jan 2019 13:51:18 -0600 Subject: [PATCH 07/20] MC-5373: Product couldn't be pulled to CMS Page when it was assigned to a specific website Add waitForPageLoad to AdminCreateStoreViewActionGroup --- .../Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml b/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml index d23318a068b5a..17f15a40d4e46 100644 --- a/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml +++ b/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml @@ -25,6 +25,7 @@ + From ec3b13e1ac5ce6389b19ce74c459a712eb810fd9 Mon Sep 17 00:00:00 2001 From: Dan Mooney Date: Tue, 29 Jan 2019 14:33:12 -0600 Subject: [PATCH 08/20] MC-5373: Product couldn't be pulled to CMS Page when it was assigned to a specific website Improve saveProductForm and SelectProductInWebsitesActionGroup action groups --- .../Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml index 28587e6405e49..336c3a015713f 100644 --- a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml +++ b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml @@ -71,7 +71,9 @@ + + @@ -258,7 +260,7 @@ - + From bf223e083d425454986d472e6e278838146c553d Mon Sep 17 00:00:00 2001 From: Dan Mooney Date: Tue, 29 Jan 2019 14:43:54 -0600 Subject: [PATCH 09/20] MC-5373: Product couldn't be pulled to CMS Page when it was assigned to a specific website Fix duplicate stepkey --- .../Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml index 336c3a015713f..5e1b419f009ad 100644 --- a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml +++ b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml @@ -71,7 +71,7 @@ - + From 4e49f06ae44111c660fe7ec9d9881c2a2d7c89b1 Mon Sep 17 00:00:00 2001 From: Dan Mooney Date: Wed, 30 Jan 2019 15:47:34 -0600 Subject: [PATCH 10/20] MC-5373: Product couldn't be pulled to CMS Page when it was assigned to a specific website Add/use saveAndContinuePageWithSplitButton --- .../Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml b/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml index 75e059f620c2d..35d81b224e587 100644 --- a/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml +++ b/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml @@ -44,4 +44,10 @@ + + + + + + From 6216e1af806f831be90af19959881a01a11eafd1 Mon Sep 17 00:00:00 2001 From: Dan Mooney Date: Wed, 30 Jan 2019 18:05:41 -0600 Subject: [PATCH 11/20] MC-5373: Product couldn't be pulled to CMS Page when it was assigned to a specific website Add missing stepKey --- app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml b/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml index 35d81b224e587..dbcc908fc7606 100644 --- a/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml +++ b/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml @@ -45,7 +45,7 @@ - + From 7b868c42f04fa892c8e5afb146fb7695ed459e38 Mon Sep 17 00:00:00 2001 From: Dan Mooney Date: Thu, 31 Jan 2019 13:12:42 -0600 Subject: [PATCH 12/20] MC-5373: Product couldn't be pulled to CMS Page when it was assigned to a specific website Update tests based on review feedback --- app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml b/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml index dbcc908fc7606..a186da2ec4052 100644 --- a/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml +++ b/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml @@ -49,5 +49,6 @@ + From 74157c6fef75e265b064a9e1f67645e6910c7ad7 Mon Sep 17 00:00:00 2001 From: Dan Mooney Date: Thu, 31 Jan 2019 13:18:46 -0600 Subject: [PATCH 13/20] MC-5373: Product couldn't be pulled to CMS Page when it was assigned to a specific website Rename saveAndContinuePageWithSplitButton to saveAndCloseCMSBlockWithSplitButton --- app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml b/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml index a186da2ec4052..b03010ab2a2df 100644 --- a/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml +++ b/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml @@ -44,7 +44,7 @@ - + From 41c6d66e15865ac165d0645cd3143b5a8b4d4c3c Mon Sep 17 00:00:00 2001 From: Dave Macaulay Date: Tue, 5 Feb 2019 12:22:01 +0100 Subject: [PATCH 14/20] MC-5373: Product couldn't be pulled to CMS Page when it was assigned to a specific website - Move navigateToStorefrontForCreatedPage into CE --- .../Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml b/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml index 9310e341b8f82..a4ea60a41e871 100644 --- a/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml +++ b/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml @@ -54,7 +54,6 @@ - @@ -77,4 +76,11 @@ + + + + + + + From 8704f0e7c5c386f6926e72a97bc4169034ed3c1b Mon Sep 17 00:00:00 2001 From: Dave Macaulay Date: Tue, 5 Feb 2019 13:16:13 +0100 Subject: [PATCH 15/20] MC-13728: Move MFTF Content From PageBuilder to CE/EE That Does Not Belong in PageBuilder - Move action groups, section and data from Page Builder into core modules --- .../ActionGroup/AdminProductActionGroup.xml | 43 +++++++++++++++++++ .../AdminProductAttributeActionGroup.xml | 17 ++++++++ .../AdminProductGridActionGroup.xml | 11 +++++ .../Test/Mftf/Data/ProductAttributeData.xml | 23 ++++++++++ .../Mftf/Data/ProductAttributeSetData.xml | 6 +++ .../Catalog/Test/Mftf/Data/ProductData.xml | 9 ++++ .../AdminEditProductAttributesSection.xml | 2 + ...inProductRelatedUpSellCrossSellSection.xml | 5 +++ .../Test/Mftf/ActionGroup/CMSActionGroup.xml | 40 ++++++++++++++++- .../Cms/Test/Mftf/Data/CmsPageData.xml | 9 ++++ .../Cms/Test/Mftf/Section/TinyMCESection.xml | 2 + .../Test/Mftf/Section/GeneralSection.xml | 1 + .../AdminCreateStoreViewActionGroup.xml | 23 ++++++++++ 13 files changed, 190 insertions(+), 1 deletion(-) diff --git a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml index 28587e6405e49..2b8c1e14dd50a 100644 --- a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml +++ b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml @@ -328,4 +328,47 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductAttributeActionGroup.xml b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductAttributeActionGroup.xml index 8f8a86ac5adf1..38ceead527e6e 100644 --- a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductAttributeActionGroup.xml +++ b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductAttributeActionGroup.xml @@ -63,4 +63,21 @@ + + + + + + + + + + + + + + + + + diff --git a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductGridActionGroup.xml b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductGridActionGroup.xml index 817da18f5f2b7..0817d12e3e218 100644 --- a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductGridActionGroup.xml +++ b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductGridActionGroup.xml @@ -248,4 +248,15 @@ + + + + + + + + + + + diff --git a/app/code/Magento/Catalog/Test/Mftf/Data/ProductAttributeData.xml b/app/code/Magento/Catalog/Test/Mftf/Data/ProductAttributeData.xml index b367cdcab9d8b..03a004e500aef 100644 --- a/app/code/Magento/Catalog/Test/Mftf/Data/ProductAttributeData.xml +++ b/app/code/Magento/Catalog/Test/Mftf/Data/ProductAttributeData.xml @@ -115,4 +115,27 @@ true ProductAttributeFrontendLabel + + attribute + text + global + false + false + false + true + text + false + false + true + false + false + false + false + true + false + false + false + false + ProductAttributeFrontendLabel + diff --git a/app/code/Magento/Catalog/Test/Mftf/Data/ProductAttributeSetData.xml b/app/code/Magento/Catalog/Test/Mftf/Data/ProductAttributeSetData.xml index 68f51559a9f31..713c453bb7ad4 100644 --- a/app/code/Magento/Catalog/Test/Mftf/Data/ProductAttributeSetData.xml +++ b/app/code/Magento/Catalog/Test/Mftf/Data/ProductAttributeSetData.xml @@ -14,4 +14,10 @@ 7 0 + + + 4 + 7 + 1 + diff --git a/app/code/Magento/Catalog/Test/Mftf/Data/ProductData.xml b/app/code/Magento/Catalog/Test/Mftf/Data/ProductData.xml index b6442a1af3ff7..2d11c48aad341 100644 --- a/app/code/Magento/Catalog/Test/Mftf/Data/ProductData.xml +++ b/app/code/Magento/Catalog/Test/Mftf/Data/ProductData.xml @@ -519,4 +519,13 @@ magento3 jpg + + short_description + + + + 4 + 13 + 0 + diff --git a/app/code/Magento/Catalog/Test/Mftf/Section/AdminEditProductAttributesSection.xml b/app/code/Magento/Catalog/Test/Mftf/Section/AdminEditProductAttributesSection.xml index 5df17cb4f5a42..63bdcd52cdd20 100644 --- a/app/code/Magento/Catalog/Test/Mftf/Section/AdminEditProductAttributesSection.xml +++ b/app/code/Magento/Catalog/Test/Mftf/Section/AdminEditProductAttributesSection.xml @@ -18,6 +18,8 @@ + +
diff --git a/app/code/Magento/Catalog/Test/Mftf/Section/AdminProductRelatedUpSellCrossSellSection.xml b/app/code/Magento/Catalog/Test/Mftf/Section/AdminProductRelatedUpSellCrossSellSection.xml index e90d806805f7c..be046955a66a5 100644 --- a/app/code/Magento/Catalog/Test/Mftf/Section/AdminProductRelatedUpSellCrossSellSection.xml +++ b/app/code/Magento/Catalog/Test/Mftf/Section/AdminProductRelatedUpSellCrossSellSection.xml @@ -10,6 +10,7 @@ xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
+ @@ -18,4 +19,8 @@
+
+ + +
diff --git a/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml b/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml index e7379d3c7336f..676dd899c6f09 100644 --- a/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml +++ b/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml @@ -54,7 +54,6 @@ - @@ -70,4 +69,43 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/app/code/Magento/Cms/Test/Mftf/Data/CmsPageData.xml b/app/code/Magento/Cms/Test/Mftf/Data/CmsPageData.xml index d8a8401c31f15..2ec2eccba2344 100644 --- a/app/code/Magento/Cms/Test/Mftf/Data/CmsPageData.xml +++ b/app/code/Magento/Cms/Test/Mftf/Data/CmsPageData.xml @@ -86,4 +86,13 @@ 1<br/>2<br/>3<br/>4<br/>5<br/>6<br/>7<br/>8<br/>9<br/>10<br/>11<br/>12<br/>13<br/>14<br/>15<br/>16<br/>17<br/>18<br/>19<br/>20<br/>line21<br/>22<br/>23<br/>24<br/>25<br/>26<br/>line27<br/>2<br/>3<br/>4<br/>5 test-page- + + Test CMS Page + test-page- + + + Test CMS Block + block + true + diff --git a/app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection.xml b/app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection.xml index 89431a0c7ce4d..106a878f29ecf 100644 --- a/app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection.xml +++ b/app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection.xml @@ -111,5 +111,7 @@ + + diff --git a/app/code/Magento/Config/Test/Mftf/Section/GeneralSection.xml b/app/code/Magento/Config/Test/Mftf/Section/GeneralSection.xml index 66b40f74d8e98..d007c860782aa 100644 --- a/app/code/Magento/Config/Test/Mftf/Section/GeneralSection.xml +++ b/app/code/Magento/Config/Test/Mftf/Section/GeneralSection.xml @@ -17,6 +17,7 @@ +
diff --git a/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml b/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml index 6cbbb7ae22014..e644e96047627 100644 --- a/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml +++ b/app/code/Magento/Store/Test/Mftf/ActionGroup/AdminCreateStoreViewActionGroup.xml @@ -37,4 +37,27 @@ + + + + + + + + + + + + + + + + + + + + + + + From 53a77068abf819196adb1eceede30e43b7786c93 Mon Sep 17 00:00:00 2001 From: Dan Mooney Date: Wed, 6 Feb 2019 13:14:03 -0600 Subject: [PATCH 16/20] MC-5373: Product couldn't be pulled to CMS Page when it was assigned to a specific website Stabilize AdminReviewOrderWithOnlyReportsPermissionTest - Clear filters before attempting to click on product - WaitForPageLoad after clicking on user in user table list --- .../Test/Mftf/ActionGroup/AdminDeleteCreatedUserActionGroup.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/app/code/Magento/User/Test/Mftf/ActionGroup/AdminDeleteCreatedUserActionGroup.xml b/app/code/Magento/User/Test/Mftf/ActionGroup/AdminDeleteCreatedUserActionGroup.xml index 7f1ed3be1ca57..74124f366a54b 100644 --- a/app/code/Magento/User/Test/Mftf/ActionGroup/AdminDeleteCreatedUserActionGroup.xml +++ b/app/code/Magento/User/Test/Mftf/ActionGroup/AdminDeleteCreatedUserActionGroup.xml @@ -13,6 +13,7 @@ + From 7069fac027be80d4a5841b798ba9ff3bdca1ed81 Mon Sep 17 00:00:00 2001 From: Dan Mooney Date: Wed, 6 Feb 2019 17:15:56 -0600 Subject: [PATCH 17/20] MC-5373: Product couldn't be pulled to CMS Page when it was assigned to a specific website Delete Storeview in AdminCreateStoreViewTest --- .../Magento/Store/Test/Mftf/Test/AdminCreateStoreViewTest.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/code/Magento/Store/Test/Mftf/Test/AdminCreateStoreViewTest.xml b/app/code/Magento/Store/Test/Mftf/Test/AdminCreateStoreViewTest.xml index e7a3d03f337db..af8aceed07f0f 100644 --- a/app/code/Magento/Store/Test/Mftf/Test/AdminCreateStoreViewTest.xml +++ b/app/code/Magento/Store/Test/Mftf/Test/AdminCreateStoreViewTest.xml @@ -33,6 +33,9 @@ + + + From 0b45ef124ca3f7a200c99ea580c1e4b3a9cc3e91 Mon Sep 17 00:00:00 2001 From: Dave Macaulay Date: Thu, 7 Feb 2019 14:13:41 +0100 Subject: [PATCH 18/20] MC-13728: Move MFTF Content From PageBuilder to CE/EE That Does Not Belong in PageBuilder - Remove duplicate action group - Import navigateToStoreFrontWithStoreView --- .../Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml b/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml index d38134b3b2fd3..03d638dcab658 100644 --- a/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml +++ b/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml @@ -83,12 +83,13 @@ - + - + + - - + + From b0712a0fa8ca363d9aece843c97b2566dce62986 Mon Sep 17 00:00:00 2001 From: Dave Macaulay Date: Thu, 7 Feb 2019 16:20:21 +0100 Subject: [PATCH 19/20] MC-13728: Move MFTF Content From PageBuilder to CE/EE That Does Not Belong in PageBuilder - Remove hardcoded selectors in actiongroup - Move PageBuilder action group back to Page Builder --- .../Test/Mftf/ActionGroup/AdminProductActionGroup.xml | 4 ++-- .../Test/Mftf/Section/AdminProductContentSection.xml | 1 + .../Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml | 8 -------- app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection.xml | 2 +- 4 files changed, 4 insertions(+), 11 deletions(-) diff --git a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml index c4c7f709ab91f..dc0297d4d4986 100644 --- a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml +++ b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductActionGroup.xml @@ -260,7 +260,7 @@ - + @@ -333,7 +333,7 @@ - + diff --git a/app/code/Magento/Catalog/Test/Mftf/Section/AdminProductContentSection.xml b/app/code/Magento/Catalog/Test/Mftf/Section/AdminProductContentSection.xml index 784eff12a6c04..fafae5d535546 100644 --- a/app/code/Magento/Catalog/Test/Mftf/Section/AdminProductContentSection.xml +++ b/app/code/Magento/Catalog/Test/Mftf/Section/AdminProductContentSection.xml @@ -10,6 +10,7 @@ xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
+ diff --git a/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml b/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml index 03d638dcab658..07e43347d9ddd 100644 --- a/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml +++ b/app/code/Magento/Cms/Test/Mftf/ActionGroup/CMSActionGroup.xml @@ -83,14 +83,6 @@ - - - - - - - - diff --git a/app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection.xml b/app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection.xml index 106a878f29ecf..406090e3dc7f6 100644 --- a/app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection.xml +++ b/app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection.xml @@ -112,6 +112,6 @@ - +
From fbebd82318de822644996db4fd2cf787310a55e7 Mon Sep 17 00:00:00 2001 From: Dan Mooney Date: Thu, 7 Feb 2019 13:45:14 -0600 Subject: [PATCH 20/20] MC-13728: Move MFTF Content From PageBuilder to CE/EE That Does Not Belong in PageBuilder Address feedback - Change naming of arg1 to filterName --- app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection.xml b/app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection.xml index 406090e3dc7f6..8559334238d2f 100644 --- a/app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection.xml +++ b/app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection.xml @@ -112,6 +112,6 @@ - +