Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A space between the category page and the main footer when applying specific settings #12601

Closed
wd7080 opened this issue Dec 8, 2017 · 11 comments
Assignees
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@wd7080
Copy link

wd7080 commented Dec 8, 2017

Preconditions

  1. Magento 2.2.1

Steps to reproduce

  1. Go to Content -> Blocks
  2. Add new block
  3. Block information:
    a. Enable block -> Yes
    b. Block title: Contact Us menu
    c. Identifier: contactusmenu
    d. Store View: All Store Views
    e. I am trying to create a contact us form on a cetegory page. I added the following content to the static block editor:
    <p>{{block class="Magento\Contact\Block\ContactForm" template="Magento_Contact::form.phtml"}}</p>
<hr />
<p style="text-align: justify;">Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.</p>
  1. Now go to Catalog -> Categories
  2. Select the Default Category then -> Click on Add Subcategory
  3. Category settings are as follows:
    a. Enable Category -> Yes
    b. Include in Menu -> Yes
    c. Category name -> Contac Us
    d. Content -> Add CMS Block -> Contact Us Menu
    e. Display Settings -> Display Mode -> Static block only
    f. Display Settings -> Anchor -> No
    g. Search engine optimization -> URL Key -> Contact
    h. Design -> Use Parent Category Settings -> No
    i. Design ->Theme -> Magento Luma
    j. Design ->layout -> 1 column
    k. Design ->layout update XML -> Empty
    l. Design ->apply design to the products -> No
    M. Click Save.

Expected result

  1. You can view the contact us page in the menu

Actual result

  1. There is a space between the content and the footer. See the image below.
    magento 2 column

  2. The HTML content of this column is:

<div class="column main"><input name="form_key" type="hidden" value="sEXSrkYUlSkpqe2v"><div id="authenticationPopup" data-bind="scope:'authenticationPopup'" style="display: none;">
    <script>
        window.authenticationPopup = {"autocomplete":"off","customerRegisterUrl":"http:\/\/domain.com\/customer\/account\/create\/","customerForgotPasswordUrl":"http:\/\/domain.com\/customer\/account\/forgotpassword\/","baseUrl":"http:\/\/domain.com\/"};
    </script>
    <!-- ko template: getTemplate() -->
<!-- /ko -->
</div>
  1. After the settings I've applied to the category page, this column must be hidden with zero space.
  2. Complete image to the page:
    bug
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Dec 8, 2017
@wd7080
Copy link
Author

wd7080 commented Dec 9, 2017

@magento-engcom-team were you able to reproduce this? Do you need an update?

@wd7080
Copy link
Author

wd7080 commented Dec 9, 2017

Guys, this is really a bug, the main column does not get hidden. Just look into this, please.

@wd7080
Copy link
Author

wd7080 commented Dec 10, 2017

Any update on this bug?

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 11, 2017
@magento-engcom-team
Copy link
Contributor

@wd7080, thank you for your report.
We've created internal ticket(s) MAGETWO-85276 to track progress on the issue.

@sanjay-wagento
Copy link
Contributor

Hi @magento-engcom-team, @okorshenko
I investigated this issue and working on it.
Please assign to me.
Thanks!

@magento-team
Copy link
Contributor

Hi @wd7080. Thank you for your report.
The issue has been fixed in #13026 by @sanjay-wagento in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 9, 2018
@okorshenko
Copy link
Contributor

Hi @wd7080. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1325 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@okorshenko okorshenko added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 2, 2018
@wd7080
Copy link
Author

wd7080 commented Mar 1, 2018

Hello
This has not yet been fixed in 2.3.0. I still have the same problem. I really waited for so long for this update to fix this problem. Disappointed!

@magento-engcom-team
Copy link
Contributor

Hi @wd7080. Thank you for your report.
The issue has been fixed in #15726 by @sanjay-wagento in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@sidolov
Copy link
Contributor

sidolov commented Jun 21, 2018

Hi @wd7080. Thank you for your report.
The issue has been fixed in #15727 by @sanjay-wagento in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jun 21, 2018
@philgschmidt
Copy link

Still seeing this problem in 2.3.3
What am I missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

8 participants