Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method getUrl in Magento\Catalog\Model\Product\Attribute\Frontend returns image url with double slash #13497

Closed
igortregub opened this issue Feb 5, 2018 · 2 comments
Closed

Method getUrl in Magento\Catalog\Model\Product\Attribute\Frontend returns image url with double slash #13497

igortregub opened this issue Feb 5, 2018 · 2 comments
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@igortregub
Copy link

igortregub commented Feb 5, 2018 •
edited
Loading

Preconditions

  1. Magento 2.2.2

Steps to reproduce

  1. Try to get product image via method getUrl from class Magento\Catalog\Model\Product\Attribute\Frontend

Expected result

  1. returns image url without double slash

Actual result

  1. will be returned image with double slash
    screen shot 2018-02-05 at 12 37 04 pm 2018-02-05 13-25-55

I think it happens because images have in method getUrl variable $image image path starts from slash.
I here is sample how issue could be fixed: #13498
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Feb 5, 2018
@magento-engcom-team
Copy link
Contributor

@igortregub, thank you for your report.
We've acknowledged the issue and added to our backlog.

magento-team pushed a commit that referenced this issue Feb 6, 2018
@orlangur
MAGETWO-87477: issue #13497 - Method getUrl in Magento\Catalog\Model\…
ca296c6 
…Product\Attribu… #13498

 - Merge Pull Request #13498 from igortregub/magento2:fix-double-slash-in-getUrl
 - Merged commits:
   1. 220ad97
magento-team pushed a commit that referenced this issue Feb 6, 2018
MAGETWO-87477: issue #13497 - Method getUrl in Magento\Catalog\Model\…
e3f5953 
…Product\Attribu… #13498
magento-team pushed a commit that referenced this issue Feb 6, 2018
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.2-develop
f18377b 
Accepted Public Pull Requests:
 - #13498: issue #13497 - Method getUrl in Magento\Catalog\Model\Product\Attribu� (by @igortregub)
 - #13494: Fixing of Problem with updating stock item qty and stock status (by @nuzil)
 - #13132: Update the Emogrifier dependency to ^2.0.0 (by @oliverklee)
thomasdom pushed a commit to thomasdom/magento2 that referenced this issue Feb 7, 2018
@magento-engcom-team @thomasdom
🔃 [EngCom] Public Pull Requests - 2.2-develop
5373508 
Accepted Public Pull Requests:
 - magento#13498: issue magento#13497 - Method getUrl in Magento\Catalog\Model\Product\Attribu� (by @igortregub)
 - magento#13494: Fixing of Problem with updating stock item qty and stock status (by @nuzil)
 - magento#13132: Update the Emogrifier dependency to ^2.0.0 (by @oliverklee)

Fixed store view switcher issues when changing store view on product and category pages.
@ihor-sviziev ihor-sviziev added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Feb 16, 2018
@igortregub igortregub mentioned this issue Feb 16, 2018
Merged
@nmalevanec nmalevanec mentioned this issue Feb 16, 2018
Merged
4 tasks
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Feb 16, 2018 •
edited
Loading

Hi @igortregub. Thank you for your report.
The issue has been fixed in #13498 by @igortregub in 2.2-develop branch

Related commit(s):

The fix will be available with the upcoming 2.2.4 release.

magento-engcom-team added a commit that referenced this issue Feb 21, 2018
@magento-engcom-team
MAGETWO-87979: [Forwardport] #13498 issue #13497 - Method getUrl in M…
0297bcb 
…agento\Catalog\Model\Product\Attribute\Frontend\Image #13635

 - Merge Pull Request #13635 from nmalevanec/magento2:forwardport-pull-13498
 - Merged commits:
   1. 8a2e547
magento-engcom-team pushed a commit that referenced this issue Feb 21, 2018
MAGETWO-87979: [Forwardport] #13498 issue #13497 - Method getUrl in M…
6f2282a 
…agento\Catalog\Model\Product\Attribute\Frontend\Image #13635
magento-engcom-team added a commit that referenced this issue Feb 21, 2018
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.3-develop
74a70a0 
Accepted Public Pull Requests:
 - #13735: [Forwardport] Fix adding values to system variable collection (by @nmalevanec)
 - #13733: [Forwardport] Refactoring: remove unuseful temporary variable (by @nmalevanec)
 - #13731: [Forwardport] Display a more meaningful error message in case of misspelt module name (by @nmalevanec)
 - #13727: [Forwardport] Show maintenance IP-address without commas (by @nmalevanec)
 - #13729: [Forwardport] Update StorageInterface.php (by @nmalevanec)
 - #13635: [Forwardport] #13498 issue #13497 - Method getUrl in Magento\Catalog\Model\Product\Attribute\Frontend\Image (by @nmalevanec)
 - #13686: #13685: Replaced .size() with .length to be compatible with jQuery 3.* (by @kirmorozov)
 - magento-engcom/magento2ce#1203: Report error csv doesn't work when trying to import a csv file with semicolon delimiter[forwardport]. (by @nmalevanec)
 - #13361: Fix URL passed to static.php in PHP in-development server (by @nieltg)


Fixed GitHub Issues:
 - #5015: Report error csv doesn't work when trying to import a csv file with semicolon delimiter (reported by @agoeurysky) has been fixed in magento-engcom/magento2ce#1203 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. 7c03614
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ihor-sviziev @igortregub @magento-engcom-team