Translation escaping #235
Comments
|
Hello. Thanks for noticing this. Will you be able to provide a pull request with the changes? We will also need to change our internal strings generation tool. |
|
Yes, I would be able to, but is it worth that? |
|
Sorry, you are right. We need to fix the generation tool. Thank you for the information. |
|
@Detzler , the team has fixed the generation tool, so not CSV files should be correctly generated. Please expect the fix to be released with the next code update. We will close this issue once the code is released. |
magento-team
added a commit
that referenced
this issue
Feb 28, 2014
* GitHub requests: * [#235](#235) -- Translation escaping * [#463](#463) -- allow _resolveArguments to do sequential lookups * Fixed bugs: * Fixed an issue where nonexistent store views flat tables cleanuper dropped the catalog_category_flat_cl table * Fixed an issue where the Product Flat Data indexer used the helpers logic instead of the Flat State logic * Fixed an issue where an exception was thrown when applying a coupon code * Fixed an issue where a Shopping Cart Price Rule was applied to the wrong products * Fixed an issue with the broken Related Orders link on the Recurring Profile page * Fixed an issue with CMS pages preview not working * Fixed an issue with a sales report for a store view returning wrong result * Fixed an issue where shipping did not work for orders containing only bundle products * Fixed an issue where a custom not found page action did not work * Fixed an issue where user configuration for a shopping cart rule to stop further rules processing was ignored * Modularity improvements: * Resolved dependencies of the Sales module on the RecurringProfile module * Resolved dependencies of the Email Templates functionality on application modules * Lib-only dependent components of the Core module moved to library * CSS URL resolving logic moved from the publisher to a separate CSS pre-processor * Refactored the View publisher * Customer Service usage: * Refactored the Sales module to use Customer service layer * Refactored the Checkout module to use Customer service layer * Updated various PHPDoc with the parameter and return types
|
@Detzler, we have just released the dev67 code update. The fix to the issue that you reported should be available now. We are closing this issue. |
magento-team
added a commit
that referenced
this issue
Mar 18, 2014
* Themes update: * LESS styles library added in pub/lib/css/ * A new Blank theme set as default * GitHub requests: * [#491](#491) -- Fixed bug, incorrect auto-generation Category URL for some groups of symbols (idish, cirrilic, , , and other). * [#480](#480) -- Fixing a bug for loading config from local.xml * [#472](#472) -- Params passed in pub/index.php being overwritten * [#461](#461) -- Use translates for Quote\Address\Total\Shipping * [#235](#235) -- Translation escaping * [#463](#463) -- allow _resolveArguments to do sequential lookups * [#499](#499) Deleted unclosed comment in calendar.css * Fixed bugs: * Fixed a fatal error that occurred with a dependency in pub/errors/report.php * Fixed an issue where code coverage failed for Magento\SalesRule\Model\Rule\Action\Discount\CartFixedTest * Fixed an issue where PayPal Express Checkout redirected to the PayPal site even though the Allow Guest Checkout option was set to 'No' * Fixed an issue where invalid password reset link was sent when resetting customer password from the backend * Fixed an issue where it was not possible to download a previously created backup * Fixed a security issue with possibility of a XSS injection in the Integration re-authorization flow * Fixed an issue where Billing Agreement cancellation from the backend did not work * Fixed an issue with the debug section in the developer settings * Fixed the unreliable implementation of the fetching authorization header via SOAP * Fixed issues with WSDL generation error reporting * Fixed an issue with incorrect order of the Recurring Profile tab in Account Customer on the frontend * Fixed an issue when the information about a custom option of the 'File' type was not displayed correctly on the recurring profile page * Fixed an issue with editing Product template * Fixed an issue with duplicated shipping method options during checkout * Fixed an issue where flat indexers were re-indexed in shell when they were disabled * Fixed an issue where adding a wrong/nonexistent SKU using 'Order by SKU' from My Account caused a fatal error * Fixed an issue with the JS/CSS merging functionality * Fixed an issue with static view files publication tool used for the 'production' mode * Modularity improvements: * Removed the deprecated GoogleCheckout functionality * Removed all dependencies on the RecurringPayment module * Removed the Sales module dependencies on Customer models/blocks * Renamed the RecurringProfile module to RecurringPayment * Resolved dependencies between the Email Templates functionality and other modules * Moved Core module lib-only depended components to library * Moved CSS URL resolving logic from publisher to the separate CSS pre-processor * Re-factored the View publisher * Framework improvements: * Added restrictions on the data populated to the Service Data Object * Renamed Data Transfer Object to Service Data Object * Updated the view files population tool to support LESS * Customer Service usage: * Refactored the Tax module to use Customer service layer * Refactored Customer module Adminhtml internal controllers and helper to use Customer services * Added and updated the Customer service APIs * Exposed Customer services as REST APIs * Indexer implementation: * Implemented a new optimized Product Price Indexer * Updated various PHPDoc with the parameter and return types
vpelipenko
added a commit
that referenced
this issue
Apr 20, 2015
[Github] Merge public Github commits
magento-team
pushed a commit
that referenced
this issue
Dec 10, 2015
[WebDev] MAGETWO-44595 - Fixed Inconsistent use of Framework utilities
magento-engcom-team
pushed a commit
that referenced
this issue
Mar 27, 2020
MQE-1799: Throw exception during generation when leaving out .url for…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
there are something about 300 strings that are never going to be translated at runtime by magento. Look at the following example:
The quotation mark has to be backslashed to have fully qualified php syntax
And the csv-file looks like:
the string is going to be converted to "What's this?" by php.. Magento searches for the string without the backslash.. it will never find one
The text was updated successfully, but these errors were encountered: