Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dealerdirect/phpcodesniffer-composer-installer dependency to PHP 8 compatible version #31175

Closed
sivaschenko opened this issue Dec 4, 2020 · 5 comments
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Progress: done Project: PHP8

Comments

@sivaschenko
Copy link
Member

Description (*)

Update dealerdirect/phpcodesniffer-composer-installer dependency version from "^0.5.0" to "^0.7.0"
Ensure composer install runs on PHP 7.4 and 8.0

Expected behavior (*)

Benefits

Additional information

@m2-assistant
Copy link

m2-assistant bot commented Dec 4, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sergeynezbritskiy
Copy link
Contributor

@magento I am working on this

@sergeynezbritskiy
Copy link
Contributor

Hi @sivaschenko I've created the PR to php8-develop branch, but it is impossible to run composer install with php8 as per the description to this issue.
Too many packages still require php7, so I'm getting errors like this:

Problem 1
    - Installation request for colinmollenhour/php-redis-session-abstract v1.4.3 -> satisfiable by colinmollenhour/php-redis-session-abstract[v1.4.3].
    - colinmollenhour/php-redis-session-abstract v1.4.3 requires php ^5.5 || ^7.0|| ^7.1 || ^7.2 -> your PHP version (8.0.1) does not satisfy that requirement.
  Problem 2
    - Installation request for composer/composer 1.10.17 -> satisfiable by composer/composer[1.10.17].
    - composer/composer 1.10.17 requires php ^5.3.2 || ^7.0 -> your PHP version (8.0.1) does not satisfy that requirement.
  Problem 3
    - Installation request for composer/semver 1.7.1 -> satisfiable by composer/semver[1.7.1].
    - composer/semver 1.7.1 requires php ^5.3.2 || ^7.0 -> your PHP version (8.0.1) does not satisfy that requirement.
  Problem 4
    - Installation request for elasticsearch/elasticsearch v7.7.0 -> satisfiable by elasticsearch/elasticsearch[v7.7.0].
    - elasticsearch/elasticsearch v7.7.0 requires php ^7.1 -> your PHP version (8.0.1) does not satisfy that requirement.
...

@sivaschenko
Copy link
Member Author

Hi @sergeynezbritskiy thanks for the PR! We will not be able to test Magento on PHP 8 until all dependencies are updated, at the current stage we need to ensure the new package versions are functional on currently supported by Magento PHP versions ~7.3.0||~7.4.0

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko.

Thank you for your report and collaboration!

The related internal Jira ticket MC-39644 was closed as Complete.

The fix will be available with the upcoming 2.4.3 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Progress: done Project: PHP8
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants