Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mini cart shows old values when customer session is over #4416

Closed
katesuykovskaya opened this issue May 6, 2016 · 6 comments
Closed

Mini cart shows old values when customer session is over #4416

katesuykovskaya opened this issue May 6, 2016 · 6 comments
Assignees
@ishakhsuvarov @SerhiyShkolyarenko
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update

Comments

@katesuykovskaya
Copy link

Steps to reproduce

  1. Magento 2.0.2, all cache types are disabled
  2. go to frontend, do not log in
  3. add few products to shopping cart
  4. wait until session is over (1 hour by default)
  5. go to shopping cart page

Expected result

  1. shopping cart and mini shopping cart should show the same values - zero in our case

Actual result

  1. shopping cart is empty, but mini shopping cart has added products https://drive.google.com/file/d/0B6jlEIvY3J2OM0dpaEx5azM5RkU/view
@andidhouse
Copy link

Same here. I think maybe this has something to do with sessions save?

@redboxmarcins
Copy link

Same here

@ishakhsuvarov ishakhsuvarov added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels May 25, 2016
@ishakhsuvarov
Copy link
Contributor

@Katerina1993 @andidhouse @redboxmarcins Thank you for reporting this issue. Looks like we already have a similar item in our backlog with the internal id MAGETWO-52593. We will update this ticket as soon as issue is resolved.

@ishakhsuvarov ishakhsuvarov mentioned this issue May 26, 2016
Closed
@deep1086
Copy link

deep1086 commented Jul 7, 2016

@ishakhsuvarov
Having same issue.Please share info if it is resolved in any new version of magento2

AntonEvers pushed a commit to AntonEvers/magento2 that referenced this issue Jul 13, 2016
Fix minicart not cleared after order completion
a5bc70f 
Fixes magento#4460 Fixes magento#4416 Fixes magento#1461 Fixes magento#4969 Fixes MAGETWO-52593

This method is executed on `controller_action_predispatch`. The outcome of the following controller will be affected by leaving `$this->checkoutSession->setLoadInactive` set `true`.

After placing an order the `customer/section/load` page is called from the checkout overview page to update the minicart and messages sections. Because of the `controller_action_predispatch` and the passing of all checks in `\Magento\Persistent\Observer\CheckExpirePersistentQuoteObserver::execute` `setLoadInactive` is left set to true and the expired quote is loaded one more time in the minicart, resulting in expired quote data the browser storage for the success page to display.

By the way, I saw this comment:

```php
!$observer->getControllerAction() instanceof \Magento\Checkout\Controller\Onepage
// persistent session does not expire on onepage checkout page to not spoil customer group id
```

customer/section/load is not a checkout onepage controller, but it most certainly is called in the checkout. So the check in `\Magento\Persistent\Observer\CheckExpirePersistentQuoteObserver::execute` does not fully fill the gap the way the comment implies.
@AntonEvers AntonEvers mentioned this issue Jul 13, 2016
Closed
AntonEvers pushed a commit to AntonEvers/magento2 that referenced this issue Jul 26, 2016
Fix minicart not cleared after order completion
9093ce9 
Fixes magento#4460 Fixes magento#4416 Fixes magento#1461 Fixes magento#4969 Fixes MAGETWO-52593
@AntonEvers AntonEvers mentioned this issue Jul 26, 2016
Closed
@vkorotun vkorotun removed the CS label Aug 4, 2016
@SerhiyShkolyarenko SerhiyShkolyarenko self-assigned this Sep 30, 2016
@SerhiyShkolyarenko
Copy link
Contributor

@deep1086 this issue seems to be fixed several month ago. Did you manage to reproduce it on version 2.0.9 or 2.1.1?

@veloraven
Copy link
Contributor

According to contributor guide, tickets without response for two weeks should be closed.
If this issue still reproducible please feel free to create the new one: format new issue according to the Issue reporting guidelines: with steps to reproduce, actual result and expected result and specify Magento version.

AntonEvers pushed a commit to AntonEvers/magento2 that referenced this issue Sep 10, 2017
Fix minicart not cleared after order completion
36bebae 
Fixes magento#4460 Fixes magento#4416 Fixes magento#1461 Fixes magento#4969 Fixes MAGETWO-52593

(cherry picked from commit 9093ce9)
@AntonEvers AntonEvers mentioned this issue Sep 10, 2017
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ishakhsuvarov ishakhsuvarov

@SerhiyShkolyarenko SerhiyShkolyarenko

Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@veloraven @ishakhsuvarov @vkorotun @katesuykovskaya @MomotenkoNatalia @deep1086 @SerhiyShkolyarenko @andidhouse @redboxmarcins