Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer Group ID - Product Price #593

Closed
wants to merge 3 commits into from
Closed

Conversation

drdrak3
Copy link

@drdrak3 drdrak3 commented Jun 17, 2014

Changed to an !is_null as it would not enter the IF statement when the Customer Group ID === 0

  • This issue also exists in 1.9.0.1

Changed to an !is_null as it would not enter the IF statement when the Customer Group ID === 0
@verklov verklov self-assigned this Jun 18, 2014
@verklov
Copy link
Contributor

verklov commented Jun 18, 2014

@drdrak3, thank you for your contribution! I created a ticket for it in the product backlog. We will get back to you once we have it reviewed and processed.

Sub product discounts use this function separately from the main product.
In some cases Sub Products would run a different rule to the main product.
@verklov
Copy link
Contributor

verklov commented Jun 26, 2014

@drdrak3, I just talked to the development team. Could you please provide the use case for this issue? We would like to know what is the impact.
Thank you!

@drdrak3
Copy link
Author

drdrak3 commented Jun 26, 2014

In this specific case. I wanted to show VIP customer group pricing as well as standard pricing to all customers.

$_product->setCustomerGroupId(0);
$normalPrice = $_product->getPriceModel()->getFinalPrice(1, $_product);
$_product->setCustomerGroupId($vipGroupId);
$vipPrice = $_product->getPriceModel()->getFinalPrice(1, $_product);

This gets the VIP price fine for all users.
But if a customer is logged in as a VIP already, they would never see the Standard (Non-VIP) price as the function would see the CustomerGroupID as a boolean false and instead fetch the CustomerGroupID from the session.

@maksek
Copy link
Contributor

maksek commented Dec 26, 2014

Hi @drdrak3 thank you for you contribution. Can you please review you PR, and resubmit if it is actual with proper tests. Thank you for you help with Magento2.

@maksek
Copy link
Contributor

maksek commented Jan 13, 2015

Resolution: reject, due creator inactivity for more then 2 weeks. We are going to implement the update, but we can't accept the PR.

@vpelipenko
Copy link
Contributor

Suggested update is implemented and available from 0.42.0-beta7.

joanhe pushed a commit that referenced this pull request Sep 14, 2015
…only-cookies

[Extensibility] Magetwo 41967 httponly cookies
okorshenko pushed a commit that referenced this pull request Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants