Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Textarea element cols and rows #675 #1136

Merged
merged 3 commits into from
Apr 3, 2015
Merged

Fix for Textarea element cols and rows #675 #1136

merged 3 commits into from
Apr 3, 2015

Conversation

tzyganu
Copy link
Contributor

@tzyganu tzyganu commented Mar 26, 2015

This should allow developers to set the number of cols and rows for a textarea in the admin forms. PR for issue #675

@tzyganu
Copy link
Contributor Author

tzyganu commented Mar 27, 2015

it seams this failed because the tests ran for too long: Your test run exceeded 50 minutes.. Should I close this and reopen it again to restart the tests?

@vpelipenko
Copy link
Contributor

@tzyganu, if you want to restart it, you can click on "Restart build" button on this page https://travis-ci.org/magento/magento2/builds/56015517.

@tzyganu
Copy link
Contributor Author

tzyganu commented Mar 27, 2015

@vpelipenko Either I'm blind or there is no such button there. please help a blind guy out 😄

@vpelipenko
Copy link
Contributor

Sorry for confusing. Probably it depends on permissions. Could you see such button as on attached screen?
restart

@tzyganu
Copy link
Contributor Author

tzyganu commented Mar 27, 2015

@vpelipenko I don't see it. That's because I don't have write access to the repository.
So can you please click it? or give me write access to the repo. what ever is easier 😄 .

@vpelipenko
Copy link
Contributor

Ok. I've restarted build.

@tzyganu
Copy link
Contributor Author

tzyganu commented Mar 27, 2015

@vpelipenko This might be my unlucky day. The tests failed again. This time because of github.

@vpelipenko
Copy link
Contributor

Restarted again.

@vpelipenko
Copy link
Contributor

CR: passed
Builds: green
Resolution: OK to merge
Internal ticket: MAGETWO-29012

vpelipenko added a commit that referenced this pull request Apr 3, 2015
Fix for Textarea element cols and rows #675
@vpelipenko vpelipenko merged commit 50b6b3c into magento:develop Apr 3, 2015
okorshenko pushed a commit that referenced this pull request Jul 5, 2017
[TSG] Backporting for 2.1 (pr15) (2.1.8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants