#8810 - REST API - Attribute option creation -> no ID returned

[sanjay-wagento]

Set option_id in value field to attributeoptioninterface return type

Description

I have changed return type of add function and set value to option. So when we do REST or SOAP api then it will return option_id in 'value' field to attributeoptioninterface return type.

Fixed Issues (if relevant)

1. REST API - Attribute option creation -> no ID returned #8810: REST API - Attribute option creation -> no ID returned

Manual testing scenarios

1. Fresh install
2. Make following REST request:
   POST /rest/default/V1/products/attributes/manufacturer/options
   with following Body:
   { "option": { "label": "Manufacturer 1" } }

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[mzeis]

Hi @sanjay-wagento,

a few functional tests are failing and have to be adjusted because the result is not true anymore but a data array:

• Magento\Catalog\Api\ProductAttributeOptionManagementInterfaceTest::testAdd()
• Magento\Catalog\Api\ProductSwatchAttributeOptionManagementInterfaceTest::testAdd()

It would be awesome if you are able to fix this. If not, please let us know.

Thanks!

[mzeis]

@sanjay-wagento Short update: results of the performance test suite indicate this change might cause a performance degradation. We are investigating at the moment.

[okorshenko]

please return the option ID instead of object

[okorshenko]

please return the option ID instead of object

[magento-engcom-team]

Hi @sanjay-wagento. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

[hostep]

Hi all involved

Something seems to have gone wrong here.
This was discovered totally by accident btw.

In Magento 2.2-develop, when you create a new attribute option using the REST API, it returns either:

• true
• false

In Magento 2.3-develop, when you create a new attribute option using the REST API, it returns either:

• "new_option"
• false

The purpose of this PR (correct me if I'm wrong) was to return either:

• {"label":"some label","value":"123"}
• false

Reading @okorshenko remarks, I think the following needed to be returned (but might be wrong about that):

• 123
• false

After git bisecting, it looks like 5eef1d9 caused the problem.

So what was ultimately decided what needed to be returned? I assume "new_option" isn't really correct?

Would be great if either @sanjay-wagento or @sidolov could review and make sure that the correct thing happens here.

If I need to turn this into a new issue, please let me know.

Thanks!

[milindsingh]

Hi all involved

Something seems to have gone wrong here.
This was discovered totally by accident btw.

In Magento 2.2-develop, when you create a new attribute option using the REST API, it returns either:

• true
• false

In Magento 2.3-develop, when you create a new attribute option using the REST API, it returns either:

• "new_option"
• false

The purpose of this PR (correct me if I'm wrong) was to return either:

• {"label":"some label","value":"123"}
• false

Reading @okorshenko remarks, I think the following needed to be returned (but might be wrong about that):

• 123
• false

After git bisecting, it looks like 5eef1d9 caused the problem.

So what was ultimately decided what needed to be returned? I assume "new_option" isn't really correct?

Would be great if either @sanjay-wagento or @sidolov could review and make sure that the correct thing happens here.

If I need to turn this into a new issue, please let me know.

Thanks!

@hostep You are correct as original discussion was not to just return the id but the complete option data.
But as suggested by @mbrinton01 in #6300 (comment) I have backported this PR.

I still believe that it should return the complete option data.