Missing strings for Javascript Translations #1447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loaded in the js-translate.json With this fix, these files will be in the list and could be translated trough the jstranslator function
vrann
added
the
Issue: Ready for Work
|
@bartdelvauxx Thanks for PR, changes looks good. Can you please make sure all Travis builds passed. |
|
Failed integration tests is known issue and we are working on it, but unit tests should be fixed. |
|
@bartdelvauxx, thank you again for contribution. This PR was accepted and merged, but wasn't closed automatically by GitHub. |
magento-team
pushed a commit
that referenced
this pull request
Sep 1, 2017
[EngCom] Public Pull Requests - 2.1 - MAGETWO-72135: Bugfix - Multiple filter_url_params #10714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strings of static html files (like Magento_Checkout/web/template/minicart/content.html) are not loaded in the js-translation.json even if there are translations.
When looking in the code, the search for strings in these files are not loaded.
With this fix, these files will be in the list and could be translated trough the jstranslator function