Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #15393 #15687

Merged
merged 3 commits into from
Jul 29, 2018
Merged

Conversation

simonjanguapa
Copy link

Issue fix for: #15393

  1. Fixed the check for allowed HTML tags OR wysiwyg for textarea attribute types.
  2. Fix for options so that they can be rendered as HTML as well.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 2, 2018

CLA assistant check
All committers have signed the CLA.

@@ -217,7 +217,7 @@ public function testGetAttributeTextArray()
$expected = [
'Option 2',
'Option 3',
'Option 4 "!@#$%^&*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a good idea to cover more cases with the test. Possibly combinations of plain/html setting for attribue

@ishakhsuvarov
Copy link
Contributor

Hi @simonjanguapa Thank you for contribution.
We are experiencing troubles with the verification of the initial case, which has been fixed, could you please guide us on correct steps?

@simonjanguapa
Copy link
Author

simonjanguapa commented Jun 27, 2018

  • create a dropdown / multiselect attribute
  • make sure one or more of the values contain html tags (< strong >value< /strong > for instance, without spaces ofcourse)
  • make sure "allow HTML on frontend" and "use in product listing" are set to "Yes"
  • add this new attribute to an attribute set
  • create a product based on this attribute set and select at least one of the values containing HTML tags
  • look up the product on the frontend. You'll see < strong >value< /strong > without the fix, but something like value with this fix.

@kedarjoyner
Copy link

@ishakhsuvarov It looks like this PR has 3 successful checks. Any idea of when this might get pulled into the project? My team is also looking for this change. Thank you for your help!

@magento-engcom-team magento-engcom-team merged commit edb3516 into magento:2.2-develop Jul 29, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 29, 2018
@magento-engcom-team
Copy link
Contributor

Hi @simonjanguapa. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants