Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#15255 unlock customer after password reset #16256

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Jun 20, 2018

Original Pull Request

#15534

Unlock customer after password reset

Fixed Issues (if relevant)

  1. Customer who exceeded max login failures not able to login even after reset password #15255: unlock customer after password reset

Manual testing scenarios

  1. After x customer failed login, customer get locked
  2. From backend, it's sent a reset password main
  3. User changes his password
  4. User is still locked

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @vgelani. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@phoenix128 phoenix128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @vgelani , thank you for your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @phoenix128, thank you for the review.
ENGCOM-2060 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @vgelani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants