Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] PHPDoc #16365

Merged

Conversation

lfluvisotto
Copy link
Contributor

Original Pull Request

#16215

Description

PHPDoc in methods that were missing

@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets
Copy link
Contributor

Hi, @lfluvisotto , I took your PR into processing, thank you for collaboration.

@VladimirZaets
Copy link
Contributor

@lfluvisotto The phpdoc was be added to test fixture file. This led to failing InterfaceGeneratorTest test. I fixed it.

@magento-engcom-team magento-engcom-team merged commit 18c67f0 into magento:2.3-develop Jul 2, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 2, 2018
@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment