-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSI-1411: Add new rule to copy paste detector blacklist to avoid cove… #16508
MSI-1411: Add new rule to copy paste detector blacklist to avoid cove… #16508
Conversation
… fixtures on MSI modules
Hi @VitaliyBoyko. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@VitaliyBoyko could you give more insight why do we need copy-pasted fixtures? Also, any contribution must be delivered to |
Hi @orlangur MSI modules have own fixtures which are similar to core ones. Similar, but not exactly the same. Including code from core gonna bring more complexity than we suppress possible copypaste parts.
Thank you! |
Hi @orlangur @VitaliyBoyko |
Hi @ishakhsuvarov, thank you for the review. |
Hi @ishakhsuvarov |
At least some time ago the process was to put |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to discussion in Slack: fixtures are full of copy-paste but it is not possible to refactor them quickly.
Hi @orlangur, thank you for the review. |
It is important to have in |
@orlangur Currently the whole UPD: Not that I am against porting this solution. I am just not seeing a point in requiring this PR to be merged in 2.2 first. |
What I meant is that without porting 2.3 would be less strict.
It is a generic rule, isn't it? Anything applicable to 2.2 should be merged there first. |
Hi @VitaliyBoyko. Thank you for your contribution. |
Description
In the MSI modules all fixtures for tests are in
<Module_Name>/Test/_data
which is different from Magento current implementations.In order to avoid falling copy paste detector tests on the fixtures has been added a new rule to the blacklist.
Fixed Issues (if relevant)
Static test falling
PS. It's very important for MSI ;)