Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fix function unnecessarily called multiple time #16761

Merged
merged 1 commit into from
Jul 13, 2018
Merged

[Backport] Fix function unnecessarily called multiple time #16761

merged 1 commit into from
Jul 13, 2018

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Jul 13, 2018 •
edited by sidolov
Loading

Original Pull Request

#15346

Function is unnecessarily called multiple time.

Description

getCurrencySymbolsData() is called multiple times in the same file. Remove the extra call of the same function.

Fixed Issues (if relevant)

Issue Number - #15355

Manual testing scenarios

  1. Check the page. Stores > Currency > Currency Symbols

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur orlangur self-assigned this Jul 13, 2018
@orlangur orlangur changed the title Fix function unnecessarily called multiple time [Backport] Fix function unnecessarily called multiple time Jul 13, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jul 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2312 has been created to process this Pull Request

@VladimirZaets VladimirZaets mentioned this pull request Jul 13, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 7a6217c into magento:2.1-develop Jul 13, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 13, 2018
ENGCOM-2312: [Backport] Fix function unnecessarily called multiple time
fa60447 
#16761
@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

Labels
Area: Frontend Component: CurrencySymbol Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.15
Development

Successfully merging this pull request may close these issues.
3 participants
@gelanivishal @magento-engcom-team @orlangur