From 29ccdae0897db8ef212b67a8ecf92e985c8d2e42 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Samuel=20Ca=C3=A7ador?=
 <20863811+samuel27m@users.noreply.github.com>
Date: Tue, 23 Oct 2018 23:19:31 +0100
Subject: [PATCH] Remove unnecesary "header" block redeclaration

Remove unnecesary header block redeclaration on Magento Luma Theme, which made impossible to set the header template through custom modules.

Example:

- Create new module.
- Create new default.xml and try to use referenceBlock to set the template.
- Doesn't work, because Luma theme XML files are compiled after all modules and overrides the custom module modifications.

Removed because this block was already created in module Magento_Theme, so this redeclaration is just unnecesary
---
 .../Magento/luma/Magento_Customer/layout/default.xml         | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/app/design/frontend/Magento/luma/Magento_Customer/layout/default.xml b/app/design/frontend/Magento/luma/Magento_Customer/layout/default.xml
index 1f8c162ef923a..4b08bf28ece9f 100644
--- a/app/design/frontend/Magento/luma/Magento_Customer/layout/default.xml
+++ b/app/design/frontend/Magento/luma/Magento_Customer/layout/default.xml
@@ -15,11 +15,6 @@
                 </arguments>
             </block>
         </referenceBlock>
-        <block class="Magento\Theme\Block\Html\Header" name="header" as="header">
-            <arguments>
-                <argument name="show_part" xsi:type="string">welcome</argument>
-            </arguments>
-        </block>
         <move element="header" destination="header.links" before="-"/>
         <move element="register-link" destination="header.links"/>
         <move element="top.links" destination="customer"/>