Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mview patch update 41 v 4 #30129

Closed
wants to merge 14 commits into from
Closed

Mview patch update 41 v 4 #30129

wants to merge 14 commits into from

Conversation

skovalenk
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@skovalenk
Mview patch update
919fc5e
@skovalenk
Mview patch update
596ee7a
@skovalenk
Mview patch update
2631b1b
@skovalenk
Mview patch update
774c6fd
@skovalenk
Mview patch update
a0d21c4
@skovalenk
Mview patch update
a6e6d5b 
-- move framework logic to saas-export
@skovalenk
Mview patch update
20406e4 
-- move framework logic to saas-export
@skovalenk
Mview patch update
98426f5 
-- move framework logic to saas-export
@skovalenk
Mview patch update
1c39465 
-- move framework logic to saas-export
@skovalenk
Mview patch update
b540479 
-- move framework logic to saas-export
@skovalenk
Mview patch update proposal
699589d
@m2-assistant
Copy link

m2-assistant bot commented Sep 21, 2020

Hi @skovalenk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sidolov sidolov added the Catalog Storefront don't merge with 2.4-develop. PR for project https://github.com/magento/catalog-storefront/wiki label Sep 21, 2020
@skovalenk
Mview patch update proposal
5e3d72e 
--create a test for this
@skovalenk
Mview patch update proposal
824fa59 
--create a test for this
@skovalenk
Mview patch update proposal
1696d71 
--create a test for this
kandy
kandy suggested changes Sep 28, 2020
View reviewed changes
lib/internal/Magento/Framework/Mview/View/ChangelogInterface.php
@@ -11,6 +11,11 @@
*/
interface ChangelogInterface
{
const ATTRIBUTE_SCOPE_SUPPORT = 'attribute_scope';
const STORE_SCOPE_SUPPORT = 'store_scope';
const ATTRIBUTE_COLUMN = 'attribute_id';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be defined in eav module?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also visibility should be provided whether it's reusable const and a part of API (public) or part of the implementation (protected / private).

lib/internal/Magento/Framework/Mview/View/ChangelogInterface.php
const ATTRIBUTE_SCOPE_SUPPORT = 'attribute_scope';
const STORE_SCOPE_SUPPORT = 'store_scope';
const ATTRIBUTE_COLUMN = 'attribute_id';
const STORE_COLUMN = 'store_id';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be defined in store module?

@ghost ghost assigned kandy Sep 28, 2020
@ghost ghost assigned lbajsarowicz Sep 29, 2020
@aleksejsbaranovs10 aleksejsbaranovs10 mentioned this pull request Oct 1, 2020
Open
@skovalenk skovalenk closed this Oct 6, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 6, 2020

Hi @skovalenk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@kandy kandy mentioned this pull request Oct 13, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz left review comments

@kandy kandy kandy requested changes

Assignees

@kandy kandy

@lbajsarowicz lbajsarowicz

Labels
Catalog Storefront don't merge with 2.4-develop. PR for project https://github.com/magento/catalog-storefront/wiki Component: Eav Component: Mview Progress: needs update Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skovalenk @kandy @lbajsarowicz @sidolov @magento-engcom-team