Skip to content

Conversation

@sasha19957099
Copy link
Contributor

@sasha19957099 sasha19957099 commented Jan 6, 2021

…Options Selection - resolved fields according to the new schema

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Implement the schema changes for Configurable Options Selection #31332

Manual testing scenarios (*)

{
products(filter:{
sku: {eq: "configurable_12345"}
}
) {
items {
__typename
sku
... on ConfigurableProduct {
configurable_product_options_selection (configurableOptionValueUids: []) {
configurable_options {
uid
attribute_code
label
values {
uid
is_available
is_use_default
label
}
}
variant {
uid
sku
url_key
url_path
}
media_gallery {
url
label
disabled
}
}
}
}
}
}

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…election - resolved fields according to the new schema
@m2-assistant
Copy link

m2-assistant bot commented Jan 6, 2021

Hi @sasha19957099. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sasha19957099
Copy link
Contributor Author

@magento run all tests

@sasha19957099
Copy link
Contributor Author

@magento run all tests

@sasha19957099 sasha19957099 added the PAP Partners acceleration program label Jan 13, 2021
@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Jan 13, 2021
@sasha19957099 sasha19957099 self-assigned this Jan 13, 2021
@sasha19957099
Copy link
Contributor Author

@magento run Unit Tests

@sasha19957099
Copy link
Contributor Author

@magento run Database Compare

1 similar comment
@sasha19957099
Copy link
Contributor Author

@magento run Database Compare

@magento-engcom-team magento-engcom-team merged commit 11da387 into magento:2.4-develop Mar 12, 2021
@m2-assistant
Copy link

m2-assistant bot commented Mar 12, 2021

Hi @sasha19957099, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: CatalogGraphQl Component: ConfigurableProductGraphQl PAP Partners acceleration program Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: review Project: GraphQL Release Line: 2.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the schema changes for Configurable Options Selection

3 participants