From 5f2ce8f5b3920ba5d566ef9663591953302a0d72 Mon Sep 17 00:00:00 2001 From: Dan Wallis Date: Tue, 7 Mar 2023 13:36:30 +0000 Subject: [PATCH 1/3] Remove forbidden @author tag --- app/code/Magento/Customer/Model/Attribute/Data/Multiline.php | 2 -- app/code/Magento/Customer/Model/Attribute/Data/Multiselect.php | 2 -- app/code/Magento/Customer/Model/Attribute/Data/Select.php | 2 -- app/code/Magento/Customer/Model/Attribute/Data/Text.php | 2 -- app/code/Magento/Customer/Model/Attribute/Data/Textarea.php | 2 -- .../Model/Config/Backend/Password/Link/Expirationperiod.php | 2 -- app/code/Magento/Customer/Model/Config/Backend/Show/Address.php | 2 -- .../Magento/Customer/Model/Config/Backend/Show/AddressOnly.php | 2 -- .../Magento/Customer/Model/Config/Backend/Show/Customer.php | 2 -- app/code/Magento/Customer/Model/Config/Share.php | 2 -- app/code/Magento/Customer/Model/Config/Source/Address/Type.php | 2 -- .../Customer/Model/Customer/Attribute/Backend/Billing.php | 2 -- .../Customer/Model/Customer/Attribute/Backend/Shipping.php | 2 -- .../Magento/Customer/Model/Customer/Attribute/Backend/Store.php | 2 -- .../Customer/Model/Customer/Attribute/Backend/Website.php | 2 -- .../Magento/Customer/Model/Customer/Attribute/Source/Group.php | 2 -- .../Magento/Customer/Model/Customer/Attribute/Source/Store.php | 2 -- .../Customer/Model/Customer/Attribute/Source/Website.php | 2 -- app/code/Magento/Customer/Model/Form.php | 2 -- app/code/Magento/Customer/Model/Renderer/Region.php | 2 -- .../Model/ResourceModel/Address/Attribute/Backend/Region.php | 2 -- .../Model/ResourceModel/Address/Attribute/Collection.php | 2 -- .../Model/ResourceModel/Address/Attribute/Source/Country.php | 2 -- .../Address/Attribute/Source/CountryWithWebsites.php | 2 -- .../Model/ResourceModel/Address/Attribute/Source/Region.php | 2 -- .../Magento/Customer/Model/ResourceModel/Address/Collection.php | 1 - app/code/Magento/Customer/Model/ResourceModel/Attribute.php | 2 -- .../Customer/Model/ResourceModel/Attribute/Collection.php | 2 -- .../Customer/Model/ResourceModel/Customer/Collection.php | 1 - .../Magento/Customer/Model/ResourceModel/Form/Attribute.php | 2 -- .../Customer/Model/ResourceModel/Form/Attribute/Collection.php | 2 -- app/code/Magento/Customer/Model/ResourceModel/Group.php | 2 -- 32 files changed, 62 deletions(-) diff --git a/app/code/Magento/Customer/Model/Attribute/Data/Multiline.php b/app/code/Magento/Customer/Model/Attribute/Data/Multiline.php index 0039b781a8b65..cdba58367cfb5 100644 --- a/app/code/Magento/Customer/Model/Attribute/Data/Multiline.php +++ b/app/code/Magento/Customer/Model/Attribute/Data/Multiline.php @@ -6,8 +6,6 @@ /** * Customer Attribute Multiply line Data Model - * - * @author Magento Core Team */ namespace Magento\Customer\Model\Attribute\Data; diff --git a/app/code/Magento/Customer/Model/Attribute/Data/Multiselect.php b/app/code/Magento/Customer/Model/Attribute/Data/Multiselect.php index 9284a532a0eb5..02874ee81f544 100644 --- a/app/code/Magento/Customer/Model/Attribute/Data/Multiselect.php +++ b/app/code/Magento/Customer/Model/Attribute/Data/Multiselect.php @@ -6,8 +6,6 @@ /** * Customer Attribute Multiply select Data Model - * - * @author Magento Core Team */ namespace Magento\Customer\Model\Attribute\Data; diff --git a/app/code/Magento/Customer/Model/Attribute/Data/Select.php b/app/code/Magento/Customer/Model/Attribute/Data/Select.php index f0b460adfc70e..394219cde012e 100644 --- a/app/code/Magento/Customer/Model/Attribute/Data/Select.php +++ b/app/code/Magento/Customer/Model/Attribute/Data/Select.php @@ -6,8 +6,6 @@ /** * Customer Attribute Select Data Model - * - * @author Magento Core Team */ namespace Magento\Customer\Model\Attribute\Data; diff --git a/app/code/Magento/Customer/Model/Attribute/Data/Text.php b/app/code/Magento/Customer/Model/Attribute/Data/Text.php index b6264efcc06ee..019ccf688a131 100644 --- a/app/code/Magento/Customer/Model/Attribute/Data/Text.php +++ b/app/code/Magento/Customer/Model/Attribute/Data/Text.php @@ -6,8 +6,6 @@ /** * Customer Attribute Text Data Model - * - * @author Magento Core Team */ namespace Magento\Customer\Model\Attribute\Data; diff --git a/app/code/Magento/Customer/Model/Attribute/Data/Textarea.php b/app/code/Magento/Customer/Model/Attribute/Data/Textarea.php index 83f19bde2e70c..0e5b208278255 100644 --- a/app/code/Magento/Customer/Model/Attribute/Data/Textarea.php +++ b/app/code/Magento/Customer/Model/Attribute/Data/Textarea.php @@ -6,8 +6,6 @@ /** * Customer Attribute Text Area Data Model - * - * @author Magento Core Team */ namespace Magento\Customer\Model\Attribute\Data; diff --git a/app/code/Magento/Customer/Model/Config/Backend/Password/Link/Expirationperiod.php b/app/code/Magento/Customer/Model/Config/Backend/Password/Link/Expirationperiod.php index eb816fdd8362a..2a6d4ff048702 100644 --- a/app/code/Magento/Customer/Model/Config/Backend/Password/Link/Expirationperiod.php +++ b/app/code/Magento/Customer/Model/Config/Backend/Password/Link/Expirationperiod.php @@ -7,8 +7,6 @@ /** * Customer Reset Password Link Expiration period backend model - * - * @author Magento Core Team */ class Expirationperiod extends \Magento\Framework\App\Config\Value { diff --git a/app/code/Magento/Customer/Model/Config/Backend/Show/Address.php b/app/code/Magento/Customer/Model/Config/Backend/Show/Address.php index e461643a23beb..a7e62abef5022 100644 --- a/app/code/Magento/Customer/Model/Config/Backend/Show/Address.php +++ b/app/code/Magento/Customer/Model/Config/Backend/Show/Address.php @@ -9,8 +9,6 @@ /** * Customer Show Address Model - * - * @author Magento Core Team */ class Address extends Customer { diff --git a/app/code/Magento/Customer/Model/Config/Backend/Show/AddressOnly.php b/app/code/Magento/Customer/Model/Config/Backend/Show/AddressOnly.php index 985acc15cfec2..0463895e4a7c9 100644 --- a/app/code/Magento/Customer/Model/Config/Backend/Show/AddressOnly.php +++ b/app/code/Magento/Customer/Model/Config/Backend/Show/AddressOnly.php @@ -9,8 +9,6 @@ /** * Customer Show Address Model - * - * @author Magento Core Team */ class AddressOnly extends Customer { diff --git a/app/code/Magento/Customer/Model/Config/Backend/Show/Customer.php b/app/code/Magento/Customer/Model/Config/Backend/Show/Customer.php index f4418c2832855..beafa8c66b7bc 100644 --- a/app/code/Magento/Customer/Model/Config/Backend/Show/Customer.php +++ b/app/code/Magento/Customer/Model/Config/Backend/Show/Customer.php @@ -10,8 +10,6 @@ /** * Customer Show Customer Model - * - * @author Magento Core Team */ class Customer extends \Magento\Framework\App\Config\Value { diff --git a/app/code/Magento/Customer/Model/Config/Share.php b/app/code/Magento/Customer/Model/Config/Share.php index e5dda28afa095..ab04dde483c4a 100644 --- a/app/code/Magento/Customer/Model/Config/Share.php +++ b/app/code/Magento/Customer/Model/Config/Share.php @@ -7,8 +7,6 @@ /** * Customer sharing config model - * - * @author Magento Core Team */ class Share extends \Magento\Framework\App\Config\Value implements \Magento\Framework\Option\ArrayInterface { diff --git a/app/code/Magento/Customer/Model/Config/Source/Address/Type.php b/app/code/Magento/Customer/Model/Config/Source/Address/Type.php index 76ab43755ce86..2b5b344178105 100644 --- a/app/code/Magento/Customer/Model/Config/Source/Address/Type.php +++ b/app/code/Magento/Customer/Model/Config/Source/Address/Type.php @@ -6,8 +6,6 @@ /** * Source model of customer address types - * - * @author Magento Core Team */ namespace Magento\Customer\Model\Config\Source\Address; diff --git a/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Billing.php b/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Billing.php index 8aefd506194fc..56e0b9c542998 100644 --- a/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Billing.php +++ b/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Billing.php @@ -7,8 +7,6 @@ /** * Customer default billing address backend - * - * @author Magento Core Team */ class Billing extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBackend { diff --git a/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Shipping.php b/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Shipping.php index 5fcb5189c0740..8a7a227dc8848 100644 --- a/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Shipping.php +++ b/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Shipping.php @@ -7,8 +7,6 @@ /** * Customer default shipping address backend - * - * @author Magento Core Team */ class Shipping extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBackend { diff --git a/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Store.php b/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Store.php index 34374e1bfbf60..a857cd0d6e1e4 100644 --- a/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Store.php +++ b/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Store.php @@ -7,8 +7,6 @@ /** * Store attribute backend - * - * @author Magento Core Team */ class Store extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBackend { diff --git a/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Website.php b/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Website.php index 94152b054d688..bef41da60112a 100644 --- a/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Website.php +++ b/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Website.php @@ -7,8 +7,6 @@ /** * Website attribute backend - * - * @author Magento Core Team */ class Website extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBackend { diff --git a/app/code/Magento/Customer/Model/Customer/Attribute/Source/Group.php b/app/code/Magento/Customer/Model/Customer/Attribute/Source/Group.php index 83aa29ea45265..1f8059b734c8e 100644 --- a/app/code/Magento/Customer/Model/Customer/Attribute/Source/Group.php +++ b/app/code/Magento/Customer/Model/Customer/Attribute/Source/Group.php @@ -9,8 +9,6 @@ /** * Customer group attribute source - * - * @author Magento Core Team */ class Group extends \Magento\Eav\Model\Entity\Attribute\Source\Table implements GroupSourceLoggedInOnlyInterface { diff --git a/app/code/Magento/Customer/Model/Customer/Attribute/Source/Store.php b/app/code/Magento/Customer/Model/Customer/Attribute/Source/Store.php index 85c23c98975a7..8454e2b6d0cc4 100644 --- a/app/code/Magento/Customer/Model/Customer/Attribute/Source/Store.php +++ b/app/code/Magento/Customer/Model/Customer/Attribute/Source/Store.php @@ -7,8 +7,6 @@ /** * Customer store attribute source - * - * @author Magento Core Team */ class Store extends \Magento\Eav\Model\Entity\Attribute\Source\Table { diff --git a/app/code/Magento/Customer/Model/Customer/Attribute/Source/Website.php b/app/code/Magento/Customer/Model/Customer/Attribute/Source/Website.php index 43c68f06d5f6c..28ab10e084f89 100644 --- a/app/code/Magento/Customer/Model/Customer/Attribute/Source/Website.php +++ b/app/code/Magento/Customer/Model/Customer/Attribute/Source/Website.php @@ -7,8 +7,6 @@ /** * Customer website attribute source - * - * @author Magento Core Team */ class Website extends \Magento\Eav\Model\Entity\Attribute\Source\Table { diff --git a/app/code/Magento/Customer/Model/Form.php b/app/code/Magento/Customer/Model/Form.php index 9a9b867e3bfc8..b23a80ac409b8 100644 --- a/app/code/Magento/Customer/Model/Form.php +++ b/app/code/Magento/Customer/Model/Form.php @@ -6,8 +6,6 @@ /** * Customer Form Model - * - * @author Magento Core Team */ namespace Magento\Customer\Model; diff --git a/app/code/Magento/Customer/Model/Renderer/Region.php b/app/code/Magento/Customer/Model/Renderer/Region.php index a3d747b0c0236..d355c61cdd9b1 100644 --- a/app/code/Magento/Customer/Model/Renderer/Region.php +++ b/app/code/Magento/Customer/Model/Renderer/Region.php @@ -9,8 +9,6 @@ /** * Region field renderer - * - * @author Magento Core Team */ class Region implements \Magento\Framework\Data\Form\Element\Renderer\RendererInterface { diff --git a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Backend/Region.php b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Backend/Region.php index 6b30e518a3bbf..57c26fb6d7305 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Backend/Region.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Backend/Region.php @@ -7,8 +7,6 @@ /** * Address region attribute backend - * - * @author Magento Core Team */ class Region extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBackend { diff --git a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Collection.php b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Collection.php index 59b139f283941..387f717fdd6a1 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Collection.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Collection.php @@ -6,8 +6,6 @@ /** * Customer Address EAV additional attribute resource collection - * - * @author Magento Core Team */ namespace Magento\Customer\Model\ResourceModel\Address\Attribute; diff --git a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Country.php b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Country.php index 62339cc7b974f..b8bdc1c9ef800 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Country.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Country.php @@ -6,8 +6,6 @@ /** * Customer country attribute source - * - * @author Magento Core Team */ namespace Magento\Customer\Model\ResourceModel\Address\Attribute\Source; diff --git a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/CountryWithWebsites.php b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/CountryWithWebsites.php index c2db95813fe93..5a50009d3a499 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/CountryWithWebsites.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/CountryWithWebsites.php @@ -6,8 +6,6 @@ /** * Customer country with website specified attribute source - * - * @author Magento Core Team */ namespace Magento\Customer\Model\ResourceModel\Address\Attribute\Source; diff --git a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Region.php b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Region.php index 2cafdab077d67..42d66d85be644 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Region.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Region.php @@ -6,8 +6,6 @@ /** * Customer region attribute source - * - * @author Magento Core Team */ namespace Magento\Customer\Model\ResourceModel\Address\Attribute\Source; diff --git a/app/code/Magento/Customer/Model/ResourceModel/Address/Collection.php b/app/code/Magento/Customer/Model/ResourceModel/Address/Collection.php index a26228ccc9062..7f9df4563c49c 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Address/Collection.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Address/Collection.php @@ -9,7 +9,6 @@ * Customers collection * * @api - * @author Magento Core Team * @since 100.0.2 */ class Collection extends \Magento\Eav\Model\Entity\Collection\VersionControl\AbstractCollection diff --git a/app/code/Magento/Customer/Model/ResourceModel/Attribute.php b/app/code/Magento/Customer/Model/ResourceModel/Attribute.php index 827aa2f293f3b..ac38305a0f4f8 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Attribute.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Attribute.php @@ -6,8 +6,6 @@ /** * Customer attribute resource model - * - * @author Magento Core Team */ namespace Magento\Customer\Model\ResourceModel; diff --git a/app/code/Magento/Customer/Model/ResourceModel/Attribute/Collection.php b/app/code/Magento/Customer/Model/ResourceModel/Attribute/Collection.php index 4dd2eaa68b686..95fba2a097471 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Attribute/Collection.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Attribute/Collection.php @@ -6,8 +6,6 @@ /** * Customer EAV additional attribute resource collection - * - * @author Magento Core Team */ namespace Magento\Customer\Model\ResourceModel\Attribute; diff --git a/app/code/Magento/Customer/Model/ResourceModel/Customer/Collection.php b/app/code/Magento/Customer/Model/ResourceModel/Customer/Collection.php index af8980a129d3e..aca16a3101a9a 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Customer/Collection.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Customer/Collection.php @@ -8,7 +8,6 @@ /** * Customers collection * - * @author Magento Core Team * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Collection extends \Magento\Eav\Model\Entity\Collection\VersionControl\AbstractCollection diff --git a/app/code/Magento/Customer/Model/ResourceModel/Form/Attribute.php b/app/code/Magento/Customer/Model/ResourceModel/Form/Attribute.php index 5623e8e6ddf23..e7352011a0fe7 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Form/Attribute.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Form/Attribute.php @@ -7,8 +7,6 @@ /** * Customer Form Attribute Resource Model - * - * @author Magento Core Team */ class Attribute extends \Magento\Eav\Model\ResourceModel\Form\Attribute { diff --git a/app/code/Magento/Customer/Model/ResourceModel/Form/Attribute/Collection.php b/app/code/Magento/Customer/Model/ResourceModel/Form/Attribute/Collection.php index f51f8cd85db4f..d170f02d91a3d 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Form/Attribute/Collection.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Form/Attribute/Collection.php @@ -7,8 +7,6 @@ /** * Customer Form Attribute Resource Collection - * - * @author Magento Core Team */ class Collection extends \Magento\Eav\Model\ResourceModel\Form\Attribute\Collection { diff --git a/app/code/Magento/Customer/Model/ResourceModel/Group.php b/app/code/Magento/Customer/Model/ResourceModel/Group.php index 987723c5c9f58..e3f773427dd05 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Group.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Group.php @@ -10,8 +10,6 @@ /** * Customer group resource model - * - * @author Magento Core Team */ class Group extends \Magento\Framework\Model\ResourceModel\Db\VersionControl\AbstractDb { From 55c42b8b2d80e93d7160004c51ccad91817ac219 Mon Sep 17 00:00:00 2001 From: Dan Wallis Date: Tue, 14 Mar 2023 20:58:09 +0000 Subject: [PATCH 2/3] Fix static test failures --- app/code/Magento/Customer/Model/Config/Share.php | 9 +++------ .../Model/Customer/Attribute/Backend/Billing.php | 4 ++++ .../Model/Customer/Attribute/Backend/Shipping.php | 4 ++++ .../Customer/Model/Customer/Attribute/Source/Store.php | 4 ++++ .../Customer/Model/Customer/Attribute/Source/Website.php | 2 ++ app/code/Magento/Customer/Model/Form.php | 9 ++++----- .../ResourceModel/Address/Attribute/Backend/Region.php | 2 ++ .../ResourceModel/Address/Attribute/Source/Country.php | 9 ++++----- .../ResourceModel/Address/Attribute/Source/Region.php | 2 ++ .../Customer/Model/ResourceModel/Customer/Collection.php | 2 +- app/code/Magento/Customer/Model/ResourceModel/Group.php | 2 -- 11 files changed, 30 insertions(+), 19 deletions(-) diff --git a/app/code/Magento/Customer/Model/Config/Share.php b/app/code/Magento/Customer/Model/Config/Share.php index ab04dde483c4a..8f8c872ca26ca 100644 --- a/app/code/Magento/Customer/Model/Config/Share.php +++ b/app/code/Magento/Customer/Model/Config/Share.php @@ -14,15 +14,14 @@ class Share extends \Magento\Framework\App\Config\Value implements \Magento\Fram * Xml config path to customers sharing scope value * */ - const XML_PATH_CUSTOMER_ACCOUNT_SHARE = 'customer/account_share/scope'; + public const XML_PATH_CUSTOMER_ACCOUNT_SHARE = 'customer/account_share/scope'; /** * Possible customer sharing scopes * */ - const SHARE_GLOBAL = 0; - - const SHARE_WEBSITE = 1; + public const SHARE_GLOBAL = 0; + public const SHARE_WEBSITE = 1; /** * @var \Magento\Customer\Model\ResourceModel\Customer @@ -35,8 +34,6 @@ class Share extends \Magento\Framework\App\Config\Value implements \Magento\Fram protected $_storeManager; /** - * Constructor - * * @param \Magento\Framework\Model\Context $context * @param \Magento\Framework\Registry $registry * @param \Magento\Framework\App\Config\ScopeConfigInterface $config diff --git a/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Billing.php b/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Billing.php index 56e0b9c542998..6fad429882d63 100644 --- a/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Billing.php +++ b/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Billing.php @@ -11,6 +11,8 @@ class Billing extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBackend { /** + * Before save + * * @param \Magento\Framework\DataObject $object * @return void */ @@ -23,6 +25,8 @@ public function beforeSave($object) } /** + * After save + * * @param \Magento\Framework\DataObject $object * @return void */ diff --git a/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Shipping.php b/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Shipping.php index 8a7a227dc8848..131225ce8d700 100644 --- a/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Shipping.php +++ b/app/code/Magento/Customer/Model/Customer/Attribute/Backend/Shipping.php @@ -11,6 +11,8 @@ class Shipping extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBackend { /** + * Before save + * * @param \Magento\Framework\DataObject $object * @return void */ @@ -23,6 +25,8 @@ public function beforeSave($object) } /** + * After save + * * @param \Magento\Framework\DataObject $object * @return void */ diff --git a/app/code/Magento/Customer/Model/Customer/Attribute/Source/Store.php b/app/code/Magento/Customer/Model/Customer/Attribute/Source/Store.php index 8454e2b6d0cc4..4a552f61c7849 100644 --- a/app/code/Magento/Customer/Model/Customer/Attribute/Source/Store.php +++ b/app/code/Magento/Customer/Model/Customer/Attribute/Source/Store.php @@ -56,6 +56,8 @@ public function getAllOptions($withEmpty = true, $defaultValues = false) } /** + * Return option text + * * @param string $value * @return array|string */ @@ -93,6 +95,8 @@ public function getOptionText($value) } /** + * Return new stores collection + * * @return \Magento\Store\Model\ResourceModel\Store\Collection */ protected function _createStoresCollection() diff --git a/app/code/Magento/Customer/Model/Customer/Attribute/Source/Website.php b/app/code/Magento/Customer/Model/Customer/Attribute/Source/Website.php index 28ab10e084f89..5d02307d99aa0 100644 --- a/app/code/Magento/Customer/Model/Customer/Attribute/Source/Website.php +++ b/app/code/Magento/Customer/Model/Customer/Attribute/Source/Website.php @@ -42,6 +42,8 @@ public function getAllOptions($withEmpty = true, $defaultValues = false) } /** + * Return option text + * * @param int|string $value * @return string|false */ diff --git a/app/code/Magento/Customer/Model/Form.php b/app/code/Magento/Customer/Model/Form.php index b23a80ac409b8..807e684c1fab4 100644 --- a/app/code/Magento/Customer/Model/Form.php +++ b/app/code/Magento/Customer/Model/Form.php @@ -4,17 +4,17 @@ * See COPYING.txt for license details. */ +namespace Magento\Customer\Model; + /** * Customer Form Model */ -namespace Magento\Customer\Model; - class Form extends \Magento\Eav\Model\Form { /** * XML configuration paths for "Disable autocomplete on storefront" property */ - const XML_PATH_ENABLE_AUTOCOMPLETE = 'customer/password/autocomplete_on_storefront'; + public const XML_PATH_ENABLE_AUTOCOMPLETE = 'customer/password/autocomplete_on_storefront'; /** * Current module pathname @@ -31,8 +31,7 @@ class Form extends \Magento\Eav\Model\Form protected $_entityTypeCode = 'customer'; /** - * Get EAV Entity Form Attribute Collection for Customer - * exclude 'created_at' + * Get EAV Entity Form Attribute Collection for Customer exclude 'created_at' * * @return \Magento\Customer\Model\ResourceModel\Form\Attribute\Collection */ diff --git a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Backend/Region.php b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Backend/Region.php index 57c26fb6d7305..61e4593c047b0 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Backend/Region.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Backend/Region.php @@ -43,6 +43,8 @@ public function beforeSave($object) } /** + * Return new region object + * * @return \Magento\Directory\Model\Region */ protected function _createRegionInstance() diff --git a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Country.php b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Country.php index b8bdc1c9ef800..00cecceca3bc2 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Country.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Country.php @@ -4,17 +4,13 @@ * See COPYING.txt for license details. */ -/** - * Customer country attribute source - */ namespace Magento\Customer\Model\ResourceModel\Address\Attribute\Source; use Magento\Framework\App\ObjectManager; use Magento\Store\Model\StoreManagerInterface; /** - * Class Country. - * @package Magento\Customer\Model\ResourceModel\Address\Attribute\Source + * Customer country attribute source */ class Country extends \Magento\Eav\Model\Entity\Attribute\Source\Table { @@ -56,6 +52,8 @@ public function getAllOptions($withEmpty = true, $defaultValues = false) } /** + * Return new countries object + * * @return \Magento\Directory\Model\ResourceModel\Country\Collection */ protected function _createCountriesCollection() @@ -65,6 +63,7 @@ protected function _createCountriesCollection() /** * Retrieve Store Manager + * * @deprecated 101.0.0 * @return StoreManagerInterface */ diff --git a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Region.php b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Region.php index 42d66d85be644..0775716ae9c60 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Region.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Region.php @@ -42,6 +42,8 @@ public function getAllOptions($withEmpty = true, $defaultValues = false) } /** + * Return new regions object + * * @return \Magento\Directory\Model\ResourceModel\Region\Collection */ protected function _createRegionsCollection() diff --git a/app/code/Magento/Customer/Model/ResourceModel/Customer/Collection.php b/app/code/Magento/Customer/Model/ResourceModel/Customer/Collection.php index aca16a3101a9a..fb4603c79e5fd 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Customer/Collection.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Customer/Collection.php @@ -15,7 +15,7 @@ class Collection extends \Magento\Eav\Model\Entity\Collection\VersionControl\Abs /** * Name of collection model */ - const CUSTOMER_MODEL_NAME = \Magento\Customer\Model\Customer::class; + public const CUSTOMER_MODEL_NAME = \Magento\Customer\Model\Customer::class; /** * @var \Magento\Framework\DataObject\Copy\Config diff --git a/app/code/Magento/Customer/Model/ResourceModel/Group.php b/app/code/Magento/Customer/Model/ResourceModel/Group.php index e3f773427dd05..6b56298500c57 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Group.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Group.php @@ -14,8 +14,6 @@ class Group extends \Magento\Framework\Model\ResourceModel\Db\VersionControl\AbstractDb { /** - * Group Management - * * @var \Magento\Customer\Api\GroupManagementInterface */ protected $_groupManagement; From 62ac8b7c29b810d7c2a829a8b1842923ecb693f4 Mon Sep 17 00:00:00 2001 From: Anupam Bhatt <51681435+engcom-Echo@users.noreply.github.com> Date: Wed, 26 Jun 2024 15:14:08 +0530 Subject: [PATCH 3/3] Fixed failing static tests --- .../Model/ResourceModel/Address/Attribute/Source/Country.php | 1 + 1 file changed, 1 insertion(+) diff --git a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Country.php b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Country.php index 00cecceca3bc2..2f58b2d7e3213 100644 --- a/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Country.php +++ b/app/code/Magento/Customer/Model/ResourceModel/Address/Attribute/Source/Country.php @@ -65,6 +65,7 @@ protected function _createCountriesCollection() * Retrieve Store Manager * * @deprecated 101.0.0 + * @see nothing * @return StoreManagerInterface */ private function getStoreManager()