magento/magento2#38059 Fix issue with product in cart's removed after…

[BeggiNN]

Fix issue with product in cart's removed after reorder multiple times

Related Pull Requests

https://github.com/magento-gl/magento2b2b/pull/102

Description (*)

Product in cart's removed after reorder multiple times if reorder this order until the quantity of the above product reaches the Maximum Qty Allowed in Shopping Cart number

Fixed Issues (if relevant)

1. Fixes Product in cart's removed after reorder multiple times #38059

Manual testing scenarios (*)

1. Navigate to Admin -> Catalog -> Product -> Choose a product -> Advanced Inventory -> set Maximum Qty Allowed in Shopping Cart to a small number -> Save product.
2. Navigate to Shop page -> Login -> Order history page -> Reorder the order which contains the above product
3. Reorder this order until the quantity of the above product reaches the Maximum Qty Allowed in Shopping Cart number

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @BeggiNN. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[BeggiNN]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[BeggiNN]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[BeggiNN]

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[BeggiNN]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

@magento run Functional Tests B2B, Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

Hello @BeggiNN,

Thanks for the contribution!

Failed tests seem flaky to me. But in accordance with DOD, please cover these changes with some automated tests.

Thanks

[engcom-Bravo]

As per the PO these scenarios #38069 (review) will consider as a Feature Request.

As Per the PO Confirmation We are proceeding with this PR.

[engcom-Bravo]

@magento run all tests

[engcom-Bravo]

@magento give me test instance

[magento-deployment-service]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Bravo, here is your Magento Instance: https://11a7a71c55e06a2cc065efca74a1cf94.instances-prod.magento-community.engineering
Admin access: https://11a7a71c55e06a2cc065efca74a1cf94.instances-prod.magento-community.engineering/admin_88c1
Login: b39ea940
Password: 78335d8e7984

[engcom-Bravo]

Hi @BeggiNN,

Thanks for your Contribution.

The issue has been confirmed here #38059 (comment) now the issue is not reproducible.Kindly refer the attached video.

Screen.Recording.2024-05-14.at.15.57.50.mov

But we have observed a new issue that while reordering when the product exceeds maximum quantity it is giving an error but the product is added to the cart more than maximum quantity and there is no proceed to checkout option.

We have verified this issue with the PR changes it is not fixing the issue.Could you please check the behaviour and let us know if we are missing anything.

Thanks.

[engcom-Bravo]

Hi @BeggiNN,

We are not able to reproduce the issue.

Can you please confirm the issue still exist on 2.4-develop?

please refer to this #38069 (review)

Lets us know if you are still facing the issue on 2.4-develop with detailed steps.

Moving it to on hold

Thanks.

[engcom-Bravo]

Hi @BeggiNN,

Thank you for your contribution!

As mentioned here, please have a look and let us know if we are missing anything.

Till then closing this PR. Please feel free to reopen it as you want to update further.

Thank you!