From 00856aecb3d2802933ad4f481ec42eafb8d494dd Mon Sep 17 00:00:00 2001 From: dverkade Date: Thu, 6 Oct 2016 21:36:01 +0200 Subject: [PATCH 1/3] Removed commented out line for ignoring coding standards Removed commented out line for ignoring coding standards, this line should not be in the code and is removed for cleaner more readable code. --- lib/internal/Magento/Framework/Profiler/Driver/Factory.php | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/internal/Magento/Framework/Profiler/Driver/Factory.php b/lib/internal/Magento/Framework/Profiler/Driver/Factory.php index 5975f60f41ddb..cfa17117b82c3 100644 --- a/lib/internal/Magento/Framework/Profiler/Driver/Factory.php +++ b/lib/internal/Magento/Framework/Profiler/Driver/Factory.php @@ -5,9 +5,6 @@ * Copyright © 2016 Magento. All rights reserved. * See COPYING.txt for license details. */ - -// @codingStandardsIgnoreFile - namespace Magento\Framework\Profiler\Driver; use Magento\Framework\Profiler\DriverInterface; From aaad8155a218e0de14d6408d0f9a7dc9bc5a3f96 Mon Sep 17 00:00:00 2001 From: dverkade Date: Thu, 20 Oct 2016 22:00:30 +0200 Subject: [PATCH 2/3] Changed line length Changed line length so that the @ignoreCodingStandard which was removed will not throw an exception anymore. --- lib/internal/Magento/Framework/Profiler/Driver/Factory.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/internal/Magento/Framework/Profiler/Driver/Factory.php b/lib/internal/Magento/Framework/Profiler/Driver/Factory.php index cfa17117b82c3..88d9792a697ec 100644 --- a/lib/internal/Magento/Framework/Profiler/Driver/Factory.php +++ b/lib/internal/Magento/Framework/Profiler/Driver/Factory.php @@ -62,7 +62,10 @@ public function create(array $config = null) $driver = new $class($config); if (!$driver instanceof DriverInterface) { throw new \InvalidArgumentException( - sprintf("Driver class \"%s\" must implement \Magento\Framework\Profiler\DriverInterface.", get_class($driver)) + sprintf( + "Driver class \"%s\" must implement \Magento\Framework\Profiler\DriverInterface.", + get_class($driver) + ) ); } return $driver; From 54a2356c1b7eb467b1e3fec93d0ca4ee77637bea Mon Sep 17 00:00:00 2001 From: dverkade Date: Thu, 20 Oct 2016 23:22:16 +0200 Subject: [PATCH 3/3] Update Factory.php --- lib/internal/Magento/Framework/Profiler/Driver/Factory.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/internal/Magento/Framework/Profiler/Driver/Factory.php b/lib/internal/Magento/Framework/Profiler/Driver/Factory.php index 88d9792a697ec..f228ca8043fd1 100644 --- a/lib/internal/Magento/Framework/Profiler/Driver/Factory.php +++ b/lib/internal/Magento/Framework/Profiler/Driver/Factory.php @@ -63,7 +63,7 @@ public function create(array $config = null) if (!$driver instanceof DriverInterface) { throw new \InvalidArgumentException( sprintf( - "Driver class \"%s\" must implement \Magento\Framework\Profiler\DriverInterface.", + "Driver class \"%s\" must implement \Magento\Framework\Profiler\DriverInterface.", get_class($driver) ) );